* [Buildroot] [git commit] libevent: fix openssl detection when statically linking
@ 2015-02-27 7:54 Peter Korsgaard
2015-02-27 14:30 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2015-02-27 7:54 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=f29bb169cff521e01f9e94af7275a4e110d256bc
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Fixes (indirectly):
http://autobuild.buildroot.net/results/dbf/dbf2d348de3831a86728f9d72cb56b9f2ddbf554/
http://autobuild.buildroot.net/results/6a8/6a89183e558e4ff27841c3e544687ad4a04fb036/
http://autobuild.buildroot.net/results/c80/c80eedb4d7335f1aef736a1312900c2b371eabc9/
http://autobuild.buildroot.net/results/91b/91b4ab54ed9d422bfaef765d09cc92192012ce7e/
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/libevent/libevent.mk | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/package/libevent/libevent.mk b/package/libevent/libevent.mk
index c50b1d2..d67c738 100644
--- a/package/libevent/libevent.mk
+++ b/package/libevent/libevent.mk
@@ -26,6 +26,11 @@ endif
ifeq ($(BR2_PACKAGE_OPENSSL),y)
LIBEVENT_DEPENDENCIES += openssl
LIBEVENT_CONF_OPTS += --enable-openssl
+# openssl needs zlib but configure forgets to link against it causing
+# openssl detection to fail
+ifeq ($(BR2_STATIC_LIBS),y)
+LIBEVENT_CONF_ENV += OPENSSL_LIBADD='-lz'
+endif
else
LIBEVENT_CONF_OPTS += --disable-openssl
endif
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [git commit] libevent: fix openssl detection when statically linking
2015-02-27 7:54 [Buildroot] [git commit] libevent: fix openssl detection when statically linking Peter Korsgaard
@ 2015-02-27 14:30 ` Thomas Petazzoni
2015-02-27 14:44 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2015-02-27 14:30 UTC (permalink / raw)
To: buildroot
Dear Peter Korsgaard,
On Fri, 27 Feb 2015 08:54:33 +0100, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=f29bb169cff521e01f9e94af7275a4e110d256bc
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Fixes (indirectly):
> http://autobuild.buildroot.net/results/dbf/dbf2d348de3831a86728f9d72cb56b9f2ddbf554/
> http://autobuild.buildroot.net/results/6a8/6a89183e558e4ff27841c3e544687ad4a04fb036/
> http://autobuild.buildroot.net/results/c80/c80eedb4d7335f1aef736a1312900c2b371eabc9/
> http://autobuild.buildroot.net/results/91b/91b4ab54ed9d422bfaef765d09cc92192012ce7e/
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Gaaah. See the proper solution I had already posted at
http://lists.busybox.net/pipermail/buildroot/2015-February/119998.html.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [git commit] libevent: fix openssl detection when statically linking
2015-02-27 14:30 ` Thomas Petazzoni
@ 2015-02-27 14:44 ` Peter Korsgaard
2015-02-27 15:01 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2015-02-27 14:44 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Peter Korsgaard,
> On Fri, 27 Feb 2015 08:54:33 +0100, Peter Korsgaard wrote:
>> commit: http://git.buildroot.net/buildroot/commit/?id=f29bb169cff521e01f9e94af7275a4e110d256bc
>> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>
>> Fixes (indirectly):
>> http://autobuild.buildroot.net/results/dbf/dbf2d348de3831a86728f9d72cb56b9f2ddbf554/
>> http://autobuild.buildroot.net/results/6a8/6a89183e558e4ff27841c3e544687ad4a04fb036/
>> http://autobuild.buildroot.net/results/c80/c80eedb4d7335f1aef736a1312900c2b371eabc9/
>> http://autobuild.buildroot.net/results/91b/91b4ab54ed9d422bfaef765d09cc92192012ce7e/
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> Gaaah. See the proper solution I had already posted at
> http://lists.busybox.net/pipermail/buildroot/2015-February/119998.html.
That also looks ok. Did you try submitting it upstream?
Just passing OPENSSL_LIBADD seems like a safer approach this close to
the release though (E.G. tonight).
--
Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [git commit] libevent: fix openssl detection when statically linking
2015-02-27 14:44 ` Peter Korsgaard
@ 2015-02-27 15:01 ` Thomas Petazzoni
2015-02-27 15:15 ` Peter Korsgaard
2015-02-27 20:50 ` Romain Naour
0 siblings, 2 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2015-02-27 15:01 UTC (permalink / raw)
To: buildroot
Dear Peter Korsgaard,
On Fri, 27 Feb 2015 15:44:06 +0100, Peter Korsgaard wrote:
> That also looks ok. Did you try submitting it upstream?
No, I was hoping for Romain to pick up on the task actually :-)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [git commit] libevent: fix openssl detection when statically linking
2015-02-27 15:01 ` Thomas Petazzoni
@ 2015-02-27 15:15 ` Peter Korsgaard
2015-02-27 20:50 ` Romain Naour
1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2015-02-27 15:15 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Peter Korsgaard,
> On Fri, 27 Feb 2015 15:44:06 +0100, Peter Korsgaard wrote:
>> That also looks ok. Did you try submitting it upstream?
> No, I was hoping for Romain to pick up on the task actually :-)
Ok :P
I'll leave it as it is for 2015.02 then.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [git commit] libevent: fix openssl detection when statically linking
2015-02-27 15:01 ` Thomas Petazzoni
2015-02-27 15:15 ` Peter Korsgaard
@ 2015-02-27 20:50 ` Romain Naour
2015-02-28 9:59 ` Thomas Petazzoni
1 sibling, 1 reply; 7+ messages in thread
From: Romain Naour @ 2015-02-27 20:50 UTC (permalink / raw)
To: buildroot
Hello Thomas, Peter,
Le 27/02/2015 16:01, Thomas Petazzoni a ?crit :
> Dear Peter Korsgaard,
>
> On Fri, 27 Feb 2015 15:44:06 +0100, Peter Korsgaard wrote:
>
>> That also looks ok. Did you try submitting it upstream?
>
> No, I was hoping for Romain to pick up on the task actually :-)
I thought that you would have submit your patch directly on the list.
Ok sorry, I'll pick up you patch and send it upstream.
Best regards,
Romain
>
> Thomas
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [git commit] libevent: fix openssl detection when statically linking
2015-02-27 20:50 ` Romain Naour
@ 2015-02-28 9:59 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2015-02-28 9:59 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Fri, 27 Feb 2015 21:50:47 +0100, Romain Naour wrote:
> > No, I was hoping for Romain to pick up on the task actually :-)
>
> I thought that you would have submit your patch directly on the list.
> Ok sorry, I'll pick up you patch and send it upstream.
Yes, maybe I was not explicit enough. Sorry about this.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-02-28 9:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27 7:54 [Buildroot] [git commit] libevent: fix openssl detection when statically linking Peter Korsgaard
2015-02-27 14:30 ` Thomas Petazzoni
2015-02-27 14:44 ` Peter Korsgaard
2015-02-27 15:01 ` Thomas Petazzoni
2015-02-27 15:15 ` Peter Korsgaard
2015-02-27 20:50 ` Romain Naour
2015-02-28 9:59 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.