From: Lee Jones <lee.jones@linaro.org> To: Peter Griffin <peter.griffin@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com, tj@kernel.org, linux-ide@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked. Date: Mon, 2 Mar 2015 17:03:38 +0000 [thread overview] Message-ID: <20150302170338.GC6976@x1> (raw) In-Reply-To: <1425300519-13747-4-git-send-email-peter.griffin@linaro.org> On Mon, 02 Mar 2015, Peter Griffin wrote: > Currently the ahci_st driver will hang the system on probe, as the > st_configure_oob function does some register writes before the IP > is clocked. This patch moves the function call to after > ahci_platform_enable_resources (which enables the IP clock), and > resolves the hang. > > Addtionally st_ahci_configure_oob should be called in the st_ahci_resume > function, so we also rectify that ensuring it is also called after > the IP clock has been enabled. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > drivers/ata/ahci_st.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) I suspect we might find a few issues like this now we're not using 'clk_ignore_unused'. Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c > index bc971af..ea0ff00 100644 > --- a/drivers/ata/ahci_st.c > +++ b/drivers/ata/ahci_st.c > @@ -68,8 +68,6 @@ static int st_ahci_deassert_resets(struct device *dev) > } > } > > - st_ahci_configure_oob(drv_data->hpriv->mmio); > - > if (drv_data->sw_rst) { > err = reset_control_deassert(drv_data->sw_rst); > if (err) { > @@ -172,6 +170,8 @@ static int st_ahci_probe(struct platform_device *pdev) > if (err) > return err; > > + st_ahci_configure_oob(drv_data->hpriv->mmio); > + > err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info, > &ahci_platform_sht); > if (err) { > @@ -222,6 +222,8 @@ static int st_ahci_resume(struct device *dev) > return err; > } > > + st_ahci_configure_oob(drv_data->hpriv->mmio); > + > return ahci_platform_resume_host(dev); > } > #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked. Date: Mon, 2 Mar 2015 17:03:38 +0000 [thread overview] Message-ID: <20150302170338.GC6976@x1> (raw) In-Reply-To: <1425300519-13747-4-git-send-email-peter.griffin@linaro.org> On Mon, 02 Mar 2015, Peter Griffin wrote: > Currently the ahci_st driver will hang the system on probe, as the > st_configure_oob function does some register writes before the IP > is clocked. This patch moves the function call to after > ahci_platform_enable_resources (which enables the IP clock), and > resolves the hang. > > Addtionally st_ahci_configure_oob should be called in the st_ahci_resume > function, so we also rectify that ensuring it is also called after > the IP clock has been enabled. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > drivers/ata/ahci_st.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) I suspect we might find a few issues like this now we're not using 'clk_ignore_unused'. Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c > index bc971af..ea0ff00 100644 > --- a/drivers/ata/ahci_st.c > +++ b/drivers/ata/ahci_st.c > @@ -68,8 +68,6 @@ static int st_ahci_deassert_resets(struct device *dev) > } > } > > - st_ahci_configure_oob(drv_data->hpriv->mmio); > - > if (drv_data->sw_rst) { > err = reset_control_deassert(drv_data->sw_rst); > if (err) { > @@ -172,6 +170,8 @@ static int st_ahci_probe(struct platform_device *pdev) > if (err) > return err; > > + st_ahci_configure_oob(drv_data->hpriv->mmio); > + > err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info, > &ahci_platform_sht); > if (err) { > @@ -222,6 +222,8 @@ static int st_ahci_resume(struct device *dev) > return err; > } > > + st_ahci_configure_oob(drv_data->hpriv->mmio); > + > return ahci_platform_resume_host(dev); > } > #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-03-02 17:03 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-02 12:48 [PATCH 0/3] Enable ahci_st for stih407 and fix hang Peter Griffin 2015-03-02 12:48 ` Peter Griffin 2015-03-02 12:48 ` [PATCH 1/3] ahci: st: Update the ahci_st DT documentation Peter Griffin 2015-03-02 12:48 ` Peter Griffin 2015-03-02 16:59 ` Lee Jones 2015-03-02 16:59 ` Lee Jones 2015-03-02 12:48 ` [PATCH 2/3] ARM: DT: STi: STiH407: Add sata DT nodes Peter Griffin 2015-03-02 12:48 ` Peter Griffin 2015-03-02 17:00 ` Lee Jones 2015-03-02 17:00 ` Lee Jones 2015-03-02 12:48 ` [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked Peter Griffin 2015-03-02 12:48 ` Peter Griffin 2015-03-02 17:03 ` Lee Jones [this message] 2015-03-02 17:03 ` Lee Jones 2015-03-03 12:23 ` [PATCH 0/3] Enable ahci_st for stih407 and fix hang Maxime Coquelin 2015-03-03 12:23 ` Maxime Coquelin 2015-03-03 12:23 ` Maxime Coquelin 2015-03-31 7:35 [PATCH RESEND " Peter Griffin 2015-03-31 7:35 ` [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked Peter Griffin 2015-03-31 7:35 ` Peter Griffin 2015-03-31 15:29 ` Tejun Heo 2015-03-31 15:29 ` Tejun Heo 2015-03-31 15:33 ` Maxime Coquelin 2015-03-31 15:33 ` Maxime Coquelin 2015-03-31 15:33 ` Maxime Coquelin [not found] ` <20150331152958.GF9974-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org> 2015-03-31 15:36 ` Peter Griffin 2015-03-31 15:36 ` Peter Griffin 2015-03-31 15:36 ` Peter Griffin 2015-03-31 15:59 ` Tejun Heo 2015-03-31 15:59 ` Tejun Heo 2015-03-31 17:33 ` Peter Griffin 2015-03-31 17:33 ` Peter Griffin [not found] ` <1427787309-1601-4-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-04-01 16:07 ` Tejun Heo 2015-04-01 16:07 ` Tejun Heo 2015-04-01 16:07 ` Tejun Heo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150302170338.GC6976@x1 \ --to=lee.jones@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.coquelin@st.com \ --cc=patrice.chotard@st.com \ --cc=peter.griffin@linaro.org \ --cc=srinivas.kandagatla@gmail.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.