* [PATCH md] recover_bitmaps() can be static
2015-02-27 23:04 [md:for-next 14/48] drivers/md/md-cluster.c:190:6: sparse: symbol 'recover_bitmaps' was not declared. Should it be static? kbuild test robot
@ 2015-02-27 23:04 ` kbuild test robot
2015-03-04 2:41 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-02-27 23:04 UTC (permalink / raw)
To: Goldwyn Rodrigues; +Cc: kbuild-all, Neil Brown, linux-raid, linux-kernel
drivers/md/md-cluster.c:190:6: sparse: symbol 'recover_bitmaps' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
md-cluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
index 1f82d0d..c71217a 100644
--- a/drivers/md/md-cluster.c
+++ b/drivers/md/md-cluster.c
@@ -187,7 +187,7 @@ out:
return s;
}
-void recover_bitmaps(struct md_thread *thread)
+static void recover_bitmaps(struct md_thread *thread)
{
struct mddev *mddev = thread->mddev;
struct md_cluster_info *cinfo = mddev->cluster_info;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [md:for-next 14/48] drivers/md/md-cluster.c:190:6: sparse: symbol 'recover_bitmaps' was not declared. Should it be static?
@ 2015-02-27 23:04 kbuild test robot
2015-02-27 23:04 ` [PATCH md] recover_bitmaps() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-02-27 23:04 UTC (permalink / raw)
To: Goldwyn Rodrigues; +Cc: kbuild-all, Neil Brown, linux-raid, linux-kernel
tree: git://neil.brown.name/md for-next
head: 5d98513a2e546337c0deb93d772eb0c988d47c1d
commit: e94987db2ed983aea4e45d22db9e17c6bbf2a623 [14/48] Initiate recovery on node failure
reproduce:
# apt-get install sparse
git checkout e94987db2ed983aea4e45d22db9e17c6bbf2a623
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/md/md-cluster.c:178:15: sparse: restricted __le64 degrades to integer
>> drivers/md/md-cluster.c:190:6: sparse: symbol 'recover_bitmaps' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH md] recover_bitmaps() can be static
2015-02-27 23:04 ` [PATCH md] recover_bitmaps() can be static kbuild test robot
@ 2015-03-04 2:41 ` NeilBrown
0 siblings, 0 replies; 3+ messages in thread
From: NeilBrown @ 2015-03-04 2:41 UTC (permalink / raw)
To: kbuild test robot; +Cc: Goldwyn Rodrigues, kbuild-all, linux-raid, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
On Sat, 28 Feb 2015 07:04:37 +0800 kbuild test robot <fengguang.wu@intel.com>
wrote:
> drivers/md/md-cluster.c:190:6: sparse: symbol 'recover_bitmaps' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> md-cluster.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
> index 1f82d0d..c71217a 100644
> --- a/drivers/md/md-cluster.c
> +++ b/drivers/md/md-cluster.c
> @@ -187,7 +187,7 @@ out:
> return s;
> }
>
> -void recover_bitmaps(struct md_thread *thread)
> +static void recover_bitmaps(struct md_thread *thread)
> {
> struct mddev *mddev = thread->mddev;
> struct md_cluster_info *cinfo = mddev->cluster_info;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied, thanks!
NeilBrown
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-04 2:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27 23:04 [md:for-next 14/48] drivers/md/md-cluster.c:190:6: sparse: symbol 'recover_bitmaps' was not declared. Should it be static? kbuild test robot
2015-02-27 23:04 ` [PATCH md] recover_bitmaps() can be static kbuild test robot
2015-03-04 2:41 ` NeilBrown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.