* [patch] ALSA: msnd: add some missing curly braces
@ 2015-03-05 11:26 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-05 11:26 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel, kernel-janitors
There were some curly braces intended here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/isa/msnd/msnd_pinnacle_mixer.c b/sound/isa/msnd/msnd_pinnacle_mixer.c
index 17e49a0..b408540 100644
--- a/sound/isa/msnd/msnd_pinnacle_mixer.c
+++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
@@ -306,11 +306,12 @@ int snd_msndmix_new(struct snd_card *card)
spin_lock_init(&chip->mixer_lock);
strcpy(card->mixername, "MSND Pinnacle Mixer");
- for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++)
+ for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++) {
err = snd_ctl_add(card,
snd_ctl_new1(snd_msnd_controls + idx, chip));
if (err < 0)
return err;
+ }
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] ALSA: msnd: add some missing curly braces
@ 2015-03-05 11:26 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-05 11:26 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel, kernel-janitors
There were some curly braces intended here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/isa/msnd/msnd_pinnacle_mixer.c b/sound/isa/msnd/msnd_pinnacle_mixer.c
index 17e49a0..b408540 100644
--- a/sound/isa/msnd/msnd_pinnacle_mixer.c
+++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
@@ -306,11 +306,12 @@ int snd_msndmix_new(struct snd_card *card)
spin_lock_init(&chip->mixer_lock);
strcpy(card->mixername, "MSND Pinnacle Mixer");
- for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++)
+ for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++) {
err = snd_ctl_add(card,
snd_ctl_new1(snd_msnd_controls + idx, chip));
if (err < 0)
return err;
+ }
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] ALSA: msnd: add some missing curly braces
2015-03-05 11:26 ` Dan Carpenter
@ 2015-03-05 12:02 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2015-03-05 12:02 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jaroslav Kysela, alsa-devel, kernel-janitors
At Thu, 5 Mar 2015 14:26:37 +0300,
Dan Carpenter wrote:
>
> There were some curly braces intended here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
>
> diff --git a/sound/isa/msnd/msnd_pinnacle_mixer.c b/sound/isa/msnd/msnd_pinnacle_mixer.c
> index 17e49a0..b408540 100644
> --- a/sound/isa/msnd/msnd_pinnacle_mixer.c
> +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
> @@ -306,11 +306,12 @@ int snd_msndmix_new(struct snd_card *card)
> spin_lock_init(&chip->mixer_lock);
> strcpy(card->mixername, "MSND Pinnacle Mixer");
>
> - for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++)
> + for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++) {
> err = snd_ctl_add(card,
> snd_ctl_new1(snd_msnd_controls + idx, chip));
> if (err < 0)
> return err;
> + }
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] ALSA: msnd: add some missing curly braces
@ 2015-03-05 12:02 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2015-03-05 12:02 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jaroslav Kysela, alsa-devel, kernel-janitors
At Thu, 5 Mar 2015 14:26:37 +0300,
Dan Carpenter wrote:
>
> There were some curly braces intended here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
Takashi
>
> diff --git a/sound/isa/msnd/msnd_pinnacle_mixer.c b/sound/isa/msnd/msnd_pinnacle_mixer.c
> index 17e49a0..b408540 100644
> --- a/sound/isa/msnd/msnd_pinnacle_mixer.c
> +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
> @@ -306,11 +306,12 @@ int snd_msndmix_new(struct snd_card *card)
> spin_lock_init(&chip->mixer_lock);
> strcpy(card->mixername, "MSND Pinnacle Mixer");
>
> - for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++)
> + for (idx = 0; idx < ARRAY_SIZE(snd_msnd_controls); idx++) {
> err = snd_ctl_add(card,
> snd_ctl_new1(snd_msnd_controls + idx, chip));
> if (err < 0)
> return err;
> + }
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-05 12:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 11:26 [patch] ALSA: msnd: add some missing curly braces Dan Carpenter
2015-03-05 11:26 ` Dan Carpenter
2015-03-05 12:02 ` Takashi Iwai
2015-03-05 12:02 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.