All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Lino Sanfilippo <lsanfil@marvell.com>
Cc: LinoSanfilippo@gmx.de, linux@arm.linux.org.uk,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 0/1] Wrong structure alignment due to compiler attribute "section"
Date: Thu, 5 Mar 2015 13:47:33 +0000	[thread overview]
Message-ID: <20150305134733.GE3612@e103592.cambridge.arm.com> (raw)
In-Reply-To: <54F8582B.80703@marvell.com>

On Thu, Mar 05, 2015 at 02:20:43PM +0100, Lino Sanfilippo wrote:
> On 05.03.2015 13:26, Dave Martin wrote:
> 
> >>
> >>So this is indeed a compiler bug, right?
> >
> >It certainly looks like the compiler is causing the issue somehow.
> >
> >Whether this is a bug, a bug-like feature, a configuration issue,
> >or a combination of these is not clear.
> >
> >If you know where to find the toolchain source, it might be worth
> >taking a look.
> 
> The toolchain can be found here:
> http://www.plugcomputer.org/405/us/gplugd/tool-chain/arm-marvell-linux-gnueabi.tar.bz2

Source code?  That just looks like binaries to me.

> But since it turns out to be a compiler issue I dont know if its
> worth to be investigated further. I think the best solution to avoid
> that structure alignment problem is to simply use another toolchain.

Maybe not.  Could be worth revisiting if other people report the
same problem -- a build-time check that 

> Dave, I thank you very much for your help and efforts to clarify
> that this is actually not a bug in the kernel.

No probs.  I have wondered whether it's really valid to assume
that the linker can paste sections from different objects into a valid
array like this.

There are other things that already work this way though -- such
as the way .init_array/.fini_array are created when building
a shared library.

Cheers
---Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/1] Wrong structure alignment due to compiler attribute "section"
Date: Thu, 5 Mar 2015 13:47:33 +0000	[thread overview]
Message-ID: <20150305134733.GE3612@e103592.cambridge.arm.com> (raw)
In-Reply-To: <54F8582B.80703@marvell.com>

On Thu, Mar 05, 2015 at 02:20:43PM +0100, Lino Sanfilippo wrote:
> On 05.03.2015 13:26, Dave Martin wrote:
> 
> >>
> >>So this is indeed a compiler bug, right?
> >
> >It certainly looks like the compiler is causing the issue somehow.
> >
> >Whether this is a bug, a bug-like feature, a configuration issue,
> >or a combination of these is not clear.
> >
> >If you know where to find the toolchain source, it might be worth
> >taking a look.
> 
> The toolchain can be found here:
> http://www.plugcomputer.org/405/us/gplugd/tool-chain/arm-marvell-linux-gnueabi.tar.bz2

Source code?  That just looks like binaries to me.

> But since it turns out to be a compiler issue I dont know if its
> worth to be investigated further. I think the best solution to avoid
> that structure alignment problem is to simply use another toolchain.

Maybe not.  Could be worth revisiting if other people report the
same problem -- a build-time check that 

> Dave, I thank you very much for your help and efforts to clarify
> that this is actually not a bug in the kernel.

No probs.  I have wondered whether it's really valid to assume
that the linker can paste sections from different objects into a valid
array like this.

There are other things that already work this way though -- such
as the way .init_array/.fini_array are created when building
a shared library.

Cheers
---Dave

  reply	other threads:[~2015-03-05 13:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 10:01 [RFC PATCH 0/1] Wrong structure alignment due to compiler attribute "section" Lino Sanfilippo
2015-03-02 10:01 ` Lino Sanfilippo
2015-03-02 10:01 ` [RFC PATCH 1/1] ARM: Ensure correct structure alignment when using " Lino Sanfilippo
2015-03-02 10:01   ` Lino Sanfilippo
2015-03-03 14:41 ` [RFC PATCH 0/1] Wrong structure alignment due to " Dave Martin
2015-03-03 14:41   ` Dave Martin
2015-03-04 11:40   ` sanfilippo
2015-03-04 11:40     ` sanfilippo
2015-03-04 14:35     ` Dave Martin
2015-03-04 14:35       ` Dave Martin
2015-03-04 16:29       ` Lino Sanfilippo
2015-03-04 16:29         ` Lino Sanfilippo
2015-03-05 12:26         ` Dave Martin
2015-03-05 12:26           ` Dave Martin
2015-03-05 13:20           ` Lino Sanfilippo
2015-03-05 13:20             ` Lino Sanfilippo
2015-03-05 13:47             ` Dave Martin [this message]
2015-03-05 13:47               ` Dave Martin
2015-03-05 15:32               ` Lino Sanfilippo
2015-03-05 15:32                 ` Lino Sanfilippo
2015-03-05 17:33                 ` Dave Martin
2015-03-05 17:33                   ` Dave Martin
2015-03-06 14:02                   ` Lino Sanfilippo
2015-03-06 14:02                     ` Lino Sanfilippo
2015-03-06 18:20                     ` Lino Sanfilippo
2015-03-06 18:20                       ` Lino Sanfilippo
2015-03-22  0:56                       ` Lino Sanfilippo
2015-03-22  0:56                         ` Lino Sanfilippo
2015-03-24 12:07                         ` Dave Martin
2015-03-24 12:07                           ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150305134733.GE3612@e103592.cambridge.arm.com \
    --to=dave.martin@arm.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lsanfil@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.