All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function
Date: Mon, 9 Mar 2015 18:25:03 +0530	[thread overview]
Message-ID: <20150309125503.GB11724@sudip-PC> (raw)
In-Reply-To: <20150309124222.GE10964@mwanda>

On Mon, Mar 09, 2015 at 03:42:22PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote:
> > kbuild test robot reported that for microblaze-allyesconfig
> > chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> > functions were defined under CONFIG_PM, so for any archtecture if
> > CONFIG_PM is not defined we will have this error.
> > 
> > while moving the lynxfb_suspend() function some very obvious
> > checkpatch errors, like space after comma, space after if, space
> > before opening brace, were taken care of.
> 
> I have a script to review patches moving functions around but these
> white space changes break my script so I have to review it by hand.
> Sucks.

oops . sorry ..
> 
> >  static int lynxfb_ops_set_par(struct fb_info * info)
<snip>
> >  static inline unsigned int chan_to_field(unsigned int chan,struct fb_bitfield * bf)
> >  {
> >  	chan &= 0xffff;
> 
> These white space changes are not related.
if you want i can break it into multiple patches, so that reviewing can be easy and your script will not break :) .
Actually I thought, since this is a vendor crude driver there will be many such changes, so if i can combine some changes together then atleast the number of patches can be kept low and also i thought of clubbing these changes together as Joe Perches once told me "Don't get carried away with patch type separation" (reference: https://lkml.org/lkml/2015/1/1/2).

regards
sudip

> 
> regards,
> dan carpenter
> 

WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function
Date: Mon, 09 Mar 2015 12:55:13 +0000	[thread overview]
Message-ID: <20150309125503.GB11724@sudip-PC> (raw)
In-Reply-To: <20150309124222.GE10964@mwanda>

On Mon, Mar 09, 2015 at 03:42:22PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote:
> > kbuild test robot reported that for microblaze-allyesconfig
> > chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> > functions were defined under CONFIG_PM, so for any archtecture if
> > CONFIG_PM is not defined we will have this error.
> > 
> > while moving the lynxfb_suspend() function some very obvious
> > checkpatch errors, like space after comma, space after if, space
> > before opening brace, were taken care of.
> 
> I have a script to review patches moving functions around but these
> white space changes break my script so I have to review it by hand.
> Sucks.

oops . sorry ..
> 
> >  static int lynxfb_ops_set_par(struct fb_info * info)
<snip>
> >  static inline unsigned int chan_to_field(unsigned int chan,struct fb_bitfield * bf)
> >  {
> >  	chan &= 0xffff;
> 
> These white space changes are not related.
if you want i can break it into multiple patches, so that reviewing can be easy and your script will not break :) .
Actually I thought, since this is a vendor crude driver there will be many such changes, so if i can combine some changes together then atleast the number of patches can be kept low and also i thought of clubbing these changes together as Joe Perches once told me "Don't get carried away with patch type separation" (reference: https://lkml.org/lkml/2015/1/1/2).

regards
sudip

> 
> regards,
> dan carpenter
> 

  reply	other threads:[~2015-03-09 12:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09  7:35 [PATCH v2 1/4] staging: sm750fb: wrong type for print Sudip Mukherjee
2015-03-09  7:47 ` Sudip Mukherjee
2015-03-09  7:35 ` [PATCH v2 2/4] staging: sm750fb: remove pragma optimize Sudip Mukherjee
2015-03-09  7:47   ` Sudip Mukherjee
2015-03-09  7:35 ` [PATCH v2 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Sudip Mukherjee
2015-03-09  7:47   ` Sudip Mukherjee
2015-03-09  7:47   ` Lad, Prabhakar
2015-03-09  7:47     ` Lad, Prabhakar
2015-03-09  8:41     ` Sudip Mukherjee
2015-03-09  8:53       ` Sudip Mukherjee
2015-03-09  7:35 ` [PATCH v2 4/4] staging: sm750fb: fix undeclared function Sudip Mukherjee
2015-03-09  7:47   ` Sudip Mukherjee
2015-03-09 12:42   ` Dan Carpenter
2015-03-09 12:42     ` Dan Carpenter
2015-03-09 12:55     ` Sudip Mukherjee [this message]
2015-03-09 12:55       ` Sudip Mukherjee
2015-03-09 13:29       ` Dan Carpenter
2015-03-09 13:29         ` Dan Carpenter
2015-03-09  7:42 ` [PATCH v2 1/4] staging: sm750fb: wrong type for print Lad, Prabhakar
2015-03-09  7:42   ` Lad, Prabhakar
2015-03-09  8:30   ` Sudip Mukherjee
2015-03-09  8:42     ` Sudip Mukherjee
2015-03-09 11:53 ` Dan Carpenter
2015-03-09 11:53   ` Dan Carpenter
2015-03-09 12:11   ` Sudip Mukherjee
2015-03-09 12:23     ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309125503.GB11724@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.