From: Andy Gospodarek <gospo@cumulusnetworks.com>
To: sfeldma@gmail.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org, jiri@resnulli.us
Subject: Re: [PATCH iproute2] route: label externally offloaded routes
Date: Mon, 9 Mar 2015 10:02:41 -0400 [thread overview]
Message-ID: <20150309140241.GI502@gospo.home.greyhouse.net> (raw)
In-Reply-To: <1425795335-6416-1-git-send-email-sfeldma@gmail.com>
On Sat, Mar 07, 2015 at 10:15:35PM -0800, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
>
> On ip route print dump, label externally offloaded routes with "external".
> Offloaded routes are flagged with RTNH_F_EXTERNAL, a recent additon to
> net-next. For example:
>
> $ ip route
> default via 192.168.0.2 dev eth0
> 11.0.0.0/30 dev swp1 proto kernel scope link src 11.0.0.2 external
> 11.0.0.4/30 via 11.0.0.1 dev swp1 proto zebra metric 20 external
> 11.0.0.8/30 dev swp2 proto kernel scope link src 11.0.0.10 external
> 11.0.0.12/30 via 11.0.0.9 dev swp2 proto zebra metric 20 external
> 12.0.0.2 proto zebra metric 30 external
> nexthop via 11.0.0.1 dev swp1 weight 1
> nexthop via 11.0.0.9 dev swp2 weight 1
> 12.0.0.3 via 11.0.0.1 dev swp1 proto zebra metric 20 external
> 12.0.0.4 via 11.0.0.9 dev swp2 proto zebra metric 20 external
> 192.168.0.0/24 dev eth0 proto kernel scope link src 192.168.0.15
>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
You know we cannot have a thread about nomenclature without a comment
from me. ;)
My only concern about 'external' is whether or not people will gloss
over it since many of the routes listed will be to networks that
actually are external to the system. That namespace collision could
seem awkward if you are not a traditional follower of this list.
Listing an FDB entry as 'external' does not have the same issue since
all FDB entries are local to the system, so I didn't even
think about the potential when that set was posted.
I would like to just call this 'hardware' since that is what we appear
to be using for offload and would make it clear to the user that this
route was in hardware as well as in the kernel. I'd say the same for
FDB entries, too.
Scott, you have lots of experience in both traditional and Linux worlds,
do you think my concern about confusion is unnecessary?
> ---
> include/linux/rtnetlink.h | 1 +
> ip/iproute.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h
> index 3eb7810..c74773c 100644
> --- a/include/linux/rtnetlink.h
> +++ b/include/linux/rtnetlink.h
> @@ -332,6 +332,7 @@ struct rtnexthop {
> #define RTNH_F_DEAD 1 /* Nexthop is dead (used by multipath) */
> #define RTNH_F_PERVASIVE 2 /* Do recursive gateway lookup */
> #define RTNH_F_ONLINK 4 /* Gateway is forced on link */
> +#define RTNH_F_EXTERNAL 8 /* Route installed externally */
>
> /* Macros to handle hexthops */
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 76d8e36..fdb0a98 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -426,6 +426,8 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
> fprintf(fp, "onlink ");
> if (r->rtm_flags & RTNH_F_PERVASIVE)
> fprintf(fp, "pervasive ");
> + if (r->rtm_flags & RTNH_F_EXTERNAL)
> + fprintf(fp, "external ");
> if (r->rtm_flags & RTM_F_NOTIFY)
> fprintf(fp, "notify ");
> if (tb[RTA_MARK]) {
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-09 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 6:15 [PATCH iproute2] route: label externally offloaded routes sfeldma
2015-03-08 6:57 ` Jiri Pirko
[not found] ` <CAJieiUgz9O7LFhzONx5JKRv0o4+6hSHNtRgKaaKAn2ph4jdC2g@mail.gmail.com>
2015-03-08 22:10 ` Scott Feldman
2015-03-09 0:27 ` roopa
2015-03-09 6:25 ` Jiri Pirko
2015-03-08 14:14 ` roopa
2015-03-09 14:02 ` Andy Gospodarek [this message]
2015-03-09 16:16 ` Scott Feldman
2015-03-09 16:51 ` Jeff Kirsher
2015-03-09 17:53 ` John W. Linville
2015-03-15 19:39 ` Stephen Hemminger
2015-03-15 20:08 ` Scott Feldman
2015-03-15 19:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309140241.GI502@gospo.home.greyhouse.net \
--to=gospo@cumulusnetworks.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.