From: Scott Feldman <sfeldma@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] route: label externally offloaded routes
Date: Sun, 8 Mar 2015 15:10:48 -0700 [thread overview]
Message-ID: <CAE4R7bBKeWoDEv5SJfpm96d330Dc9ZpZpWVG-Dd45uH1mF64aA@mail.gmail.com> (raw)
In-Reply-To: <CAJieiUgz9O7LFhzONx5JKRv0o4+6hSHNtRgKaaKAn2ph4jdC2g@mail.gmail.com>
On Sun, Mar 8, 2015 at 6:35 AM, Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
>
>
> On Sat, Mar 7, 2015 at 10:57 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Sun, Mar 08, 2015 at 07:15:35AM CET, sfeldma@gmail.com wrote:
>> >From: Scott Feldman <sfeldma@gmail.com>
>> >
>> >On ip route print dump, label externally offloaded routes with
>> > "external".
>> >Offloaded routes are flagged with RTNH_F_EXTERNAL, a recent additon to
>> >net-next. For example:
>> >
>> >$ ip route
>> >default via 192.168.0.2 dev eth0
>> >11.0.0.0/30 dev swp1 proto kernel scope link src 11.0.0.2 external
>> >11.0.0.4/30 via 11.0.0.1 dev swp1 proto zebra metric 20 external
>> >11.0.0.8/30 dev swp2 proto kernel scope link src 11.0.0.10 external
>> >11.0.0.12/30 via 11.0.0.9 dev swp2 proto zebra metric 20 external
>> >12.0.0.2 proto zebra metric 30 external
>> > nexthop via 11.0.0.1 dev swp1 weight 1
>> > nexthop via 11.0.0.9 dev swp2 weight 1
>> >12.0.0.3 via 11.0.0.1 dev swp1 proto zebra metric 20 external
>> >12.0.0.4 via 11.0.0.9 dev swp2 proto zebra metric 20 external
>> >192.168.0.0/24 dev eth0 proto kernel scope link src 192.168.0.15
>> >
>> >Signed-off-by: Scott Feldman <sfeldma@gmail.com>
>>
> No objections to the patch.
>
> since this is now getting exposed to userspace and there were suggestions in
> the past to use words like 'hw' or 'offload' in place of 'external' here,
> checking to see if you are taking suggestions. If yes, would 'hw' or
> 'offloaded' be a better name for the flag ?.
We used "external" because that's what was used for marking FDB
entries. I personally have no preference other than we be consistent
for each object offloaded externally. There will be other objects
we'll need to tag, such as bonds, so if there is enough objection to
"external", we should make the change now for FIB abd FDB objects, and
be consistent with future objects.
-scott
next prev parent reply other threads:[~2015-03-08 22:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 6:15 [PATCH iproute2] route: label externally offloaded routes sfeldma
2015-03-08 6:57 ` Jiri Pirko
[not found] ` <CAJieiUgz9O7LFhzONx5JKRv0o4+6hSHNtRgKaaKAn2ph4jdC2g@mail.gmail.com>
2015-03-08 22:10 ` Scott Feldman [this message]
2015-03-09 0:27 ` roopa
2015-03-09 6:25 ` Jiri Pirko
2015-03-08 14:14 ` roopa
2015-03-09 14:02 ` Andy Gospodarek
2015-03-09 16:16 ` Scott Feldman
2015-03-09 16:51 ` Jeff Kirsher
2015-03-09 17:53 ` John W. Linville
2015-03-15 19:39 ` Stephen Hemminger
2015-03-15 20:08 ` Scott Feldman
2015-03-15 19:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE4R7bBKeWoDEv5SJfpm96d330Dc9ZpZpWVG-Dd45uH1mF64aA@mail.gmail.com \
--to=sfeldma@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.