* [PATCH] Staging: rtl8192e: Remove unnecessary macro
@ 2015-03-09 20:48 Cristina Opriceana
2015-03-09 21:20 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Cristina Opriceana @ 2015-03-09 20:48 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the RTLLIB_PRINT_STR macro definition because it is
olny defined in the header and it is never referenced.
Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
---
drivers/staging/rtl8192e/rtllib.h | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index cef2dc2..96e9246 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -784,26 +784,6 @@ do { \
#define RTLLIB_DEBUG_RX(f, a...) RTLLIB_DEBUG(RTLLIB_DL_RX, f, ## a)
#define RTLLIB_DEBUG_QOS(f, a...) RTLLIB_DEBUG(RTLLIB_DL_QOS, f, ## a)
-/* Added by Annie, 2005-11-22. */
-#define MAX_STR_LEN 64
-/* I want to see ASCII 33 to 126 only. Otherwise, I print '?'. */
-#define PRINTABLE(_ch) (_ch > '!' && _ch < '~')
-#define RTLLIB_PRINT_STR(_Comp, _TitleString, _Ptr, _Len) \
- if ((_Comp) & level) { \
- int __i; \
- u8 struct buffer[MAX_STR_LEN]; \
- int length = (_Len < MAX_STR_LEN) ? _Len : (MAX_STR_LEN-1) ;\
- memset(struct buffer, 0, MAX_STR_LEN); \
- memcpy(struct buffer, (u8 *)_Ptr, length); \
- for (__i = 0; __i < MAX_STR_LEN; __i++) { \
- if (!PRINTABLE(struct buffer[__i])) \
- struct buffer[__i] = '?'; \
- } \
- struct buffer[length] = '\0'; \
- printk(KERN_INFO "Rtl819x: "); \
- printk(_TitleString); \
- printk(": %d, <%s>\n", _Len, struct buffer); \
- }
#ifndef ETH_P_PAE
#define ETH_P_PAE 0x888E /* Port Access Entity (IEEE 802.1X) */
#define ETH_P_IP 0x0800 /* Internet Protocol packet */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192e: Remove unnecessary macro
2015-03-09 20:48 [PATCH] Staging: rtl8192e: Remove unnecessary macro Cristina Opriceana
@ 2015-03-09 21:20 ` Julia Lawall
2015-03-09 23:28 ` Cristina Opriceana
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2015-03-09 21:20 UTC (permalink / raw)
To: Cristina Opriceana; +Cc: outreachy-kernel
On Mon, 9 Mar 2015, Cristina Opriceana wrote:
> This patch removes the RTLLIB_PRINT_STR macro definition because it is
> olny defined in the header and it is never referenced.
Small spelling mistake. Also, the patch also removes several other
macros, so you may want to mention all of them.
julia
>
> Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib.h | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index cef2dc2..96e9246 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -784,26 +784,6 @@ do { \
> #define RTLLIB_DEBUG_RX(f, a...) RTLLIB_DEBUG(RTLLIB_DL_RX, f, ## a)
> #define RTLLIB_DEBUG_QOS(f, a...) RTLLIB_DEBUG(RTLLIB_DL_QOS, f, ## a)
>
> -/* Added by Annie, 2005-11-22. */
> -#define MAX_STR_LEN 64
> -/* I want to see ASCII 33 to 126 only. Otherwise, I print '?'. */
> -#define PRINTABLE(_ch) (_ch > '!' && _ch < '~')
> -#define RTLLIB_PRINT_STR(_Comp, _TitleString, _Ptr, _Len) \
> - if ((_Comp) & level) { \
> - int __i; \
> - u8 struct buffer[MAX_STR_LEN]; \
> - int length = (_Len < MAX_STR_LEN) ? _Len : (MAX_STR_LEN-1) ;\
> - memset(struct buffer, 0, MAX_STR_LEN); \
> - memcpy(struct buffer, (u8 *)_Ptr, length); \
> - for (__i = 0; __i < MAX_STR_LEN; __i++) { \
> - if (!PRINTABLE(struct buffer[__i])) \
> - struct buffer[__i] = '?'; \
> - } \
> - struct buffer[length] = '\0'; \
> - printk(KERN_INFO "Rtl819x: "); \
> - printk(_TitleString); \
> - printk(": %d, <%s>\n", _Len, struct buffer); \
> - }
> #ifndef ETH_P_PAE
> #define ETH_P_PAE 0x888E /* Port Access Entity (IEEE 802.1X) */
> #define ETH_P_IP 0x0800 /* Internet Protocol packet */
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150309204828.GA25299%40Inspiron.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192e: Remove unnecessary macro
2015-03-09 21:20 ` [Outreachy kernel] " Julia Lawall
@ 2015-03-09 23:28 ` Cristina Opriceana
0 siblings, 0 replies; 3+ messages in thread
From: Cristina Opriceana @ 2015-03-09 23:28 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
> Small spelling mistake. Also, the patch also removes several other
> macros, so you may want to mention all of them.
Oh, I swapped some letters.
Thanks for reviewing.
Cristina
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-09 23:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-09 20:48 [PATCH] Staging: rtl8192e: Remove unnecessary macro Cristina Opriceana
2015-03-09 21:20 ` [Outreachy kernel] " Julia Lawall
2015-03-09 23:28 ` Cristina Opriceana
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.