[PATCH] staging: octeon-usb: Made octeon_usb_match const

[PATCH] staging: octeon-usb: Made octeon_usb_match const

[Mateusz Kulikowski]

An of_device_id should be const (checkpatch.pl warning).

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
 drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 1daeb31..9591232 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -3885,7 +3885,7 @@ static int octeon_usb_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct of_device_id octeon_usb_match[] = {
+static const struct of_device_id octeon_usb_match[] = {
 	{
 		.compatible = "cavium,octeon-5750-usbc",
 	},
-- 
1.8.4.1

Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const

[Aaro Koskinen]

Hi,

On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>

Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>

A.

Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const

[Greg KH]

On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..9591232 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -3885,7 +3885,7 @@ static int octeon_usb_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct of_device_id octeon_usb_match[] = {
> +static const struct of_device_id octeon_usb_match[] = {
>  	{
>  		.compatible = "cavium,octeon-5750-usbc",
>  	},

Sorry, someone else sent this patch, and I saw their patch first before
yours, and applied it, which was my fault :(

greg k-h

Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const

[Mateusz Kulikowski]

On 24.03.2015 05:31, Greg KH wrote:
> On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
(...)
> Sorry, someone else sent this patch, and I saw their patch first before
> yours, and applied it, which was my fault :(

No problem, it was tiny patch, easy to miss.

I'll focus on rtl8192e anyway - I should have hardware soon so bigger 
refactorings will be possible.

Mateusz

p.s. Sorry for html garbage in previous mail - shame on me and Android 
email client :)