* Re: [patch net-next] switchdev: select INET in Kconfig
@ 2015-03-11 15:36 Alexei Starovoitov
2015-03-11 16:20 ` Jiri Pirko
2015-03-11 18:14 ` David Miller
0 siblings, 2 replies; 7+ messages in thread
From: Alexei Starovoitov @ 2015-03-11 15:36 UTC (permalink / raw)
To: Jiri Pirko
Cc: netdev, David S. Miller, Florian Fainelli, Scott Feldman, Randy Dunlap
On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> This would fix randconfig compile error:
> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
> (.text+0xf7811): undefined reference to `fib_flush_external'
>
> Also it fixes following warning:
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>
> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
> net/switchdev/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
> index 86a47e1..3487940 100644
> --- a/net/switchdev/Kconfig
> +++ b/net/switchdev/Kconfig
> @@ -4,7 +4,7 @@
>
> config NET_SWITCHDEV
> bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
> - depends on INET
> + select INET
I believe Dave mentioned few times that 'select' is highly
discouraged, since it doesn't work recursively.
In this case only crazy config KVMTOOL_TEST_ENABLE
is doing 'select INET' everything else in a tree is using
'depends on INET'.
Doing 'select NET_SWITCHDEV' was wrong in the first place.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch net-next] switchdev: select INET in Kconfig
2015-03-11 15:36 [patch net-next] switchdev: select INET in Kconfig Alexei Starovoitov
@ 2015-03-11 16:20 ` Jiri Pirko
2015-03-11 18:14 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: Jiri Pirko @ 2015-03-11 16:20 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: netdev, David S. Miller, Florian Fainelli, Scott Feldman, Randy Dunlap
Wed, Mar 11, 2015 at 04:36:16PM CET, alexei.starovoitov@gmail.com wrote:
>On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> This would fix randconfig compile error:
>> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
>> (.text+0xf7811): undefined reference to `fib_flush_external'
>>
>> Also it fixes following warning:
>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>>
>> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>> ---
>> net/switchdev/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
>> index 86a47e1..3487940 100644
>> --- a/net/switchdev/Kconfig
>> +++ b/net/switchdev/Kconfig
>> @@ -4,7 +4,7 @@
>>
>> config NET_SWITCHDEV
>> bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
>> - depends on INET
>> + select INET
>
>I believe Dave mentioned few times that 'select' is highly
>discouraged, since it doesn't work recursively.
>In this case only crazy config KVMTOOL_TEST_ENABLE
>is doing 'select INET' everything else in a tree is using
>'depends on INET'.
>Doing 'select NET_SWITCHDEV' was wrong in the first place.
Ok, so you suggest just to change this to "depends on NET_SWITCHDEV" in
DSA and we are good?
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch net-next] switchdev: select INET in Kconfig
2015-03-11 15:36 [patch net-next] switchdev: select INET in Kconfig Alexei Starovoitov
2015-03-11 16:20 ` Jiri Pirko
@ 2015-03-11 18:14 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: David Miller @ 2015-03-11 18:14 UTC (permalink / raw)
To: alexei.starovoitov; +Cc: jiri, netdev, f.fainelli, sfeldma, rdunlap
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Wed, 11 Mar 2015 08:36:16 -0700
> On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> This would fix randconfig compile error:
>> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
>> (.text+0xf7811): undefined reference to `fib_flush_external'
>>
>> Also it fixes following warning:
>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>>
>> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>> ---
>> net/switchdev/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
>> index 86a47e1..3487940 100644
>> --- a/net/switchdev/Kconfig
>> +++ b/net/switchdev/Kconfig
>> @@ -4,7 +4,7 @@
>>
>> config NET_SWITCHDEV
>> bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
>> - depends on INET
>> + select INET
>
> I believe Dave mentioned few times that 'select' is highly
> discouraged, since it doesn't work recursively.
Yes, the problem is that INET is not a leaf node. It selects
CRYPTO stuff.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch net-next] switchdev: select INET in Kconfig
2015-03-11 9:49 Jiri Pirko
@ 2015-03-11 22:00 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2015-03-11 22:00 UTC (permalink / raw)
To: jiri; +Cc: netdev, f.fainelli, sfeldma, rdunlap
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 11 Mar 2015 10:49:12 +0100
> This would fix randconfig compile error:
> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
> (.text+0xf7811): undefined reference to `fib_flush_external'
>
> Also it fixes following warning:
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>
> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
You cannot use select with INET, it selects CRYPTO* stuff and
therefore is not a leaf Kconfig node.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch net-next] switchdev: select INET in Kconfig
2015-03-11 16:26 Alexei Starovoitov
@ 2015-03-11 16:34 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2015-03-11 16:34 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: Jiri Pirko, netdev, David S. Miller, Scott Feldman, Randy Dunlap
2015-03-11 9:26 GMT-07:00 Alexei Starovoitov <alexei.starovoitov@gmail.com>:
> On Wed, Mar 11, 2015 at 9:20 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Wed, Mar 11, 2015 at 04:36:16PM CET, alexei.starovoitov@gmail.com wrote:
>>>On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>>> This would fix randconfig compile error:
>>>> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
>>>> (.text+0xf7811): undefined reference to `fib_flush_external'
>>>>
>>>> Also it fixes following warning:
>>>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>>>>
>>>> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
>>>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>>>> ---
>>>> net/switchdev/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
>>>> index 86a47e1..3487940 100644
>>>> --- a/net/switchdev/Kconfig
>>>> +++ b/net/switchdev/Kconfig
>>>> @@ -4,7 +4,7 @@
>>>>
>>>> config NET_SWITCHDEV
>>>> bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
>>>> - depends on INET
>>>> + select INET
>>>
>>>I believe Dave mentioned few times that 'select' is highly
>>>discouraged, since it doesn't work recursively.
>>>In this case only crazy config KVMTOOL_TEST_ENABLE
>>>is doing 'select INET' everything else in a tree is using
>>>'depends on INET'.
>>>Doing 'select NET_SWITCHDEV' was wrong in the first place.
>>
>> Ok, so you suggest just to change this to "depends on NET_SWITCHDEV" in
>> DSA and we are good?
>
> yes. that should work.
> Probably combining that line with 'depends on HAVE_NET_DSA' line
Works for me as well, thanks Jiri for looking into that.
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch net-next] switchdev: select INET in Kconfig
@ 2015-03-11 16:26 Alexei Starovoitov
2015-03-11 16:34 ` Florian Fainelli
0 siblings, 1 reply; 7+ messages in thread
From: Alexei Starovoitov @ 2015-03-11 16:26 UTC (permalink / raw)
To: Jiri Pirko
Cc: netdev, David S. Miller, Florian Fainelli, Scott Feldman, Randy Dunlap
On Wed, Mar 11, 2015 at 9:20 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> Wed, Mar 11, 2015 at 04:36:16PM CET, alexei.starovoitov@gmail.com wrote:
>>On Wed, Mar 11, 2015 at 2:49 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>> This would fix randconfig compile error:
>>> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
>>> (.text+0xf7811): undefined reference to `fib_flush_external'
>>>
>>> Also it fixes following warning:
>>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>>>
>>> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
>>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>>> ---
>>> net/switchdev/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
>>> index 86a47e1..3487940 100644
>>> --- a/net/switchdev/Kconfig
>>> +++ b/net/switchdev/Kconfig
>>> @@ -4,7 +4,7 @@
>>>
>>> config NET_SWITCHDEV
>>> bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
>>> - depends on INET
>>> + select INET
>>
>>I believe Dave mentioned few times that 'select' is highly
>>discouraged, since it doesn't work recursively.
>>In this case only crazy config KVMTOOL_TEST_ENABLE
>>is doing 'select INET' everything else in a tree is using
>>'depends on INET'.
>>Doing 'select NET_SWITCHDEV' was wrong in the first place.
>
> Ok, so you suggest just to change this to "depends on NET_SWITCHDEV" in
> DSA and we are good?
yes. that should work.
Probably combining that line with 'depends on HAVE_NET_DSA' line
^ permalink raw reply [flat|nested] 7+ messages in thread
* [patch net-next] switchdev: select INET in Kconfig
@ 2015-03-11 9:49 Jiri Pirko
2015-03-11 22:00 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Jiri Pirko @ 2015-03-11 9:49 UTC (permalink / raw)
To: netdev; +Cc: davem, f.fainelli, sfeldma, rdunlap
This would fix randconfig compile error:
net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
(.text+0xf7811): undefined reference to `fib_flush_external'
Also it fixes following warning:
warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
Suggested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
net/switchdev/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/switchdev/Kconfig b/net/switchdev/Kconfig
index 86a47e1..3487940 100644
--- a/net/switchdev/Kconfig
+++ b/net/switchdev/Kconfig
@@ -4,7 +4,7 @@
config NET_SWITCHDEV
bool "Switch (and switch-ish) device support (EXPERIMENTAL)"
- depends on INET
+ select INET
---help---
This module provides glue between core networking code and device
drivers in order to support hardware switch chips in very generic
--
1.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-11 22:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-11 15:36 [patch net-next] switchdev: select INET in Kconfig Alexei Starovoitov
2015-03-11 16:20 ` Jiri Pirko
2015-03-11 18:14 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-03-11 16:26 Alexei Starovoitov
2015-03-11 16:34 ` Florian Fainelli
2015-03-11 9:49 Jiri Pirko
2015-03-11 22:00 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.