All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH asoc] ASoC: max98925_spk_tlv can be static
  2015-03-11 19:05 [asoc:topic/max98925 1/1] sound/soc/codecs/max98925.c:189:1: sparse: symbol 'max98925_spk_tlv' was not declared. Should it be static? kbuild test robot
@ 2015-03-11 19:05 ` kbuild test robot
  2015-03-11 19:13   ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-11 19:05 UTC (permalink / raw)
  To: Anish Kumar
  Cc: kbuild-all, Mark Brown, Liam Girdwood, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, linux-kernel


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 max98925.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/max98925.c b/sound/soc/codecs/max98925.c
index 74f4f0b..34fc4d0 100644
--- a/sound/soc/codecs/max98925.c
+++ b/sound/soc/codecs/max98925.c
@@ -186,7 +186,7 @@ static bool max98925_readable_register(struct device *dev, unsigned int reg)
 	}
 }
 
-DECLARE_TLV_DB_SCALE(max98925_spk_tlv, -600, 100, 0);
+static DECLARE_TLV_DB_SCALE(max98925_spk_tlv, -600, 100, 0);
 
 static const struct snd_kcontrol_new max98925_snd_controls[] = {
 	SOC_SINGLE_TLV("Speaker Volume", MAX98925_GAIN,

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [asoc:topic/max98925 1/1] sound/soc/codecs/max98925.c:189:1: sparse: symbol 'max98925_spk_tlv' was not declared. Should it be static?
@ 2015-03-11 19:05 kbuild test robot
  2015-03-11 19:05 ` [PATCH asoc] ASoC: max98925_spk_tlv can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-11 19:05 UTC (permalink / raw)
  To: Anish Kumar
  Cc: kbuild-all, Mark Brown, Liam Girdwood, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/max98925
head:   31bdf73603f61a22c1643d1d887cf36eaa3a6834
commit: 31bdf73603f61a22c1643d1d887cf36eaa3a6834 [1/1] ASoC: Add max98925 codec driver
reproduce:
  # apt-get install sparse
  git checkout 31bdf73603f61a22c1643d1d887cf36eaa3a6834
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> sound/soc/codecs/max98925.c:189:1: sparse: symbol 'max98925_spk_tlv' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH asoc] ASoC: max98925_spk_tlv can be static
  2015-03-11 19:05 ` [PATCH asoc] ASoC: max98925_spk_tlv can be static kbuild test robot
@ 2015-03-11 19:13   ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-03-11 19:13 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Anish Kumar, kbuild-all, Liam Girdwood, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

On Thu, Mar 12, 2015 at 03:05:44AM +0800, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-11 19:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-11 19:05 [asoc:topic/max98925 1/1] sound/soc/codecs/max98925.c:189:1: sparse: symbol 'max98925_spk_tlv' was not declared. Should it be static? kbuild test robot
2015-03-11 19:05 ` [PATCH asoc] ASoC: max98925_spk_tlv can be static kbuild test robot
2015-03-11 19:13   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.