All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
	<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"pawel.moll-5wv7dgnIgG8@public.gmane.org"
	<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"mark.rutland-5wv7dgnIgG8@public.gmane.org"
	<mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: imx6qdl-sabreauto.dtsi: add max7310 support
Date: Fri, 13 Mar 2015 10:40:43 +0800	[thread overview]
Message-ID: <20150313024041.GA24143@shlinux2> (raw)
In-Reply-To: <20150311014606.GY20455@dragon>

On Wed, Mar 11, 2015 at 09:46:09AM +0800, Shawn Guo wrote:
> On Mon, Mar 09, 2015 at 05:28:06PM +0800, Peter Chen wrote:
> > max7310 is an i2c interface gpio expander
> > 
> > Signed-off-by: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 43 ++++++++++++++++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > index 009abd6..51acfec 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > @@ -28,6 +28,13 @@
> >  		};
> >  	};
> >  
> > +	max7310_reset: max7310-reset {
> > +		compatible = "gpio-reset";
> 
> The mainline kernel doesn't seem to have a gpio-reset driver/binding
> yet.
> 

Yeah, the driver still handles reset by itself instead of DT.
Even without reset operation, my max7310 chip works ok.
Would you accept that I delete this reset operation
and send v2?

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: imx6qdl-sabreauto.dtsi: add max7310 support
Date: Fri, 13 Mar 2015 10:40:43 +0800	[thread overview]
Message-ID: <20150313024041.GA24143@shlinux2> (raw)
In-Reply-To: <20150311014606.GY20455@dragon>

On Wed, Mar 11, 2015 at 09:46:09AM +0800, Shawn Guo wrote:
> On Mon, Mar 09, 2015 at 05:28:06PM +0800, Peter Chen wrote:
> > max7310 is an i2c interface gpio expander
> > 
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 43 ++++++++++++++++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > index 009abd6..51acfec 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > @@ -28,6 +28,13 @@
> >  		};
> >  	};
> >  
> > +	max7310_reset: max7310-reset {
> > +		compatible = "gpio-reset";
> 
> The mainline kernel doesn't seem to have a gpio-reset driver/binding
> yet.
> 

Yeah, the driver still handles reset by itself instead of DT.
Even without reset operation, my max7310 chip works ok.
Would you accept that I delete this reset operation
and send v2?

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2015-03-13  2:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09  9:28 [PATCH 0/3] imx: add max7310 and usb support for imx6qdl sabreauto Peter Chen
2015-03-09  9:28 ` Peter Chen
     [not found] ` <1425893288-1517-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-03-09  9:28   ` [PATCH 1/3] ARM: imx6qdl-sabreauto.dtsi: add max7310 support Peter Chen
2015-03-09  9:28     ` Peter Chen
     [not found]     ` <1425893288-1517-2-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-03-11  1:46       ` Shawn Guo
2015-03-11  1:46         ` Shawn Guo
2015-03-13  2:40         ` Peter Chen [this message]
2015-03-13  2:40           ` Peter Chen
2015-03-13  3:37           ` Shawn Guo
2015-03-13  3:37             ` Shawn Guo
2015-03-09  9:28   ` [PATCH 2/3] ARM: imx6qdl-sabreauto.dtsi: enable USB support Peter Chen
2015-03-09  9:28     ` Peter Chen
2015-03-09  9:28   ` [PATCH 3/3] ARM: imx_v6_v7_defconfig: Add CONFIG_GPIO_PCA953X Peter Chen
2015-03-09  9:28     ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313024041.GA24143@shlinux2 \
    --to=peter.chen-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.