* [PATCH] Staging: fbtbt: Move variable declarations
@ 2015-03-12 9:21 Vatika Harlalka
2015-03-15 10:45 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Vatika Harlalka @ 2015-03-12 9:21 UTC (permalink / raw)
To: outreachy-kernel
Move variable declarations so as to follow kernel coding
conventions.
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
index 2ec607d..acf5acb 100644
--- a/drivers/staging/fbtft/fb_agm1264k-fl.c
+++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
@@ -410,15 +410,14 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
static int write(struct fbtft_par *par, void *buf, size_t len)
{
+ u8 i, data;
+
fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
"%s(len=%d): ", __func__, len);
gpio_set_value(par->RW, 0); /* set write mode */
-
while (len--) {
- u8 i, data;
-
data = *(u8 *) buf++;
/* set data bus */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: fbtbt: Move variable declarations
2015-03-12 9:21 [PATCH] Staging: fbtbt: Move variable declarations Vatika Harlalka
@ 2015-03-15 10:45 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-03-15 10:45 UTC (permalink / raw)
To: Vatika Harlalka; +Cc: outreachy-kernel
On Thu, Mar 12, 2015 at 02:51:28PM +0530, Vatika Harlalka wrote:
> Move variable declarations so as to follow kernel coding
> conventions.
>
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
> drivers/staging/fbtft/fb_agm1264k-fl.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index 2ec607d..acf5acb 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -410,15 +410,14 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
>
> static int write(struct fbtft_par *par, void *buf, size_t len)
> {
> + u8 i, data;
> +
> fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
> "%s(len=%d): ", __func__, len);
>
> gpio_set_value(par->RW, 0); /* set write mode */
>
> -
> while (len--) {
> - u8 i, data;
> -
Why? There is nothing wrong with this code at all, please leave it
as-is, unless there is a good reason to move it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-15 10:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12 9:21 [PATCH] Staging: fbtbt: Move variable declarations Vatika Harlalka
2015-03-15 10:45 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.