Re: [PATCH] x86,boot: standardize strcmp()

From: Borislav Petkov <bp@alien8.de>
To: Arjun Sreedharan <arjun024@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86,boot: standardize strcmp()
Date: Mon, 16 Mar 2015 19:16:58 +0100	[thread overview]
Message-ID: <20150316181658.GB22841@pd.tnic> (raw)
In-Reply-To: <1426520267-1803-1-git-send-email-arjun024@gmail.com>

On Mon, Mar 16, 2015 at 09:07:47PM +0530, Arjun Sreedharan wrote:
> strcmp() is always expected to return 0 when args are
> same, <0 when arg1 is lesser and >0 otherwise.
> Previously strcmp("a","b") returned 1. Now it gives -1.
> 
> Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
> ---
>  arch/x86/boot/string.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
> index 493f3fd..318b846 100644
> --- a/arch/x86/boot/string.c
> +++ b/arch/x86/boot/string.c
> @@ -30,7 +30,7 @@ int strcmp(const char *str1, const char *str2)
>  	int delta = 0;
>  
>  	while (*s1 || *s2) {
> -		delta = *s2 - *s1;
> +		delta = *s1 - *s2;
>  		if (delta)
>  			return delta;
>  		s1++;
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--