[Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Markus Armbruster]

Error classes are a leftover from the days of "rich" error objects.
New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit 1d0d59f
added a use of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace it.
---
 ui/vnc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/vnc.c b/ui/vnc.c
index 6f9b718..a950016 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3594,7 +3594,7 @@ void vnc_display_open(const char *id, Error **errp)
 
         dev = qdev_find_recursive(sysbus_get_default(), device_id);
         if (dev == NULL) {
-            error_set(errp, QERR_DEVICE_NOT_FOUND, device_id);
+            error_setg(errp, "Device '%s' not found", device_id);
             goto fail;
         }
 
-- 
1.9.3

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Markus Armbruster]

Markus Armbruster <armbru@redhat.com> writes:

> Error classes are a leftover from the days of "rich" error objects.
> New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit 1d0d59f
> added a use of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>

>  ui/vnc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 6f9b718..a950016 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3594,7 +3594,7 @@ void vnc_display_open(const char *id, Error **errp)
>  
>          dev = qdev_find_recursive(sysbus_get_default(), device_id);
>          if (dev == NULL) {
> -            error_set(errp, QERR_DEVICE_NOT_FOUND, device_id);
> +            error_setg(errp, "Device '%s' not found", device_id);
>              goto fail;
>          }

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Patchew Tool]

This series passed Patchew automatic testing, but there are some warnings.

Find the log fragments below, or open the following URL to see the full log:

http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-armbru@redhat.com>

----------8<---------


=== Starting docker ===

Copying test script "/home/patchew/tests/qemu-devel.sh"
Starting docker...
docker run --net=none -v /var/tmp/patchew-tester/tmpy9kx15:/var/tmp/patchew-test patchew:fedora-20 timeout 3600 /var/tmp/patchew-test/qemu-devel.sh /var/tmp/patchew-test

*** Testing 'coding style check' ***

Checking 0001-vnc--Fix-QMP-change-not-to-use-funky-error-class.patch
command failed with exit code 0
$@
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 8 lines checked

0001-vnc--Fix-QMP-change-not-to-use-funky-error-class.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


*** Testing 'configure' ***

Install prefix    /usr/local
BIOS directory    /usr/local/share/qemu
binary directory  /usr/local/bin
library directory /usr/local/lib
module directory  /usr/local/lib/qemu
libexec directory /usr/local/libexec

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Peter Maydell]

On 13 March 2015 at 17:50, Patchew Tool <patchew.tool@gmail.com> wrote:
>
> This series passed Patchew automatic testing, but there are some warnings.
>
> Find the log fragments below, or open the following URL to see the full log:
>
> http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-armbru@redhat.com>

It would be nice to encode special characters like '<' and '>' in these
URLs in emails, because otherwise mail clients are less likely
to treat the whole string as a single URL. (GMail for instance
assumes the URL stops at '<').

If you use URLs like:
http://qemu.patchew.org/testing/log/%3C1426268589-14756-1-git-send-email-armbru@redhat.com%3E

then they work exactly the same only without confusing clients
that auto-hyper-link text.

thanks
-- PMM

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[John Snow]

On 03/13/2015 01:56 PM, Peter Maydell wrote:
> On 13 March 2015 at 17:50, Patchew Tool <patchew.tool@gmail.com> wrote:
>>
>> This series passed Patchew automatic testing, but there are some warnings.
>>
>> Find the log fragments below, or open the following URL to see the full log:
>>
>> http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-armbru@redhat.com>
>
> It would be nice to encode special characters like '<' and '>' in these
> URLs in emails, because otherwise mail clients are less likely
> to treat the whole string as a single URL. (GMail for instance
> assumes the URL stops at '<').
>
> If you use URLs like:
> http://qemu.patchew.org/testing/log/%3C1426268589-14756-1-git-send-email-armbru@redhat.com%3E
>
> then they work exactly the same only without confusing clients
> that auto-hyper-link text.
>
> thanks
> -- PMM
>

I've got some patches that fix this for the web interface (since <> are 
invalid URL characters), I'll copy this over into the email bits, too.

Thanks,
--js

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On 03/13/2015 11:48 AM, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
> 
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit 1d0d59f
>> added a use of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace it.

"always" is a strong word; there are cases where alternate error classes
are useful.  But I agree that this does not seem to be one of those
cases.  Therefore:

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
>>  ui/vnc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Fam Zheng]

On Fri, 03/13 17:56, Peter Maydell wrote:
> On 13 March 2015 at 17:50, Patchew Tool <patchew.tool@gmail.com> wrote:
> >
> > This series passed Patchew automatic testing, but there are some warnings.
> >
> > Find the log fragments below, or open the following URL to see the full log:
> >
> > http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-armbru@redhat.com>
> 
> It would be nice to encode special characters like '<' and '>' in these
> URLs in emails, because otherwise mail clients are less likely
> to treat the whole string as a single URL. (GMail for instance
> assumes the URL stops at '<').
> 
> If you use URLs like:
> http://qemu.patchew.org/testing/log/%3C1426268589-14756-1-git-send-email-armbru@redhat.com%3E
> 
> then they work exactly the same only without confusing clients
> that auto-hyper-link text.
> 
> thanks
> -- PMM
> 

Good suggestion! I've done the modify locally and it will be effective after
some testing. Thanks.

Fam

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

[Markus Armbruster]

Markus Armbruster <armbru@redhat.com> writes:

> Error classes are a leftover from the days of "rich" error objects.
> New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit 1d0d59f
> added a use of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace it.

Forgot to spell it out: this needs to go into 2.3, because it fixes an
external interface.