All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl
@ 2015-03-13  7:27 Wanpeng Li
  2015-03-17  2:24 ` Wanpeng Li
  0 siblings, 1 reply; 6+ messages in thread
From: Wanpeng Li @ 2015-03-13  7:27 UTC (permalink / raw)
  To: Ingo Molnar, Peter Zijlstra; +Cc: Juri Lelli, linux-kernel, Wanpeng Li

After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter
modification handling"), deadline task throttled status is cleared
each time switch from dl, so throttled status always unset when
switch back, there is no need to check throttled status, this patch
drop the check.

Acked-by: Juri Lelli <juri.lelli@arm.com>
Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
---
 kernel/sched/deadline.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 3fa8fa6..5cb5c9c 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1659,14 +1659,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
 {
 	int check_resched = 1;
 
-	/*
-	 * If p is throttled, don't consider the possibility
-	 * of preempting rq->curr, the check will be done right
-	 * after its runtime will get replenished.
-	 */
-	if (unlikely(p->dl.dl_throttled))
-		return;
-
 	if (task_on_rq_queued(p) && rq->curr != p) {
 #ifdef CONFIG_SMP
 		if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl
  2015-03-13  7:27 [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl Wanpeng Li
@ 2015-03-17  2:24 ` Wanpeng Li
  2015-03-17  8:08   ` Ingo Molnar
  0 siblings, 1 reply; 6+ messages in thread
From: Wanpeng Li @ 2015-03-17  2:24 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Peter Zijlstra, Juri Lelli, linux-kernel, Wanpeng Li

Ping Ingo, ;-)
On Fri, Mar 13, 2015 at 03:27:51PM +0800, Wanpeng Li wrote:
>After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter
>modification handling"), deadline task throttled status is cleared
>each time switch from dl, so throttled status always unset when
>switch back, there is no need to check throttled status, this patch
>drop the check.
>
>Acked-by: Juri Lelli <juri.lelli@arm.com>
>Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>---
> kernel/sched/deadline.c | 8 --------
> 1 file changed, 8 deletions(-)
>
>diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>index 3fa8fa6..5cb5c9c 100644
>--- a/kernel/sched/deadline.c
>+++ b/kernel/sched/deadline.c
>@@ -1659,14 +1659,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
> {
> 	int check_resched = 1;
> 
>-	/*
>-	 * If p is throttled, don't consider the possibility
>-	 * of preempting rq->curr, the check will be done right
>-	 * after its runtime will get replenished.
>-	 */
>-	if (unlikely(p->dl.dl_throttled))
>-		return;
>-
> 	if (task_on_rq_queued(p) && rq->curr != p) {
> #ifdef CONFIG_SMP
> 		if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
>-- 
>1.9.1

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl
  2015-03-17  2:24 ` Wanpeng Li
@ 2015-03-17  8:08   ` Ingo Molnar
  2015-03-17  8:59     ` Wanpeng Li
  2015-03-17  9:50     ` Juri Lelli
  0 siblings, 2 replies; 6+ messages in thread
From: Ingo Molnar @ 2015-03-17  8:08 UTC (permalink / raw)
  To: Wanpeng Li; +Cc: Peter Zijlstra, Juri Lelli, linux-kernel


* Wanpeng Li <wanpeng.li@linux.intel.com> wrote:

> Ping Ingo, ;-)

So the changelog is not very readable to me, it has various spelling 
mistakes that make it hard to read. Seems like Juri acked the patch, 
mind asking him to fix the changelog to be readable?

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl
  2015-03-17  8:08   ` Ingo Molnar
@ 2015-03-17  8:59     ` Wanpeng Li
  2015-03-17  9:50     ` Juri Lelli
  1 sibling, 0 replies; 6+ messages in thread
From: Wanpeng Li @ 2015-03-17  8:59 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Wanpeng Li, Peter Zijlstra, Juri Lelli, linux-kernel

On Tue, Mar 17, 2015 at 09:08:31AM +0100, Ingo Molnar wrote:
>
>* Wanpeng Li <wanpeng.li@linux.intel.com> wrote:
>
>> Ping Ingo, ;-)
>
>So the changelog is not very readable to me, it has various spelling 
>mistakes that make it hard to read. Seems like Juri acked the patch, 
>mind asking him to fix the changelog to be readable?

Oh, sorry for my bad english, I will update these two patches soon.

Regards,
Wanpeng Li 

>
>Thanks,
>
>	Ingo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl
  2015-03-17  8:08   ` Ingo Molnar
  2015-03-17  8:59     ` Wanpeng Li
@ 2015-03-17  9:50     ` Juri Lelli
  2015-03-17  9:50       ` Wanpeng Li
  1 sibling, 1 reply; 6+ messages in thread
From: Juri Lelli @ 2015-03-17  9:50 UTC (permalink / raw)
  To: Ingo Molnar, Wanpeng Li; +Cc: Peter Zijlstra, linux-kernel

Hi Ingo,

On 17/03/15 08:08, Ingo Molnar wrote:
> 
> * Wanpeng Li <wanpeng.li@linux.intel.com> wrote:
> 
>> Ping Ingo, ;-)
> 
> So the changelog is not very readable to me, it has various spelling 
> mistakes that make it hard to read. Seems like Juri acked the patch, 
> mind asking him to fix the changelog to be readable?
> 

Yes, sure. I'll go over the changelog of this and the other patches.

Thanks,

- Juri

> Thanks,
> 
> 	Ingo
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl
  2015-03-17  9:50     ` Juri Lelli
@ 2015-03-17  9:50       ` Wanpeng Li
  0 siblings, 0 replies; 6+ messages in thread
From: Wanpeng Li @ 2015-03-17  9:50 UTC (permalink / raw)
  To: Juri Lelli; +Cc: Wanpeng Li, Peter Zijlstra, linux-kernel, Ingo Molnar

On Tue, Mar 17, 2015 at 09:50:10AM +0000, Juri Lelli wrote:
>Hi Ingo,
>
>On 17/03/15 08:08, Ingo Molnar wrote:
>> 
>> * Wanpeng Li <wanpeng.li@linux.intel.com> wrote:
>> 
>>> Ping Ingo, ;-)
>> 
>> So the changelog is not very readable to me, it has various spelling 
>> mistakes that make it hard to read. Seems like Juri acked the patch, 
>> mind asking him to fix the changelog to be readable?
>> 
>
>Yes, sure. I'll go over the changelog of this and the other patches.

Thanks, ;-)

Regards,
Wanpeng Li

>
>Thanks,
>
>- Juri
>
>> Thanks,
>> 
>> 	Ingo
>> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-17 10:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13  7:27 [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl Wanpeng Li
2015-03-17  2:24 ` Wanpeng Li
2015-03-17  8:08   ` Ingo Molnar
2015-03-17  8:59     ` Wanpeng Li
2015-03-17  9:50     ` Juri Lelli
2015-03-17  9:50       ` Wanpeng Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.