From: Chao Peng <chao.p.peng@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org,
will.auld@intel.com, keir@xen.org, dgdegra@tycho.nsa.gov
Subject: Re: [PATCH 4/6] x86: add scheduling support for Intel CAT
Date: Tue, 17 Mar 2015 17:33:41 +0800 [thread overview]
Message-ID: <20150317093341.GF5371@pengc-linux.bj.intel.com> (raw)
In-Reply-To: <5507FFBE020000780006A9A8@mail.emea.novell.com>
On Tue, Mar 17, 2015 at 09:19:42AM +0000, Jan Beulich wrote:
> > + psra->cos_mask = (~(~0ull << (get_count_order(info->cos_max)
> > + + 32))) & (~0ull << 32);
>
> ((1ull << get_count_order()) - 1) << 32
>
> seems better readable to me.
Indeed :)
>
> > void psr_ctxt_switch_to(struct domain *d)
> > {
> > + uint64_t reg;
> > + struct psr_assoc *psra = &this_cpu(psr_assoc);
> > +
> > + psr_assoc_reg_read(psra, ®);
>
> This ultimately leading to psr_assoc_init() makes it really undesirable
> here imo: Initialization work shouldn't be done during a context
> switch, even is this a one time thing on each CPU.
This is what we did in CMT patch. But now I think psr_assoc_init()
can be called from cat_cpu_init() other than here.
Chao
next prev parent reply other threads:[~2015-03-17 9:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 10:13 [PATCH 0/6] enable Cache Allocation Technology (CAT) for VMs Chao Peng
2015-03-13 10:13 ` [PATCH 1/6] x86: detect and initialize Intel CAT feature Chao Peng
2015-03-13 13:40 ` Konrad Rzeszutek Wilk
2015-03-13 13:43 ` Konrad Rzeszutek Wilk
2015-03-17 8:11 ` Chao Peng
2015-03-17 13:00 ` Konrad Rzeszutek Wilk
2015-03-18 8:31 ` Chao Peng
2015-03-16 13:47 ` Jan Beulich
2015-03-17 8:48 ` Chao Peng
2015-03-17 9:01 ` Jan Beulich
2015-03-13 10:13 ` [PATCH 2/6] x86: add support for COS/CBM manangement Chao Peng
2015-03-13 13:53 ` Konrad Rzeszutek Wilk
2015-03-17 8:57 ` Chao Peng
2015-03-16 17:10 ` Jan Beulich
2015-03-17 9:11 ` Chao Peng
2015-03-17 9:25 ` Jan Beulich
2015-03-17 10:06 ` Chao Peng
2015-03-13 10:13 ` [PATCH 3/6] X86: improve psr scheduling code Chao Peng
2015-03-16 16:53 ` Jan Beulich
2015-03-17 9:12 ` Chao Peng
2015-03-13 10:13 ` [PATCH 4/6] x86: add scheduling support for Intel CAT Chao Peng
2015-03-17 9:19 ` Jan Beulich
2015-03-17 9:33 ` Chao Peng [this message]
2015-03-13 10:13 ` [PATCH 5/6] xsm: add CAT related xsm policies Chao Peng
2015-03-13 16:45 ` Daniel De Graaf
2015-03-13 10:13 ` [PATCH 6/6] tools: add tools support for Intel CAT Chao Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317093341.GF5371@pengc-linux.bj.intel.com \
--to=chao.p.peng@linux.intel.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=will.auld@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.