[PATCH octeon-usb] fix 'line over 80 characters'

[PATCH octeon-usb] fix 'line over 80 characters'

[Amitoj Kaur Chawla]

This file contained a warning of a line being over 80 characters and
so the file has been edited to remove that warning.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 1daeb31..c8df0c3 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel)
 				pipe->pid_toggle = 1;
 				if (__cvmx_usb_pipe_needs_split(usb, pipe))
 					transaction->stage =
-						CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;
+					CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;
 				else {
 					struct usb_ctrlrequest *header =
 						cvmx_phys_to_ptr(transaction->control_header);
-- 
1.9.1

Re: [PATCH octeon-usb] fix 'line over 80 characters'

[Greg KH]

On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote:
> 
> This file contained a warning of a line being over 80 characters and
> so the file has been edited to remove that warning.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>


Why did you put the driver name within the []?  It needs to go outside
of it.

> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..c8df0c3 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel)
>  				pipe->pid_toggle = 1;
>  				if (__cvmx_usb_pipe_needs_split(usb, pipe))
>  					transaction->stage =
> -						CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;
> +					CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;

This really doesn't help much, the original code is fine, there are
better things to fix in this file :)

thanks,

greg k-h

Re: [PATCH octeon-usb] fix 'line over 80 characters'

[Aaro Koskinen]

Hi,

On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote:
> This file contained a warning of a line being over 80 characters and
> so the file has been edited to remove that warning.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..c8df0c3 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel)
>  				pipe->pid_toggle = 1;
>  				if (__cvmx_usb_pipe_needs_split(usb, pipe))
>  					transaction->stage =
> -						CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;
> +					CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;

This is not an improvement. The proper fix is to refactor the code
to avoid deep nesting.

A.