* [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit
@ 2015-03-18 19:07 Maxime Lorrillere
2015-03-18 19:53 ` Dilger, Andreas
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Lorrillere @ 2015-03-18 19:07 UTC (permalink / raw)
To: andreas.dilger, gregkh; +Cc: linux-kernel, laure.millet, maxime.lorrillere
From: Laure Millet <laure.millet@lip6.fr>
This patch fixes lines over 80 characters
Signed-off-by: Laure Millet <laure.millet@lip6.fr>
Signed-off-by: Maxime Lorrillere <maxime.lorrillere@lip6.fr>
---
drivers/staging/lustre/lustre/llite/namei.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
index 3fa529d..49f1cb0 100644
--- a/drivers/staging/lustre/lustre/llite/namei.c
+++ b/drivers/staging/lustre/lustre/llite/namei.c
@@ -83,7 +83,8 @@ static int ll_set_inode(struct inode *inode, void *opaque)
lli->lli_fid = body->fid1;
if (unlikely(!(body->valid & OBD_MD_FLTYPE))) {
- CERROR("Can not initialize inode " DFID " without object type: valid = %#llx\n",
+ CERROR("Can not initialize inode " DFID
+ " without object type: valid = %#llx\n",
PFID(&lli->lli_fid), body->valid);
return -EINVAL;
}
@@ -600,7 +601,8 @@ static int ll_atomic_open(struct inode *dir, struct dentry *dentry,
long long lookup_flags = LOOKUP_OPEN;
int rc = 0;
- CDEBUG(D_VFSTRACE, "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags %x,mode %x opened %d\n",
+ CDEBUG(D_VFSTRACE,
+ "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags %x,mode %x opened %d\n",
dentry, dir->i_ino,
dir->i_generation, dir, file, open_flags, mode, *opened);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit
2015-03-18 19:07 [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit Maxime Lorrillere
@ 2015-03-18 19:53 ` Dilger, Andreas
2015-03-18 20:30 ` gregkh
0 siblings, 1 reply; 3+ messages in thread
From: Dilger, Andreas @ 2015-03-18 19:53 UTC (permalink / raw)
To: Maxime Lorrillere, gregkh; +Cc: linux-kernel, laure.millet
On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@lip6.fr>
wrote:
>From: Laure Millet <laure.millet@lip6.fr>
>
>This patch fixes lines over 80 characters
I think the newer rule is that strings shouldn't be split across lines.
That makes
the first hunk invalid, though the second one is OK.
Cheers, Andreas
>Signed-off-by: Laure Millet <laure.millet@lip6.fr>
>Signed-off-by: Maxime Lorrillere <maxime.lorrillere@lip6.fr>
>---
> drivers/staging/lustre/lustre/llite/namei.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/llite/namei.c
>b/drivers/staging/lustre/lustre/llite/namei.c
>index 3fa529d..49f1cb0 100644
>--- a/drivers/staging/lustre/lustre/llite/namei.c
>+++ b/drivers/staging/lustre/lustre/llite/namei.c
>@@ -83,7 +83,8 @@ static int ll_set_inode(struct inode *inode, void
>*opaque)
>
> lli->lli_fid = body->fid1;
> if (unlikely(!(body->valid & OBD_MD_FLTYPE))) {
>- CERROR("Can not initialize inode " DFID " without object type: valid =
>%#llx\n",
>+ CERROR("Can not initialize inode " DFID
>+ " without object type: valid = %#llx\n",
> PFID(&lli->lli_fid), body->valid);
> return -EINVAL;
> }
>@@ -600,7 +601,8 @@ static int ll_atomic_open(struct inode *dir, struct
>dentry *dentry,
> long long lookup_flags = LOOKUP_OPEN;
> int rc = 0;
>
>- CDEBUG(D_VFSTRACE, "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags
>%x,mode %x opened %d\n",
>+ CDEBUG(D_VFSTRACE,
>+ "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags %x,mode %x
>opened %d\n",
> dentry, dir->i_ino,
> dir->i_generation, dir, file, open_flags, mode, *opened);
>
>--
>1.7.10.4
>
>
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit
2015-03-18 19:53 ` Dilger, Andreas
@ 2015-03-18 20:30 ` gregkh
0 siblings, 0 replies; 3+ messages in thread
From: gregkh @ 2015-03-18 20:30 UTC (permalink / raw)
To: Dilger, Andreas; +Cc: Maxime Lorrillere, linux-kernel, laure.millet
On Wed, Mar 18, 2015 at 07:53:35PM +0000, Dilger, Andreas wrote:
> On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@lip6.fr>
> wrote:
>
> >From: Laure Millet <laure.millet@lip6.fr>
> >
> >This patch fixes lines over 80 characters
>
> I think the newer rule is that strings shouldn't be split across lines.
> That makes
> the first hunk invalid, though the second one is OK.
No, that first hunk is just fine, that horrid DFID macro allows it to
now be split :)
To fix this correctly, you need to move to using the "real" in-kernel
pr_err() functions, not custom macros. When that happens, checkpatch.pl
will stop complaining.
I'll take this one as-is.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-18 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-18 19:07 [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit Maxime Lorrillere
2015-03-18 19:53 ` Dilger, Andreas
2015-03-18 20:30 ` gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.