* [PATCH] staging: lustre: linux: linux-prim: fixed coding style warnings and errors
@ 2015-03-18 18:22 Roberto Medina
2015-03-18 20:59 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Roberto Medina @ 2015-03-18 18:22 UTC (permalink / raw)
To: oleg.drokin
Cc: gregkh, andreas.dilger, bergwolf, john.hammond, xuezhao.liu,
uja.ornl, asaf.vertz, HPDD-discuss, devel, linux-next,
Roberto Medina
From: Roberto Medina <robertoxmed@gmail.com>
Coding style fixes due to exported symbols and comment style.
Signed-off-by: Roberto Medina <robertoxmed@gmail.com>
---
.../lustre/lustre/libcfs/linux/linux-prim.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c
index fde2819..838f5f3 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c
@@ -117,11 +117,12 @@ EXPORT_SYMBOL(cfs_timer_deadline);
void cfs_enter_debugger(void)
{
#if defined(CONFIG_KGDB)
-// BREAKPOINT();
+ /* BREAKPOINT(); */
#else
/* nothing */
#endif
}
+EXPORT_SYMBOL(cfs_enter_debugger);
sigset_t
@@ -138,6 +139,7 @@ cfs_block_allsigs(void)
return old;
}
+EXPORT_SYMBOL(cfs_block_allsigs);
sigset_t cfs_block_sigs(unsigned long sigs)
{
@@ -151,6 +153,7 @@ sigset_t cfs_block_sigs(unsigned long sigs)
spin_unlock_irqrestore(¤t->sighand->siglock, flags);
return old;
}
+EXPORT_SYMBOL(cfs_block_sigs);
/* Block all signals except for the @sigs */
sigset_t cfs_block_sigsinv(unsigned long sigs)
@@ -166,9 +169,10 @@ sigset_t cfs_block_sigsinv(unsigned long sigs)
return old;
}
+EXPORT_SYMBOL(cfs_block_sigsinv);
void
-cfs_restore_sigs (sigset_t old)
+cfs_restore_sigs(sigset_t old)
{
unsigned long flags;
@@ -177,12 +181,14 @@ cfs_restore_sigs (sigset_t old)
recalc_sigpending();
spin_unlock_irqrestore(¤t->sighand->siglock, flags);
}
+EXPORT_SYMBOL(cfs_restore_sigs);
int
cfs_signal_pending(void)
{
return signal_pending(current);
}
+EXPORT_SYMBOL(cfs_signal_pending);
void
cfs_clear_sigpending(void)
@@ -193,25 +199,19 @@ cfs_clear_sigpending(void)
clear_tsk_thread_flag(current, TIF_SIGPENDING);
spin_unlock_irqrestore(¤t->sighand->siglock, flags);
}
+EXPORT_SYMBOL(cfs_clear_sigpending);
int
libcfs_arch_init(void)
{
return 0;
}
+EXPORT_SYMBOL(libcfs_arch_init);
void
libcfs_arch_cleanup(void)
{
return;
}
-
-EXPORT_SYMBOL(libcfs_arch_init);
EXPORT_SYMBOL(libcfs_arch_cleanup);
-EXPORT_SYMBOL(cfs_enter_debugger);
-EXPORT_SYMBOL(cfs_block_allsigs);
-EXPORT_SYMBOL(cfs_block_sigs);
-EXPORT_SYMBOL(cfs_block_sigsinv);
-EXPORT_SYMBOL(cfs_restore_sigs);
-EXPORT_SYMBOL(cfs_signal_pending);
-EXPORT_SYMBOL(cfs_clear_sigpending);
+
--
2.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: linux: linux-prim: fixed coding style warnings and errors
2015-03-18 18:22 [PATCH] staging: lustre: linux: linux-prim: fixed coding style warnings and errors Roberto Medina
@ 2015-03-18 20:59 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-03-18 20:59 UTC (permalink / raw)
To: Roberto Medina
Cc: devel, asaf.vertz, andreas.dilger, uja.ornl, bergwolf,
xuezhao.liu, oleg.drokin, linux-next, HPDD-discuss, john.hammond
On Wed, Mar 18, 2015 at 07:22:49PM +0100, Roberto Medina wrote:
> From: Roberto Medina <robertoxmed@gmail.com>
>
> Coding style fixes due to exported symbols and comment style.
>
> Signed-off-by: Roberto Medina <robertoxmed@gmail.com>
As we spoke in person, it's best to do only one logical thing per patch,
but this one is just so easy to review, I'll take it as-is :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-18 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-18 18:22 [PATCH] staging: lustre: linux: linux-prim: fixed coding style warnings and errors Roberto Medina
2015-03-18 20:59 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.