All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: lustre: ldlm_pool: fix coding style
@ 2015-03-18 20:11 Guillaume Turchini
  2015-03-18 21:06 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Turchini @ 2015-03-18 20:11 UTC (permalink / raw)
  To: gregkh
  Cc: oleg.drokin, andreas.dilger, rupran, gdonald, fabio.falzoi84,
	lixi, Julia.Lawall, joe, HPDD-discuss, devel, linux-kernel,
	Guillaume Turchini

Errors and warnings of coding style rules corrected.

Signed-off-by: Guillaume Turchini <guillaume.turchini@gmail.com>
---
 drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index 7574502..f4f3d0d 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
@@ -605,8 +605,8 @@ int ldlm_pool_recalc(struct ldlm_pool *pl)
 			      pl->pl_recalc_period;
 	if (recalc_interval_sec <= 0) {
 		/* Prevent too frequent recalculation. */
-		CDEBUG(D_DLMTRACE, "Negative interval(%ld), "
-		       "too short period(%ld)",
+		CDEBUG(D_DLMTRACE,
+		       "Negative interval(%ld), too short period(%ld)",
 		       recalc_interval_sec,
 		       pl->pl_recalc_period);
 		recalc_interval_sec = 1;
@@ -634,7 +634,8 @@ int ldlm_pool_shrink(struct ldlm_pool *pl, int nr,
 			lprocfs_counter_add(pl->pl_stats,
 					    LDLM_POOL_SHRINK_FREED_STAT,
 					    cancel);
-			CDEBUG(D_DLMTRACE, "%s: request to shrink %d locks, shrunk %d\n",
+			CDEBUG(D_DLMTRACE,
+			       "%s: request to shrink %d locks, shrunk %d\n",
 			       pl->pl_name, nr, cancel);
 		}
 	}
@@ -1364,8 +1365,8 @@ static int ldlm_pools_thread_main(void *arg)
 
 		if (thread_test_and_clear_flags(thread, SVC_STOPPING))
 			break;
-		else
-			thread_test_and_clear_flags(thread, SVC_EVENT);
+
+		thread_test_and_clear_flags(thread, SVC_EVENT);
 	}
 
 	thread_set_flags(thread, SVC_STOPPED);
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: lustre: ldlm_pool: fix coding style
  2015-03-18 20:11 [PATCH] Staging: lustre: ldlm_pool: fix coding style Guillaume Turchini
@ 2015-03-18 21:06 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-03-18 21:06 UTC (permalink / raw)
  To: Guillaume Turchini
  Cc: oleg.drokin, andreas.dilger, rupran, gdonald, fabio.falzoi84,
	lixi, Julia.Lawall, joe, HPDD-discuss, devel, linux-kernel

On Wed, Mar 18, 2015 at 09:11:22PM +0100, Guillaume Turchini wrote:
> Errors and warnings of coding style rules corrected.

You need to be a bit more specific and say what exact errors and
warnings were fixed.  And please only fix one type of error or warning
per patch you send out.  This patch should be broken up into a few
smaller patches.  Can you please do that and resend it?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-18 21:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-18 20:11 [PATCH] Staging: lustre: ldlm_pool: fix coding style Guillaume Turchini
2015-03-18 21:06 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.