* [PATCH jkirsher-next-queue] net/mlx4_en: mlx4_en_set_tx_maxrate() can be static
2015-03-19 0:51 [jkirsher-next-queue:dev-queue 828/842] drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2382:5: sparse: symbol 'mlx4_en_set_tx_maxrate' was not declared. Should it be static? kbuild test robot
@ 2015-03-19 0:51 ` kbuild test robot
2015-03-19 3:21 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-19 0:51 UTC (permalink / raw)
To: Or Gerlitz; +Cc: kbuild-all, Ido Shamay, Amir Vadai, netdev, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
en_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index d8dc3f9..763ba26 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2379,7 +2379,7 @@ static netdev_features_t mlx4_en_features_check(struct sk_buff *skb,
}
#endif
-int mlx4_en_set_tx_maxrate(struct net_device *dev, int queue_index, u32 maxrate)
+static int mlx4_en_set_tx_maxrate(struct net_device *dev, int queue_index, u32 maxrate)
{
struct mlx4_en_priv *priv = netdev_priv(dev);
struct mlx4_en_tx_ring *tx_ring = priv->tx_ring[queue_index];
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [jkirsher-next-queue:dev-queue 828/842] drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2382:5: sparse: symbol 'mlx4_en_set_tx_maxrate' was not declared. Should it be static?
@ 2015-03-19 0:51 kbuild test robot
2015-03-19 0:51 ` [PATCH jkirsher-next-queue] net/mlx4_en: mlx4_en_set_tx_maxrate() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-19 0:51 UTC (permalink / raw)
To: Or Gerlitz; +Cc: kbuild-all, Ido Shamay, Amir Vadai, netdev, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
head: ec59d04e8f5223083fdfb6124e8f087c1a4c5ec2
commit: c10e4fc6c45616dbadb8ccee189e2c09fb8f056f [828/842] net/mlx4_en: Add tx queue maxrate support
reproduce:
# apt-get install sparse
git checkout c10e4fc6c45616dbadb8ccee189e2c09fb8f056f
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2382:5: sparse: symbol 'mlx4_en_set_tx_maxrate' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH jkirsher-next-queue] net/mlx4_en: mlx4_en_set_tx_maxrate() can be static
2015-03-19 0:51 ` [PATCH jkirsher-next-queue] net/mlx4_en: mlx4_en_set_tx_maxrate() can be static kbuild test robot
@ 2015-03-19 3:21 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2015-03-19 3:21 UTC (permalink / raw)
To: fengguang.wu; +Cc: ogerlitz, kbuild-all, idos, amirv, netdev, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Thu, 19 Mar 2015 08:51:27 +0800
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-19 3:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-19 0:51 [jkirsher-next-queue:dev-queue 828/842] drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2382:5: sparse: symbol 'mlx4_en_set_tx_maxrate' was not declared. Should it be static? kbuild test robot
2015-03-19 0:51 ` [PATCH jkirsher-next-queue] net/mlx4_en: mlx4_en_set_tx_maxrate() can be static kbuild test robot
2015-03-19 3:21 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.