* [PATCH] clocksource: atmel-st: select REGMAP_MMIO
@ 2015-03-18 11:06 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-03-18 11:06 UTC (permalink / raw)
To: Nicolas Ferre, Daniel Lezcano
Cc: Boris Brezillon, linux-kernel, linux-arm-kernel, Alexandre Belloni
Enforce REGMAP_MMIO selection as the driver needs it. Else, it will still
compile with some warning about X1, x2 or sr being used uninitialized.
Reported-by: fengguang.wu@intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
Daniel,
I think this should go through the at91 tree as the patch introducing that issue
went there.
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 168035883afa..3cc97b217019 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -146,6 +146,7 @@ config ATMEL_PIT
config ATMEL_ST
bool
select CLKSRC_OF
+ select REGMAP_MMIO
config CLKSRC_METAG_GENERIC
def_bool y if METAG
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] clocksource: atmel-st: select REGMAP_MMIO
@ 2015-03-18 11:06 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-03-18 11:06 UTC (permalink / raw)
To: linux-arm-kernel
Enforce REGMAP_MMIO selection as the driver needs it. Else, it will still
compile with some warning about X1, x2 or sr being used uninitialized.
Reported-by: fengguang.wu at intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
Daniel,
I think this should go through the at91 tree as the patch introducing that issue
went there.
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 168035883afa..3cc97b217019 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -146,6 +146,7 @@ config ATMEL_PIT
config ATMEL_ST
bool
select CLKSRC_OF
+ select REGMAP_MMIO
config CLKSRC_METAG_GENERIC
def_bool y if METAG
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] clocksource: atmel-st: select REGMAP_MMIO
2015-03-18 11:06 ` Alexandre Belloni
@ 2015-03-19 8:02 ` Boris Brezillon
-1 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2015-03-19 8:02 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Nicolas Ferre, Daniel Lezcano, linux-kernel, linux-arm-kernel
Hi Alexandre,
On Wed, 18 Mar 2015 12:06:35 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> Enforce REGMAP_MMIO selection as the driver needs it. Else, it will still
> compile with some warning about X1, x2 or sr being used uninitialized.
>
> Reported-by: fengguang.wu@intel.com
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> Daniel,
>
> I think this should go through the at91 tree as the patch introducing that issue
> went there.
>
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 168035883afa..3cc97b217019 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -146,6 +146,7 @@ config ATMEL_PIT
> config ATMEL_ST
> bool
> select CLKSRC_OF
> + select REGMAP_MMIO
Shouldn't we select MFD_SYSCON instead.
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clocksource: atmel-st: select REGMAP_MMIO
@ 2015-03-19 8:02 ` Boris Brezillon
0 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2015-03-19 8:02 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alexandre,
On Wed, 18 Mar 2015 12:06:35 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> Enforce REGMAP_MMIO selection as the driver needs it. Else, it will still
> compile with some warning about X1, x2 or sr being used uninitialized.
>
> Reported-by: fengguang.wu at intel.com
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> Daniel,
>
> I think this should go through the at91 tree as the patch introducing that issue
> went there.
>
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 168035883afa..3cc97b217019 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -146,6 +146,7 @@ config ATMEL_PIT
> config ATMEL_ST
> bool
> select CLKSRC_OF
> + select REGMAP_MMIO
Shouldn't we select MFD_SYSCON instead.
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clocksource: atmel-st: select REGMAP_MMIO
2015-03-19 8:02 ` Boris Brezillon
@ 2015-03-19 12:53 ` Alexandre Belloni
-1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-03-19 12:53 UTC (permalink / raw)
To: Boris Brezillon
Cc: Nicolas Ferre, Daniel Lezcano, linux-kernel, linux-arm-kernel
On 19/03/2015 at 09:02:16 +0100, Boris Brezillon wrote :
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 168035883afa..3cc97b217019 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -146,6 +146,7 @@ config ATMEL_PIT
> > config ATMEL_ST
> > bool
> > select CLKSRC_OF
> > + select REGMAP_MMIO
>
> Shouldn't we select MFD_SYSCON instead.
>
Indeed, I'll send v2
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clocksource: atmel-st: select REGMAP_MMIO
@ 2015-03-19 12:53 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-03-19 12:53 UTC (permalink / raw)
To: linux-arm-kernel
On 19/03/2015 at 09:02:16 +0100, Boris Brezillon wrote :
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 168035883afa..3cc97b217019 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -146,6 +146,7 @@ config ATMEL_PIT
> > config ATMEL_ST
> > bool
> > select CLKSRC_OF
> > + select REGMAP_MMIO
>
> Shouldn't we select MFD_SYSCON instead.
>
Indeed, I'll send v2
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-19 12:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-18 11:06 [PATCH] clocksource: atmel-st: select REGMAP_MMIO Alexandre Belloni
2015-03-18 11:06 ` Alexandre Belloni
2015-03-19 8:02 ` Boris Brezillon
2015-03-19 8:02 ` Boris Brezillon
2015-03-19 12:53 ` Alexandre Belloni
2015-03-19 12:53 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.