All of lore.kernel.org
 help / color / mirror / Atom feed
* [next:master 5727/5749] drivers/gpio/gpio-altera.c:259:5: sparse: symbol 'altera_gpio_probe' was not declared. Should it be static?
@ 2015-03-19  9:40 kbuild test robot
  2015-03-19  9:40 ` [PATCH next] altera_gpio_probe() can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-19  9:40 UTC (permalink / raw)
  To: Linus Walleij
  Cc: kbuild-all, Tien Hock Loh, Alexandre Courbot, linux-gpio, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   ce040cc379e3e1e094db5559f393d794fbfd01e4
commit: 7fcb20a239a53831738bb991547ee4a1a0bebc06 [5727/5749] Merge remote-tracking branch 'gpio/for-next'
reproduce:
  # apt-get install sparse
  git checkout 7fcb20a239a53831738bb991547ee4a1a0bebc06
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpio/gpio-altera.c:259:5: sparse: symbol 'altera_gpio_probe' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH next] altera_gpio_probe() can be static
  2015-03-19  9:40 [next:master 5727/5749] drivers/gpio/gpio-altera.c:259:5: sparse: symbol 'altera_gpio_probe' was not declared. Should it be static? kbuild test robot
@ 2015-03-19  9:40 ` kbuild test robot
  2015-03-27  8:29   ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-03-19  9:40 UTC (permalink / raw)
  To: Linus Walleij
  Cc: kbuild-all, Tien Hock Loh, Alexandre Courbot, linux-gpio, linux-kernel


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 gpio-altera.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
index 4d41196..449fb46 100644
--- a/drivers/gpio/gpio-altera.c
+++ b/drivers/gpio/gpio-altera.c
@@ -256,7 +256,7 @@ static void altera_gpio_irq_leveL_high_handler(unsigned int irq,
 	chained_irq_exit(chip, desc);
 }
 
-int altera_gpio_probe(struct platform_device *pdev)
+static int altera_gpio_probe(struct platform_device *pdev)
 {
 	struct device_node *node = pdev->dev.of_node;
 	int reg, ret;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH next] altera_gpio_probe() can be static
  2015-03-19  9:40 ` [PATCH next] altera_gpio_probe() can be static kbuild test robot
@ 2015-03-27  8:29   ` Linus Walleij
  0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-03-27  8:29 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, Tien Hock Loh, Alexandre Courbot, linux-gpio, linux-kernel

On Thu, Mar 19, 2015 at 10:40 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:

>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Ah you made a patch too, I see. Applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-27  8:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-19  9:40 [next:master 5727/5749] drivers/gpio/gpio-altera.c:259:5: sparse: symbol 'altera_gpio_probe' was not declared. Should it be static? kbuild test robot
2015-03-19  9:40 ` [PATCH next] altera_gpio_probe() can be static kbuild test robot
2015-03-27  8:29   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.