* [PATCH] Staging: rtl8192u: Change C99 // comments
@ 2015-03-20 17:45 Hatice ERTÜRK
2015-03-23 21:38 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Hatice ERTÜRK @ 2015-03-20 17:45 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Hatice ERTURK
Remove the all '//' and instead of '/* */' put.
This Error found with checkpatch.pl
Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
.../staging/rtl8192u/ieee80211/ieee80211_module.c | 40 +++++++++++-----------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index a35ba01..6763ac5 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -152,7 +152,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
ieee->privacy_invoked = 0;
ieee->ieee802_1x = 1;
ieee->raw_tx = 0;
- //ieee->hwsec_support = 1; //defalt support hw security. //use module_param instead.
+ /* ieee->hwsec_support = 1; defalt support hw security. //use module_param instead. */
ieee->hwsec_active = 0; /* disable hwsec, switch it on when necessary. */
ieee80211_softmac_init(ieee);
@@ -195,8 +195,8 @@ void free_ieee80211(struct net_device *dev)
{
struct ieee80211_device *ieee = netdev_priv(dev);
int i;
- /* struct list_head *p, *q; */
-// del_timer_sync(&ieee->SwBwTimer);
+ /* struct list_head *p, *q;
+ del_timer_sync(&ieee->SwBwTimer); */
kfree(ieee->pHTInfo);
ieee->pHTInfo = NULL;
RemoveAllTS(ieee);
@@ -222,23 +222,23 @@ void free_ieee80211(struct net_device *dev)
u32 ieee80211_debug_level;
static int debug = \
- // IEEE80211_DL_INFO |
- // IEEE80211_DL_WX |
- // IEEE80211_DL_SCAN |
- // IEEE80211_DL_STATE |
- // IEEE80211_DL_MGMT |
- // IEEE80211_DL_FRAG |
- // IEEE80211_DL_EAP |
- // IEEE80211_DL_DROP |
- // IEEE80211_DL_TX |
- // IEEE80211_DL_RX |
- //IEEE80211_DL_QOS |
- // IEEE80211_DL_HT |
- // IEEE80211_DL_TS |
-// IEEE80211_DL_BA |
- // IEEE80211_DL_REORDER|
-// IEEE80211_DL_TRACE |
- //IEEE80211_DL_DATA |
+ /* IEEE80211_DL_INFO |
+ IEEE80211_DL_WX |
+ IEEE80211_DL_SCAN |
+ IEEE80211_DL_STATE |
+ IEEE80211_DL_MGMT |
+ IEEE80211_DL_FRAG |
+ IEEE80211_DL_EAP |
+ IEEE80211_DL_DROP |
+ IEEE80211_DL_TX |
+ IEEE80211_DL_RX |
+ IEEE80211_DL_QOS |
+ IEEE80211_DL_HT |
+ IEEE80211_DL_TS |
+ IEEE80211_DL_BA |
+ IEEE80211_DL_REORDER|
+ IEEE80211_DL_TRACE |
+ IEEE80211_DL_DATA | */
IEEE80211_DL_ERR /* awayls open this flags to show error out */
;
static struct proc_dir_entry *ieee80211_proc;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Change C99 // comments
2015-03-20 17:45 [PATCH] Staging: rtl8192u: Change C99 // comments Hatice ERTÜRK
@ 2015-03-23 21:38 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-03-23 21:38 UTC (permalink / raw)
To: Hatice ERTÜRK; +Cc: outreachy-kernel
On Fri, Mar 20, 2015 at 07:45:56PM +0200, Hatice ERT�RK wrote:
> Remove the all '//' and instead of '/* */' put.
> This Error found with checkpatch.pl
>
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> .../staging/rtl8192u/ieee80211/ieee80211_module.c | 40 +++++++++++-----------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> index a35ba01..6763ac5 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> @@ -152,7 +152,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
> ieee->privacy_invoked = 0;
> ieee->ieee802_1x = 1;
> ieee->raw_tx = 0;
> - //ieee->hwsec_support = 1; //defalt support hw security. //use module_param instead.
> + /* ieee->hwsec_support = 1; defalt support hw security. //use module_param instead. */
Lines like this can just be deleted, don't keep them around for no
reason.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-20 17:45 [PATCH] Staging: rtl8192u: Change C99 // comments Hatice ERTÜRK
2015-03-23 21:38 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.