* [Buildroot] [PATCH v5] lirc-tools: new package
@ 2015-03-24 21:40 Rhys Williams
2015-03-25 4:03 ` Baruch Siach
2015-04-03 13:21 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Rhys Williams @ 2015-03-24 21:40 UTC (permalink / raw)
To: buildroot
This package adds the userspace tools and daemons LIRC -
Linux remote control
Signed-off-by: Rhys Williams <github@wilberforce.co.nz>
---
package/lirc-tools/Config.in | 17 +++++++++++++++++
package/lirc-tools/S25lircd | 38 ++++++++++++++++++++++++++++++++++++++
package/lirc-tools/lirc-tools.hash | 2 ++
package/lirc-tools/lirc-tools.mk | 19 +++++++++++++++++++
4 files changed, 76 insertions(+)
create mode 100644 package/lirc-tools/Config.in
create mode 100755 package/lirc-tools/S25lircd
create mode 100644 package/lirc-tools/lirc-tools.hash
create mode 100644 package/lirc-tools/lirc-tools.mk
diff --git a/package/lirc-tools/Config.in b/package/lirc-tools/Config.in
new file mode 100644
index 0000000..f29724b
--- /dev/null
+++ b/package/lirc-tools/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_LIRC_TOOLS
+ bool "lirc-tools"
+ help
+ Linux Infrared Remote Control IR receiver/transmitter Daemon and tools
+ LIRC is a package that supports receiving and sending IR
+ signals of the most common IR remote controls. It contains a
+ daemon that decodes and sends IR signals, a mouse daemon
+ that translates IR signals to mouse movements and a couple
+ of user programs that allow to control your computer with a
+ remote control.
+
+ lircd, irw, irrecord, mode2 etc
+
+ Requires the kernel LIRC interface driver , add modules to support
+ your hardware.
+
+ http://www.lirc.org/
diff --git a/package/lirc-tools/S25lircd b/package/lirc-tools/S25lircd
new file mode 100755
index 0000000..e4d98f5
--- /dev/null
+++ b/package/lirc-tools/S25lircd
@@ -0,0 +1,38 @@
+#!/bin/sh
+#
+# Start lirc
+#
+# Support for remotes - Add remotes to /etc/lirc/lircd.conf.d/
+#
+
+start() {
+ echo -n "Starting lirc: "
+ mkdir /var/run/lirc
+ ln -s /var/run/lirc/lircd /dev/lircd
+ start-stop-daemon -b -S -q -m -p /var/run/lirc.pid --exec /usr/sbin/lircd -- -O /etc/lirc/lirc_options.conf
+ echo "OK"
+}
+
+stop() {
+ echo -n "Stopping lirc: "
+ start-stop-daemon -K -q -p /var/run/lirc.pid
+ echo "OK"
+}
+
+case "$1" in
+ start)
+ start
+ ;;
+ stop)
+ stop
+ ;;
+ restart|reload)
+ stop
+ start
+ ;;
+ *)
+ echo "Usage: $0 {start|stop|restart}"
+ exit 1
+esac
+
+exit $?
diff --git a/package/lirc-tools/lirc-tools.hash b/package/lirc-tools/lirc-tools.hash
new file mode 100644
index 0000000..3986767
--- /dev/null
+++ b/package/lirc-tools/lirc-tools.hash
@@ -0,0 +1,2 @@
+#hash from http://sourceforge.net/projects/lirc/files/LIRC/0.9.2/
+sha1 585daed1eaa169b9683a507e26b1331a947a4dcd lirc-0.9.2.tar.bz2
diff --git a/package/lirc-tools/lirc-tools.mk b/package/lirc-tools/lirc-tools.mk
new file mode 100644
index 0000000..44e1848
--- /dev/null
+++ b/package/lirc-tools/lirc-tools.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# lirc-tools
+#
+################################################################################
+
+LIRC_TOOLS_VERSION = 0.9.2
+LIRC_TOOLS_SOURCE = lirc-$(LIRC_TOOLS_VERSION).tar.bz2
+LIRC_TOOLS_SITE = http://downloads.sourceforge.net/project/lirc/LIRC/$(LIRC_TOOLS_VERSION)/
+LIRC_TOOLS_LICENSE = GPLv2+
+LIRC_TOOLS_LICENSE_FILES = COPYING
+
+LIRC_TOOLS_CONF_OPTS = --without-x --enable-sandboxed --with-driver=userspace
+
+define LIRC_TOOLS_INSTALL_INIT_SYSV
+ $(INSTALL) -D -m 0755 package/lirc-tools/S25lircd $(TARGET_DIR)/etc/init.d/
+endef
+
+$(eval $(autotools-package))
--
2.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v5] lirc-tools: new package
2015-03-24 21:40 [Buildroot] [PATCH v5] lirc-tools: new package Rhys Williams
@ 2015-03-25 4:03 ` Baruch Siach
2015-04-03 13:21 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2015-03-25 4:03 UTC (permalink / raw)
To: buildroot
Hi Rhys,
On Wed, Mar 25, 2015 at 10:40:28AM +1300, Rhys Williams wrote:
> This package adds the userspace tools and daemons LIRC -
> Linux remote control
>
> Signed-off-by: Rhys Williams <github@wilberforce.co.nz>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v5] lirc-tools: new package
2015-03-24 21:40 [Buildroot] [PATCH v5] lirc-tools: new package Rhys Williams
2015-03-25 4:03 ` Baruch Siach
@ 2015-04-03 13:21 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-04-03 13:21 UTC (permalink / raw)
To: buildroot
Dear Rhys Williams,
Cc'ing Baruch since he gave his Reviewed-by on this patch.
On Wed, 25 Mar 2015 10:40:28 +1300, Rhys Williams wrote:
> This package adds the userspace tools and daemons LIRC -
> Linux remote control
>
> Signed-off-by: Rhys Williams <github@wilberforce.co.nz>
Thanks, I've applied your patch after doing a number of
fixes/improvements to it. See below.
> diff --git a/package/lirc-tools/Config.in b/package/lirc-tools/Config.in
> new file mode 100644
> index 0000000..f29724b
> --- /dev/null
> +++ b/package/lirc-tools/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_LIRC_TOOLS
> + bool "lirc-tools"
Missing dependency on BR2_USE_MMU, since fork() is used in lirc-tools.
> + help
> + Linux Infrared Remote Control IR receiver/transmitter Daemon and tools
> + LIRC is a package that supports receiving and sending IR
> + signals of the most common IR remote controls. It contains a
> + daemon that decodes and sends IR signals, a mouse daemon
> + that translates IR signals to mouse movements and a couple
> + of user programs that allow to control your computer with a
> + remote control.
Lines too long, the text should be wrapped to a smaller length.
> + lircd, irw, irrecord, mode2 etc
This doesn't make much sense if there is no indication about what this
means, so I've removed this part.
> + Requires the kernel LIRC interface driver , add modules to support
> + your hardware.
I've slightly reworded since, and removed the space before comma.
> +
> + http://www.lirc.org/
> diff --git a/package/lirc-tools/S25lircd b/package/lirc-tools/S25lircd
> new file mode 100755
> index 0000000..e4d98f5
> --- /dev/null
> +++ b/package/lirc-tools/S25lircd
> @@ -0,0 +1,38 @@
> +#!/bin/sh
> +#
> +# Start lirc
> +#
> +# Support for remotes - Add remotes to /etc/lirc/lircd.conf.d/
> +#
> +
> +start() {
> + echo -n "Starting lirc: "
> + mkdir /var/run/lirc
This means that re-execution of the start step is not possible. I've
changed that to 'mkdir -p'.
> + ln -s /var/run/lirc/lircd /dev/lircd
Same issue, I've changed to 'ln -sf'.
> + start-stop-daemon -b -S -q -m -p /var/run/lirc.pid --exec /usr/sbin/lircd -- -O /etc/lirc/lirc_options.conf
With this, lircd continues to daemonize itself, so the pid stored in
/var/run/lirc.pid is not the real PID of the lircd daemon. I've changed
this to pass the '-n' option to lircd so that it doesn't daemonize
itself.
> diff --git a/package/lirc-tools/lirc-tools.mk b/package/lirc-tools/lirc-tools.mk
> new file mode 100644
> index 0000000..44e1848
> --- /dev/null
> +++ b/package/lirc-tools/lirc-tools.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# lirc-tools
> +#
> +################################################################################
> +
> +LIRC_TOOLS_VERSION = 0.9.2
> +LIRC_TOOLS_SOURCE = lirc-$(LIRC_TOOLS_VERSION).tar.bz2
> +LIRC_TOOLS_SITE = http://downloads.sourceforge.net/project/lirc/LIRC/$(LIRC_TOOLS_VERSION)/
> +LIRC_TOOLS_LICENSE = GPLv2+
> +LIRC_TOOLS_LICENSE_FILES = COPYING
> +
> +LIRC_TOOLS_CONF_OPTS = --without-x --enable-sandboxed --with-driver=userspace
> +
> +define LIRC_TOOLS_INSTALL_INIT_SYSV
> + $(INSTALL) -D -m 0755 package/lirc-tools/S25lircd $(TARGET_DIR)/etc/init.d/
A full destination path is what we use when calling $(INSTALL), so I've
changed this as well.
But the most problematic issue was actually that your new package
Config.in file was not included anywhere! Seems like you forgot to 'git
add package/Config.in'.
Committed with those issues fixed, see
http://git.buildroot.net/buildroot/commit/?id=1ba7e76d5786114e05482ae6528e6da61eb12be3
for more details.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-03 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-24 21:40 [Buildroot] [PATCH v5] lirc-tools: new package Rhys Williams
2015-03-25 4:03 ` Baruch Siach
2015-04-03 13:21 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.