* [PATCH 1/1] nfsd: NFSD_FAULT_INJECTION depends on DEBUG_FS
@ 2015-03-25 20:37 Chengyu Song
2015-03-26 1:02 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Chengyu Song @ 2015-03-25 20:37 UTC (permalink / raw)
To: bfields, linux-nfs, linux-kernel
Cc: taesoo, changwoo, sanidhya, blee, csong84
NFSD_FAULT_INJECTION depends on DEBUG_FS, otherwise the debugfs_create_*
interface may return unexpected error -ENODEV, and cause system crash.
Signed-off-by: Chengyu Song <csong84@gatech.edu>
---
fs/nfsd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
index 683bf71..8b87b7a 100644
--- a/fs/nfsd/Kconfig
+++ b/fs/nfsd/Kconfig
@@ -107,7 +107,7 @@ config NFSD_V4_SECURITY_LABEL
config NFSD_FAULT_INJECTION
bool "NFS server manual fault injection"
- depends on NFSD_V4 && DEBUG_KERNEL
+ depends on NFSD_V4 && DEBUG_KERNEL && DEBUG_FS
help
This option enables support for manually injecting faults
into the NFS server. This is intended to be used for
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] nfsd: NFSD_FAULT_INJECTION depends on DEBUG_FS
2015-03-25 20:37 [PATCH 1/1] nfsd: NFSD_FAULT_INJECTION depends on DEBUG_FS Chengyu Song
@ 2015-03-26 1:02 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2015-03-26 1:02 UTC (permalink / raw)
To: Chengyu Song; +Cc: linux-nfs, linux-kernel, taesoo, changwoo, sanidhya, blee
On Wed, Mar 25, 2015 at 04:37:07PM -0400, Chengyu Song wrote:
> NFSD_FAULT_INJECTION depends on DEBUG_FS, otherwise the debugfs_create_*
> interface may return unexpected error -ENODEV, and cause system crash.
Thanks, applying for 4.1.--b.
>
> Signed-off-by: Chengyu Song <csong84@gatech.edu>
> ---
> fs/nfsd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 683bf71..8b87b7a 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -107,7 +107,7 @@ config NFSD_V4_SECURITY_LABEL
>
> config NFSD_FAULT_INJECTION
> bool "NFS server manual fault injection"
> - depends on NFSD_V4 && DEBUG_KERNEL
> + depends on NFSD_V4 && DEBUG_KERNEL && DEBUG_FS
> help
> This option enables support for manually injecting faults
> into the NFS server. This is intended to be used for
> --
> 2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-26 1:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 20:37 [PATCH 1/1] nfsd: NFSD_FAULT_INJECTION depends on DEBUG_FS Chengyu Song
2015-03-26 1:02 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.