Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

[Matthijs van Duin]

On 26 March 2015 at 00:36, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> Let me know if you find any problems with this patch.

I spotted a minor issue in drivers/phy/Kconfig:

> +         Enable this for dm81xx USB to work.

This should say dm816x instead.

Matthijs

Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

[Tony Lindgren]

* Matthijs van Duin <matthijsvanduin@gmail.com> [150326 00:02]:
> On 26 March 2015 at 00:36, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> > Let me know if you find any problems with this patch.
> 
> I spotted a minor issue in drivers/phy/Kconfig:
> 
> > +         Enable this for dm81xx USB to work.
> 
> This should say dm816x instead.

Yes that's correct, the phy on dm814x seems to be like on am335x,
not like on dm816x. Kishon, let me know if you prefer a follow-up
patch to fix this.

I'm not seeing the original mail for this thread anywhere for some
reason BTW. It does not seem to be in the mailing list archives
either, well at least not yet.

Regards,

Tony

Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

[Kishon Vijay Abraham I]

Hi Tony,

On Thursday 26 March 2015 09:34 PM, Tony Lindgren wrote:
> * Matthijs van Duin <matthijsvanduin@gmail.com> [150326 00:02]:
>> On 26 March 2015 at 00:36, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> Let me know if you find any problems with this patch.
>>
>> I spotted a minor issue in drivers/phy/Kconfig:
>>
>>> +         Enable this for dm81xx USB to work.
>>
>> This should say dm816x instead.
>
> Yes that's correct, the phy on dm814x seems to be like on am335x,
> not like on dm816x. Kishon, let me know if you prefer a follow-up
> patch to fix this.

No. I've fixed this in my tree
https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit
/?h=next&id=9fa9fd4ffc90582091b8c6219f2054265f71e4ef
>
> I'm not seeing the original mail for this thread anywhere for some
> reason BTW. It does not seem to be in the mailing list archives
> either, well at least not yet.

It's an automated mail that is sent to notify the authors and other who are
explicitly added in the signed-off by section when a patch is being merged in
the linux-phy tree. So it won't be in the mailing list archives.

But I'm not sure why you didn't receive it :-(

Thanks
Kishon

Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

[Tony Lindgren]

* Kishon Vijay Abraham I <kishon@ti.com> [150331 09:37]:
> Hi Tony,
> 
> On Thursday 26 March 2015 09:34 PM, Tony Lindgren wrote:
> >* Matthijs van Duin <matthijsvanduin@gmail.com> [150326 00:02]:
> >>On 26 March 2015 at 00:36, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> >>>Let me know if you find any problems with this patch.
> >>
> >>I spotted a minor issue in drivers/phy/Kconfig:
> >>
> >>>+         Enable this for dm81xx USB to work.
> >>
> >>This should say dm816x instead.
> >
> >Yes that's correct, the phy on dm814x seems to be like on am335x,
> >not like on dm816x. Kishon, let me know if you prefer a follow-up
> >patch to fix this.
> 
> No. I've fixed this in my tree
> https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit
> /?h=next&id=9fa9fd4ffc90582091b8c6219f2054265f71e4ef

OK thanks!

> >I'm not seeing the original mail for this thread anywhere for some
> >reason BTW. It does not seem to be in the mailing list archives
> >either, well at least not yet.
> 
> It's an automated mail that is sent to notify the authors and other who are
> explicitly added in the signed-off by section when a patch is being merged in
> the linux-phy tree. So it won't be in the mailing list archives.
> 
> But I'm not sure why you didn't receive it :-(

No idea, maybe I accidentally deleted it or something.

Regards,

Tony

Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

[Tony Lindgren]

* Tony Lindgren <tony@atomide.com> [150331 09:56]:
> * Kishon Vijay Abraham I <kishon@ti.com> [150331 09:37]:
> > Hi Tony,
> > 
> > On Thursday 26 March 2015 09:34 PM, Tony Lindgren wrote:
> > >* Matthijs van Duin <matthijsvanduin@gmail.com> [150326 00:02]:
> > >>On 26 March 2015 at 00:36, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> > >>>Let me know if you find any problems with this patch.
> > >>
> > >>I spotted a minor issue in drivers/phy/Kconfig:
> > >>
> > >>>+         Enable this for dm81xx USB to work.
> > >>
> > >>This should say dm816x instead.
> > >
> > >Yes that's correct, the phy on dm814x seems to be like on am335x,
> > >not like on dm816x. Kishon, let me know if you prefer a follow-up
> > >patch to fix this.
> > 
> > No. I've fixed this in my tree
> > https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit
> > /?h=next&id=9fa9fd4ffc90582091b8c6219f2054265f71e4ef
> 
> OK thanks!

Kishon, looks like your next branch is not getting merged into
Linux next for some reason?

Regards,

Tony

Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

[Kishon Vijay Abraham I]

Hi Tony,

On Thursday 09 April 2015 11:52 PM, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [150331 09:56]:
>> * Kishon Vijay Abraham I <kishon@ti.com> [150331 09:37]:
>>> Hi Tony,
>>>
>>> On Thursday 26 March 2015 09:34 PM, Tony Lindgren wrote:
>>>> * Matthijs van Duin <matthijsvanduin@gmail.com> [150326 00:02]:
>>>>> On 26 March 2015 at 00:36, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>>>>> Let me know if you find any problems with this patch.
>>>>>
>>>>> I spotted a minor issue in drivers/phy/Kconfig:
>>>>>
>>>>>> +         Enable this for dm81xx USB to work.
>>>>>
>>>>> This should say dm816x instead.
>>>>
>>>> Yes that's correct, the phy on dm814x seems to be like on am335x,
>>>> not like on dm816x. Kishon, let me know if you prefer a follow-up
>>>> patch to fix this.
>>>
>>> No. I've fixed this in my tree
>>> https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit
>>> /?h=next&id=9fa9fd4ffc90582091b8c6219f2054265f71e4ef
>>
>> OK thanks!
>
> Kishon, looks like your next branch is not getting merged into
> Linux next for some reason?

Greg merged it just now. So you should start seeing tomorrow.

Cheers
Kishon

Re: patch "phy: Add a driver for dm816x USB PHY" added to linux-phy tree

[Tony Lindgren]

* Kishon Vijay Abraham I <kishon@ti.com> [150410 05:19]:
> Hi Tony,
> 
> On Thursday 09 April 2015 11:52 PM, Tony Lindgren wrote:
> >* Tony Lindgren <tony@atomide.com> [150331 09:56]:
> >>* Kishon Vijay Abraham I <kishon@ti.com> [150331 09:37]:
> >>>Hi Tony,
> >>>
> >>>On Thursday 26 March 2015 09:34 PM, Tony Lindgren wrote:
> >>>>* Matthijs van Duin <matthijsvanduin@gmail.com> [150326 00:02]:
> >>>>>On 26 March 2015 at 00:36, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> >>>>>>Let me know if you find any problems with this patch.
> >>>>>
> >>>>>I spotted a minor issue in drivers/phy/Kconfig:
> >>>>>
> >>>>>>+         Enable this for dm81xx USB to work.
> >>>>>
> >>>>>This should say dm816x instead.
> >>>>
> >>>>Yes that's correct, the phy on dm814x seems to be like on am335x,
> >>>>not like on dm816x. Kishon, let me know if you prefer a follow-up
> >>>>patch to fix this.
> >>>
> >>>No. I've fixed this in my tree
> >>>https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit
> >>>/?h=next&id=9fa9fd4ffc90582091b8c6219f2054265f71e4ef
> >>
> >>OK thanks!
> >
> >Kishon, looks like your next branch is not getting merged into
> >Linux next for some reason?
> 
> Greg merged it just now. So you should start seeing tomorrow.

OK thanks!

Tony