Re: [PATCH v3 4/4] libxl: add support for vscsi

From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v3 4/4] libxl: add support for vscsi
Date: Fri, 27 Mar 2015 08:38:34 +0100	[thread overview]
Message-ID: <20150327073834.GA12756@aepfle.de> (raw)
In-Reply-To: <1427377615.13935.59.camel@citrix.com>

On Thu, Mar 26, Ian Campbell wrote:

> On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote:
> > On Fri, Mar 13, Ian Campbell wrote:
> > > Also, should this be a defbool or not?
> > This is a good idea. I remmeber xend had code to make sure that all
> > devices within a vhost had the same value for "feature-host". I think
> > the intention was that whole physical hosts are passed to a domU. A
> > defbool makes it easier to preserve the initial value based on the first
> > config item.
> 
> In which case it sounds to me like this flag should be at a per-vhost
> level and not at a per device level.

Its per vhost already, "libxl_device_vscsi" refers to the virtual scsi
host, and "libxl_vscsi_dev" refers to a device connected to that host.
Perhaps the latter needs a better name to make the difference more
obvious.

Olaf