All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] yaml-cpp: requires boost
@ 2015-03-28 19:34 Fabio Porcedda
  2015-03-28 23:54 ` Yann E. MORIN
  2015-03-29 11:44 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Porcedda @ 2015-03-28 19:34 UTC (permalink / raw)
  To: buildroot

The Boost C++ library is already selected in the Config.in but it was
missing in the yaml-cpp.mk file.

Fix build failure:
CMake Error at /home/tetsuya/buildroot/br/output/host/usr/share/cmake-3.1/Modules/FindBoost.cmake:1182 (message):
  Unable to find the requested Boost libraries.
<snip>
make: *** [/home/tetsuya/buildroot/br/output/build/yaml-cpp-0.5.1/.stamp_configured] Error 1

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/yaml-cpp/yaml-cpp.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/yaml-cpp/yaml-cpp.mk b/package/yaml-cpp/yaml-cpp.mk
index 5ebdb23..afc70bd 100644
--- a/package/yaml-cpp/yaml-cpp.mk
+++ b/package/yaml-cpp/yaml-cpp.mk
@@ -10,4 +10,6 @@ YAML_CPP_INSTALL_STAGING = YES
 YAML_CPP_LICENSE = MIT
 YAML_CPP_LICENSE_FILES = license.txt
 
+YAML_CPP_DEPENDENCIES = boost
+
 $(eval $(cmake-package))
-- 
2.3.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] yaml-cpp: requires boost
  2015-03-28 19:34 [Buildroot] [PATCH] yaml-cpp: requires boost Fabio Porcedda
@ 2015-03-28 23:54 ` Yann E. MORIN
  2015-03-29 11:44 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2015-03-28 23:54 UTC (permalink / raw)
  To: buildroot

Fabio, All,

On 2015-03-28 20:34 +0100, Fabio Porcedda spake thusly:
> The Boost C++ library is already selected in the Config.in but it was
> missing in the yaml-cpp.mk file.
> 
> Fix build failure:
> CMake Error at /home/tetsuya/buildroot/br/output/host/usr/share/cmake-3.1/Modules/FindBoost.cmake:1182 (message):
>   Unable to find the requested Boost libraries.
> <snip>
> make: *** [/home/tetsuya/buildroot/br/output/build/yaml-cpp-0.5.1/.stamp_configured] Error 1
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Good catch!

Shame on me for giving my reviewed-by tag back then as I missed that
dependency... :-(

Hopefully I'm not missing anything now:

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Thanks! :-)

Regards,
Yann E. MORIN.

> ---
>  package/yaml-cpp/yaml-cpp.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/yaml-cpp/yaml-cpp.mk b/package/yaml-cpp/yaml-cpp.mk
> index 5ebdb23..afc70bd 100644
> --- a/package/yaml-cpp/yaml-cpp.mk
> +++ b/package/yaml-cpp/yaml-cpp.mk
> @@ -10,4 +10,6 @@ YAML_CPP_INSTALL_STAGING = YES
>  YAML_CPP_LICENSE = MIT
>  YAML_CPP_LICENSE_FILES = license.txt
>  
> +YAML_CPP_DEPENDENCIES = boost
> +
>  $(eval $(cmake-package))
> -- 
> 2.3.4
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] yaml-cpp: requires boost
  2015-03-28 19:34 [Buildroot] [PATCH] yaml-cpp: requires boost Fabio Porcedda
  2015-03-28 23:54 ` Yann E. MORIN
@ 2015-03-29 11:44 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-03-29 11:44 UTC (permalink / raw)
  To: buildroot

Dear Fabio Porcedda,

On Sat, 28 Mar 2015 20:34:32 +0100, Fabio Porcedda wrote:
> The Boost C++ library is already selected in the Config.in but it was
> missing in the yaml-cpp.mk file.
> 
> Fix build failure:
> CMake Error at /home/tetsuya/buildroot/br/output/host/usr/share/cmake-3.1/Modules/FindBoost.cmake:1182 (message):
>   Unable to find the requested Boost libraries.
> <snip>
> make: *** [/home/tetsuya/buildroot/br/output/build/yaml-cpp-0.5.1/.stamp_configured] Error 1
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-29 11:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-28 19:34 [Buildroot] [PATCH] yaml-cpp: requires boost Fabio Porcedda
2015-03-28 23:54 ` Yann E. MORIN
2015-03-29 11:44 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.