All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH pciutils] pread.h: Remove support for libc5
@ 2015-03-29  8:59 Felix Janda
  2015-04-09 14:37 ` Martin Mares
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Janda @ 2015-03-29  8:59 UTC (permalink / raw)
  To: linux-pci

The support code for libc5 breaks building on linux i386 with
other libcs that don't define __GLIBC__.
---
 lib/pread.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/lib/pread.h b/lib/pread.h
index 0e64326..3db90e3 100644
--- a/lib/pread.h
+++ b/lib/pread.h
@@ -30,15 +30,6 @@ static int pread(unsigned int fd, void *buf, size_t size, loff_t where)
 static int pwrite(unsigned int fd, void *buf, size_t size, loff_t where)
 { return syscall(SYS_pwrite, fd, buf, size, where); }
 
-#elif defined(i386)
-/* old libc on i386 -> call syscalls directly the old way */
-#include <asm/unistd.h>
-static _syscall5(int, pread, unsigned int, fd, void *, buf, size_t, size, u32, where_lo, u32, where_hi);
-static _syscall5(int, pwrite, unsigned int, fd, void *, buf, size_t, size, u32, where_lo, u32, where_hi);
-static int do_read(struct pci_dev *d UNUSED, int fd, void *buf, size_t size, int where) { return pread(fd, buf, size, where, 0); }
-static int do_write(struct pci_dev *d UNUSED, int fd, void *buf, size_t size, int where) { return pwrite(fd, buf, size, where, 0); }
-#define PCI_HAVE_DO_READ
-
 #else
 /* In all other cases we use lseek/read/write instead to be safe */
 #define make_rw_glue(op) \
-- 
2.0.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH pciutils] pread.h: Remove support for libc5
  2015-03-29  8:59 [PATCH pciutils] pread.h: Remove support for libc5 Felix Janda
@ 2015-04-09 14:37 ` Martin Mares
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Mares @ 2015-04-09 14:37 UTC (permalink / raw)
  To: Felix Janda; +Cc: linux-pci

Hi!

> The support code for libc5 breaks building on linux i386 with
> other libcs that don't define __GLIBC__.

Thanks, applied.  I will release pciutils-3.3.1 in a couple of minutes.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@ucw.cz>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
Immanuel doesn't pun, he Kant.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-09 14:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-29  8:59 [PATCH pciutils] pread.h: Remove support for libc5 Felix Janda
2015-04-09 14:37 ` Martin Mares

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.