From: Michael Turquette <mturquette@linaro.org>
To: Sascha Hauer <s.hauer@pengutronix.de>,
"Stephen Boyd" <sboyd@codeaurora.org>
Cc: "YH Chen" <yh.chen@mediatek.com>,
linux-kernel@vger.kernel.org,
"Henry Chen" <henryc.chen@mediatek.com>,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Yingjoe Chen" <Yingjoe.Chen@mediatek.com>,
"Eddie Huang" <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
"James Liao" <jamesjj.liao@mediatek.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: Re: [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs.
Date: Mon, 30 Mar 2015 18:21:18 -0700 [thread overview]
Message-ID: <20150331012118.7930.69028@quantum> (raw)
In-Reply-To: <1427737245-4064-3-git-send-email-s.hauer@pengutronix.de>
Quoting Sascha Hauer (2015-03-30 10:40:41)
> +static void mtk_pll_set_rate_regs(struct clk_hw *hw, u32 pcw,
> + int postdiv)
> +{
> + struct mtk_clk_pll *pll = to_mtk_clk_pll(hw);
> + u32 con1, pd, val;
> + int pll_en;
> +
> + /* set postdiv */
> + pd = readl(pll->pd_addr);
> + pd &= ~(0x7 << pll->data->pd_shift);
Hi Sascha,
I found a couple of magic numbers in here. Can we replace these with
some descriptive constant?
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Michael Turquette <mturquette@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: YH Chen <yh.chen@mediatek.com>,
linux-kernel@vger.kernel.org,
Henry Chen <henryc.chen@mediatek.com>,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
Matthias Brugger <matthias.bgg@gmail.com>,
Yingjoe Chen <Yingjoe.Chen@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
James Liao <jamesjj.liao@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs.
Date: Mon, 30 Mar 2015 18:21:18 -0700 [thread overview]
Message-ID: <20150331012118.7930.69028@quantum> (raw)
In-Reply-To: <1427737245-4064-3-git-send-email-s.hauer@pengutronix.de>
Quoting Sascha Hauer (2015-03-30 10:40:41)
> +static void mtk_pll_set_rate_regs(struct clk_hw *hw, u32 pcw,
> + int postdiv)
> +{
> + struct mtk_clk_pll *pll = to_mtk_clk_pll(hw);
> + u32 con1, pd, val;
> + int pll_en;
> +
> + /* set postdiv */
> + pd = readl(pll->pd_addr);
> + pd &= ~(0x7 << pll->data->pd_shift);
Hi Sascha,
I found a couple of magic numbers in here. Can we replace these with
some descriptive constant?
Regards,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Michael Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs.
Date: Mon, 30 Mar 2015 18:21:18 -0700 [thread overview]
Message-ID: <20150331012118.7930.69028@quantum> (raw)
In-Reply-To: <1427737245-4064-3-git-send-email-s.hauer@pengutronix.de>
Quoting Sascha Hauer (2015-03-30 10:40:41)
> +static void mtk_pll_set_rate_regs(struct clk_hw *hw, u32 pcw,
> + int postdiv)
> +{
> + struct mtk_clk_pll *pll = to_mtk_clk_pll(hw);
> + u32 con1, pd, val;
> + int pll_en;
> +
> + /* set postdiv */
> + pd = readl(pll->pd_addr);
> + pd &= ~(0x7 << pll->data->pd_shift);
Hi Sascha,
I found a couple of magic numbers in here. Can we replace these with
some descriptive constant?
Regards,
Mike
next prev parent reply other threads:[~2015-03-31 1:21 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 17:40 [PATCH v10]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-30 17:40 ` [PATCH 1/6] clk: make strings in parent name arrays const Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-30 17:55 ` Joe Perches
2015-03-30 17:55 ` Joe Perches
2015-03-30 18:16 ` Sascha Hauer
2015-03-30 18:16 ` Sascha Hauer
2015-03-30 18:20 ` Joe Perches
2015-03-30 18:20 ` Joe Perches
2015-03-30 18:32 ` Sascha Hauer
2015-03-30 18:32 ` Sascha Hauer
2015-03-30 17:40 ` [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-30 17:55 ` Joe Perches
2015-03-30 17:55 ` Joe Perches
2015-03-30 18:31 ` Sascha Hauer
2015-03-30 18:31 ` Sascha Hauer
2015-03-31 1:21 ` Michael Turquette [this message]
2015-03-31 1:21 ` Michael Turquette
2015-03-31 1:21 ` Michael Turquette
2015-03-30 17:40 ` [PATCH 3/6] clk: mediatek: Add reset controller support Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-31 8:00 ` Philipp Zabel
2015-03-31 8:00 ` Philipp Zabel
2015-03-30 17:40 ` [PATCH 4/6] clk: mediatek: Add basic clocks for Mediatek MT8135 Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-30 17:40 ` [PATCH 5/6] clk: mediatek: Add basic clocks for Mediatek MT8173 Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-04-13 11:36 ` Matthias Brugger
2015-04-13 11:36 ` Matthias Brugger
2015-04-13 11:36 ` Matthias Brugger
2015-03-30 17:40 ` [PATCH 6/6] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock/reset controllers Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-30 17:40 ` Sascha Hauer
2015-03-31 1:33 ` [PATCH v10]: clk: Add common clock support for Mediatek MT8135 and MT8173 Michael Turquette
2015-03-31 1:33 ` Michael Turquette
-- strict thread matches above, loose matches on Subject: below --
2015-04-23 8:35 [PATCH v12] " Sascha Hauer
2015-04-23 8:35 ` [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-04-23 8:35 ` Sascha Hauer
2015-03-31 18:16 [PATCH v11]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-31 18:16 ` [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-03-31 18:16 ` Sascha Hauer
2015-04-09 17:03 ` Matthias Brugger
2015-04-09 17:03 ` Matthias Brugger
2015-04-09 17:03 ` Matthias Brugger
2015-03-27 9:18 [PATCH v9]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-27 9:18 ` [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-03-27 9:18 ` Sascha Hauer
2015-03-27 9:18 ` Sascha Hauer
2015-03-19 8:42 [PATCH v8]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-19 8:42 ` [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-03-19 8:42 ` Sascha Hauer
2015-03-19 8:42 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331012118.7930.69028@quantum \
--to=mturquette@linaro.org \
--cc=Yingjoe.Chen@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@codeaurora.org \
--cc=yh.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.