From: Alessandro Zummo <a.zummo@towertech.it>
To: Joe Perches <joe@perches.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log
Date: Wed, 1 Apr 2015 09:05:20 +0200 [thread overview]
Message-ID: <20150401090520.559ead39@linux.lan.towertech.it> (raw)
In-Reply-To: <1427858308.18175.30.camel@perches.com>
On Tue, 31 Mar 2015 20:18:28 -0700
Joe Perches <joe@perches.com> wrote:
> Neither __func__ or __FILE__ is really useful here.
> The message is already specific enough without it.
>
> If anything, it'd probably be better to add
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Seems reasonable given that pr_fmt is widely
used elsewhere.
I don't like too much the need to have one define for
each file, but it's the way it works :-/
--
Best regards,
Alessandro Zummo - CEO,
Tower Technologies - Torino, Italy
http://www.towertech.it
WARNING: multiple messages have this Message-ID (diff)
From: Alessandro Zummo <a.zummo@towertech.it>
To: Joe Perches <joe@perches.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log
Date: Wed, 1 Apr 2015 09:05:20 +0200 [thread overview]
Message-ID: <20150401090520.559ead39@linux.lan.towertech.it> (raw)
In-Reply-To: <1427858308.18175.30.camel@perches.com>
On Tue, 31 Mar 2015 20:18:28 -0700
Joe Perches <joe@perches.com> wrote:
> Neither __func__ or __FILE__ is really useful here.
> The message is already specific enough without it.
>
> If anything, it'd probably be better to add
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Seems reasonable given that pr_fmt is widely
used elsewhere.
I don't like too much the need to have one define for
each file, but it's the way it works :-/
--
Best regards,
Alessandro Zummo - CEO,
Tower Technologies - Torino, Italy
http://www.towertech.it
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-04-01 7:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 21:09 [PATCH 1/3] rtc: initialize rtc name early Aaro Koskinen
2015-03-28 21:09 ` [rtc-linux] " Aaro Koskinen
2015-03-28 21:09 ` [PATCH 2/3] rtc: __rtc_read_time: reduce log level Aaro Koskinen
2015-03-28 21:09 ` [rtc-linux] " Aaro Koskinen
2015-04-01 3:21 ` Alexandre Belloni
2015-04-01 3:21 ` [rtc-linux] " Alexandre Belloni
2015-04-01 3:25 ` Joe Perches
2015-04-01 3:25 ` [rtc-linux] " Joe Perches
2015-04-01 9:55 ` Alexandre Belloni
2015-04-01 9:55 ` [rtc-linux] " Alexandre Belloni
2015-03-28 21:09 ` [PATCH 3/3] rtc: hctosys: use function name in the error log Aaro Koskinen
2015-03-28 21:09 ` [rtc-linux] " Aaro Koskinen
2015-04-01 3:01 ` Alexandre Belloni
2015-04-01 3:01 ` [rtc-linux] " Alexandre Belloni
2015-04-01 3:18 ` Joe Perches
2015-04-01 3:18 ` [rtc-linux] " Joe Perches
2015-04-01 7:05 ` Alessandro Zummo [this message]
2015-04-01 7:05 ` Alessandro Zummo
2015-04-01 7:15 ` Joe Perches
2015-04-01 7:15 ` Joe Perches
2015-04-01 10:42 ` Alexandre Belloni
2015-04-01 10:42 ` [rtc-linux] " Alexandre Belloni
2015-04-01 16:12 ` [PATCH] rtc: Use more standard kernel logging styles Joe Perches
2015-04-01 16:12 ` [rtc-linux] " Joe Perches
2015-04-02 7:47 ` Krzysztof Kozlowski
2015-04-02 7:47 ` Krzysztof Kozlowski
2015-04-05 10:17 ` Alexandre Belloni
2015-04-05 10:17 ` [rtc-linux] " Alexandre Belloni
2015-04-01 3:01 ` [PATCH 1/3] rtc: initialize rtc name early Alexandre Belloni
2015-04-01 3:01 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401090520.559ead39@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=aaro.koskinen@iki.fi \
--cc=alexandre.belloni@free-electrons.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.