[PATCH v3 1/4] Staging: sm750fb: Fix C99 Comments

[PATCH v3 1/4] Staging: sm750fb: Fix C99 Comments

[Amitoj Kaur Chawla]

Fixed C99 Comments to C89 comment style and removed C99 comments
performing printing. Problem found using checkpatch.pl
ERROR: do not use C99 // comments

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes made in v3:
        -Fixed commit message

 drivers/staging/sm750fb/ddk750_chip.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 02f9326..233436d 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void)
 	char physicalRev;
 	logical_chip_type_t chip;
 
-	physicalID = devId750;//either 0x718 or 0x750
+	physicalID = devId750; /* either 0x718 or 0x750 */
 	physicalRev = revId750;
 
 	if (physicalID == 0x718)
@@ -264,7 +264,7 @@ int ddk750_initHw(initchip_param_t * pInitParam)
 
 	unsigned int ulReg;
 #if 0
-	//move the code to map regiter function.
+	/* move the code to map regiter function. */
 	if(getChipType() == SM718){
 		/* turn on big endian bit*/
 		ulReg = PEEK32(0x74);
@@ -501,7 +501,6 @@ unsigned int calcPllValue(unsigned int request_orig,pll_value_t *pll)
 		}
 	}
 
-	//printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);
 	return ret;
 }
 
@@ -601,11 +600,7 @@ pll_value_t *pPLL           /* Structure to hold the value to be set in PLL */
 	ulRequestClk *= 1000;
 	pPLL->inputFreq = DEFAULT_INPUT_CLOCK; /* Default reference clock */
 
-    /* Output debug information */
-	//DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Requested Frequency = %d\n", ulRequestClk));
-	//DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Input CLK = %dHz, M=%d, N=%d, OD=%d, POD=%d\n", pPLL->inputFreq, pPLL->M, pPLL->N, pPLL->OD, pPLL->POD));
-
-    /* Return actual frequency that the PLL can set */
+	/* Return actual frequency that the PLL can set */
 	ret = calcPLL(pPLL);
 	return ret;
 }
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v3 1/4] Staging: sm750fb: Fix C99 Comments

[Julia Lawall]

On Sun, 29 Mar 2015, Amitoj Kaur Chawla wrote:

> Fixed C99 Comments to C89 comment style and removed C99 comments
> performing printing. Problem found using checkpatch.pl
> ERROR: do not use C99 // comments

Better, thanks.

julia

> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes made in v3:
>         -Fixed commit message
>
>  drivers/staging/sm750fb/ddk750_chip.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 02f9326..233436d 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void)
>  	char physicalRev;
>  	logical_chip_type_t chip;
>
> -	physicalID = devId750;//either 0x718 or 0x750
> +	physicalID = devId750; /* either 0x718 or 0x750 */
>  	physicalRev = revId750;
>
>  	if (physicalID == 0x718)
> @@ -264,7 +264,7 @@ int ddk750_initHw(initchip_param_t * pInitParam)
>
>  	unsigned int ulReg;
>  #if 0
> -	//move the code to map regiter function.
> +	/* move the code to map regiter function. */
>  	if(getChipType() == SM718){
>  		/* turn on big endian bit*/
>  		ulReg = PEEK32(0x74);
> @@ -501,7 +501,6 @@ unsigned int calcPllValue(unsigned int request_orig,pll_value_t *pll)
>  		}
>  	}
>
> -	//printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);
>  	return ret;
>  }
>
> @@ -601,11 +600,7 @@ pll_value_t *pPLL           /* Structure to hold the value to be set in PLL */
>  	ulRequestClk *= 1000;
>  	pPLL->inputFreq = DEFAULT_INPUT_CLOCK; /* Default reference clock */
>
> -    /* Output debug information */
> -	//DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Requested Frequency = %d\n", ulRequestClk));
> -	//DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Input CLK = %dHz, M=%d, N=%d, OD=%d, POD=%d\n", pPLL->inputFreq, pPLL->M, pPLL->N, pPLL->OD, pPLL->POD));
> -
> -    /* Return actual frequency that the PLL can set */
> +	/* Return actual frequency that the PLL can set */
>  	ret = calcPLL(pPLL);
>  	return ret;
>  }
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150329103020.GA21007%40amitoj-Inspiron-3542.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 1/4] Staging: sm750fb: Fix C99 Comments

[Greg KH]

On Sun, Mar 29, 2015 at 04:00:20PM +0530, Amitoj Kaur Chawla wrote:
> Fixed C99 Comments to C89 comment style and removed C99 comments
> performing printing. Problem found using checkpatch.pl
> ERROR: do not use C99 // comments
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes made in v3:
>         -Fixed commit message

Nothing changed in v2?

I need the whole series resent, I have a mess of patches in my inbox, no
way to tell which ones to apply, so my "default" way to solve that is to
delete them all :)

Please resend this whole series, properly threaded, so that my email
client makes it obvious what patches to apply, and in what order.

thanks,

greg k-h