* [LTP] [PATCH] syscalls/fanotify02: Fixup testcase
@ 2015-04-02 7:14 Jan Kara
2015-04-02 9:45 ` Cyril Hrubis
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kara @ 2015-04-02 7:14 UTC (permalink / raw)
To: ltp-list; +Cc: Jan Kara
The tescase incorrectly assumed that events will be generated for a
directory when FAN_ONDIR was not specified. That used to be the case due
to a kernel bug but it's not the case anymore.
Signed-off-by: Jan Kara <jack@suse.cz>
---
testcases/kernel/syscalls/fanotify/fanotify02.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/syscalls/fanotify/fanotify02.c b/testcases/kernel/syscalls/fanotify/fanotify02.c
index 35e73b156d2f..c9aeca183c02 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify02.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify02.c
@@ -78,12 +78,13 @@ int main(int ac, char **av)
if (fanotify_mark(fd_notify, FAN_MARK_ADD, FAN_ACCESS |
FAN_MODIFY | FAN_CLOSE | FAN_OPEN |
- FAN_EVENT_ON_CHILD, AT_FDCWD, ".") < 0) {
+ FAN_EVENT_ON_CHILD | FAN_ONDIR, AT_FDCWD,
+ ".") < 0) {
tst_brkm(TBROK | TERRNO, cleanup,
"fanotify_mark (%d, FAN_MARK_ADD, FAN_ACCESS | "
"FAN_MODIFY | FAN_CLOSE | FAN_OPEN | "
- "FAN_EVENT_ON_CHILD, AT_FDCWD, '.') failed",
- fd_notify);
+ "FAN_EVENT_ON_CHILD | FAN_ONDIR, AT_FDCWD, '.') "
+ "failed", fd_notify);
}
/*
--
2.1.4
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [LTP] [PATCH] syscalls/fanotify02: Fixup testcase
2015-04-02 7:14 [LTP] [PATCH] syscalls/fanotify02: Fixup testcase Jan Kara
@ 2015-04-02 9:45 ` Cyril Hrubis
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2015-04-02 9:45 UTC (permalink / raw)
To: Jan Kara; +Cc: ltp-list
Hi!
> The tescase incorrectly assumed that events will be generated for a
> directory when FAN_ONDIR was not specified. That used to be the case due
> to a kernel bug but it's not the case anymore.
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-02 9:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-02 7:14 [LTP] [PATCH] syscalls/fanotify02: Fixup testcase Jan Kara
2015-04-02 9:45 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.