All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhelgaas@google.com
Cc: yinghai@kernel.org, david.ahern@oracle.com,
	linux-pci@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: Introduce pci_bus_addr_t
Date: Fri, 03 Apr 2015 15:05:58 -0400 (EDT)	[thread overview]
Message-ID: <20150403.150558.188543237134528987.davem@davemloft.net> (raw)
In-Reply-To: <20150403185939.GC10892@google.com>

From: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri, 3 Apr 2015 13:59:39 -0500

> On Tue, Mar 31, 2015 at 07:57:47PM -0700, Yinghai Lu wrote:
>> David Ahern found commit d63e2e1f3df9 ("sparc/PCI: Clip bridge windows
>> to fit in upstream windows") broke booting on sparc/T5-8.
>> 
>> In the boot log, there is
>>   pci 0000:06:00.0: reg 0x184: can't handle BAR above 4GB (bus address
>>   0x110204000)
>> but that only could happen when dma_addr_t is 32-bit.
>> 
>> According to David Miller, all DMA occurs behind an IOMMU and these
>> IOMMUs only support 32-bit addressing, therefore dma_addr_t is
>> 32-bit on sparc64.
>> 
>> Let's introduce pci_bus_addr_t instead of using dma_addr_t,
>> and pci_bus_addr_t will be 64-bit on 64-bit platform or X86_PAE.
> 
> I propose the following doc updates (I can just fold them into this patch
> if you approve):

No objection.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: bhelgaas@google.com
Cc: yinghai@kernel.org, david.ahern@oracle.com,
	linux-pci@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: Introduce pci_bus_addr_t
Date: Fri, 03 Apr 2015 19:05:58 +0000	[thread overview]
Message-ID: <20150403.150558.188543237134528987.davem@davemloft.net> (raw)
In-Reply-To: <20150403185939.GC10892@google.com>

From: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri, 3 Apr 2015 13:59:39 -0500

> On Tue, Mar 31, 2015 at 07:57:47PM -0700, Yinghai Lu wrote:
>> David Ahern found commit d63e2e1f3df9 ("sparc/PCI: Clip bridge windows
>> to fit in upstream windows") broke booting on sparc/T5-8.
>> 
>> In the boot log, there is
>>   pci 0000:06:00.0: reg 0x184: can't handle BAR above 4GB (bus address
>>   0x110204000)
>> but that only could happen when dma_addr_t is 32-bit.
>> 
>> According to David Miller, all DMA occurs behind an IOMMU and these
>> IOMMUs only support 32-bit addressing, therefore dma_addr_t is
>> 32-bit on sparc64.
>> 
>> Let's introduce pci_bus_addr_t instead of using dma_addr_t,
>> and pci_bus_addr_t will be 64-bit on 64-bit platform or X86_PAE.
> 
> I propose the following doc updates (I can just fold them into this patch
> if you approve):

No objection.

  reply	other threads:[~2015-04-03 19:06 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  2:57 [PATCH 0/3] PCI/sparc: Fix booting with T5-8 Yinghai Lu
2015-04-01  2:57 ` Yinghai Lu
2015-04-01  2:57 ` [PATCH 1/3] PCI: Introduce pci_bus_addr_t Yinghai Lu
2015-04-01  2:57   ` Yinghai Lu
2015-04-03 18:59   ` Bjorn Helgaas
2015-04-03 18:59     ` Bjorn Helgaas
2015-04-03 19:05     ` David Miller [this message]
2015-04-03 19:05       ` David Miller
2015-04-04  3:40     ` Yinghai Lu
2015-04-04  3:40       ` Yinghai Lu
2015-04-03 19:32   ` Bjorn Helgaas
2015-04-03 19:32     ` Bjorn Helgaas
2015-04-03 20:52     ` Bjorn Helgaas
2015-04-03 20:52       ` Bjorn Helgaas
2015-04-03 20:52       ` Bjorn Helgaas
2015-04-03 20:52       ` Bjorn Helgaas
2015-04-04  3:34       ` Yinghai Lu
2015-04-04  3:34         ` Yinghai Lu
2015-04-04  3:34         ` Yinghai Lu
2015-04-04  3:34         ` Yinghai Lu
2015-04-04  3:34         ` Yinghai Lu
2015-04-04 12:46         ` Bjorn Helgaas
2015-04-04 12:46           ` Bjorn Helgaas
2015-04-04 12:46           ` Bjorn Helgaas
2015-04-04 12:46           ` Bjorn Helgaas
2015-04-04 12:46           ` Bjorn Helgaas
2015-04-04 19:48           ` Rob Herring
2015-04-04 19:48             ` Rob Herring
2015-04-04 19:48             ` Rob Herring
2015-04-04 19:48             ` Rob Herring
2015-04-04 19:48             ` Rob Herring
2015-04-05  3:25             ` Bjorn Helgaas
2015-04-05  3:25               ` Bjorn Helgaas
2015-04-05  3:25               ` Bjorn Helgaas
2015-04-05  3:25               ` Bjorn Helgaas
2015-04-05  3:25               ` Bjorn Helgaas
2015-04-06 13:05               ` Rob Herring
2015-04-06 13:05                 ` Rob Herring
2015-04-06 13:05                 ` Rob Herring
2015-04-06 13:05                 ` Rob Herring
2015-04-06 13:05                 ` Rob Herring
2015-04-01  2:57 ` [PATCH 2/3] sparc/PCI: Add mem64 resource parsing for root bus Yinghai Lu
2015-04-01  2:57   ` Yinghai Lu
2015-04-03 20:46   ` Bjorn Helgaas
2015-04-03 20:46     ` Bjorn Helgaas
2015-04-03 20:46     ` Bjorn Helgaas
2015-04-01  2:57 ` [PATCH 3/3] PCI: Set pref for mem64 resource of pcie device Yinghai Lu
2015-04-01  2:57   ` Yinghai Lu
2015-04-06 22:06   ` Bjorn Helgaas
2015-04-06 22:06     ` Bjorn Helgaas
2015-04-06 22:35     ` Yinghai Lu
2015-04-06 22:35       ` Yinghai Lu
2015-04-06 22:49       ` Bjorn Helgaas
2015-04-06 22:49         ` Bjorn Helgaas
2015-04-07  1:13         ` Yinghai Lu
2015-04-07  1:13           ` Yinghai Lu
2015-04-07  3:43           ` Bjorn Helgaas
2015-04-07  3:43             ` Bjorn Helgaas
2015-04-07  5:23             ` Yinghai Lu
2015-04-07  5:23               ` Yinghai Lu
2015-04-07 12:18               ` Bjorn Helgaas
2015-04-07 12:18                 ` Bjorn Helgaas
2015-04-07  0:35     ` David Miller
2015-04-07  0:35       ` David Miller
2015-04-07 16:48       ` Bjorn Helgaas
2015-04-07 16:48         ` Bjorn Helgaas
2015-04-08 15:47         ` Bjorn Helgaas
2015-04-08 15:47           ` Bjorn Helgaas
2015-04-08 16:08           ` David Miller
2015-04-08 16:08             ` David Miller
2015-04-08 21:12           ` Benjamin Herrenschmidt
2015-04-08 21:12             ` Benjamin Herrenschmidt
2015-04-09  0:06             ` Yinghai Lu
2015-04-09  0:06               ` Yinghai Lu
2015-04-09  3:17               ` Benjamin Herrenschmidt
2015-04-09  3:17                 ` Benjamin Herrenschmidt
2015-04-09  4:11                 ` Yinghai Lu
2015-04-09  4:11                   ` Yinghai Lu
2015-04-09  8:56                   ` Benjamin Herrenschmidt
2015-04-09  8:56                     ` Benjamin Herrenschmidt
2015-04-09  4:26                 ` Bjorn Helgaas
2015-04-09  4:26                   ` Bjorn Helgaas
2015-04-09  8:54                   ` Benjamin Herrenschmidt
2015-04-09  8:54                     ` Benjamin Herrenschmidt
2015-04-09 18:31                     ` Yinghai Lu
2015-04-09 18:31                       ` Yinghai Lu
2015-04-09 23:31                       ` Benjamin Herrenschmidt
2015-04-09 23:31                         ` Benjamin Herrenschmidt
2015-04-10  4:13                         ` Yinghai Lu
2015-04-10  4:13                           ` Yinghai Lu
2015-04-02 20:37 ` [PATCH 0/3] PCI/sparc: Fix booting with T5-8 David Miller
2015-04-02 20:37   ` David Miller
2015-04-02 22:07   ` Yinghai Lu
2015-04-02 22:07     ` Yinghai Lu
2015-04-02 22:13     ` Bjorn Helgaas
2015-04-02 22:13       ` Bjorn Helgaas
2015-04-03  0:42     ` David Miller
2015-04-03  0:42       ` David Miller
2015-05-16 15:25 ` Bjorn Helgaas
2015-05-16 15:25   ` Bjorn Helgaas
2015-05-16 15:28   ` Bjorn Helgaas
2015-05-16 15:28     ` Bjorn Helgaas
2015-05-27 23:27     ` Yinghai Lu
2015-05-27 23:27       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150403.150558.188543237134528987.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhelgaas@google.com \
    --cc=david.ahern@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.