* [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation
@ 2015-04-05 1:53 ` Amitoj Kaur Chawla
0 siblings, 0 replies; 6+ messages in thread
From: Amitoj Kaur Chawla @ 2015-04-05 1:41 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
Removes extra parentheses around bitwise right shift operation.
The issue was detected using the following coccinelle script.
@@
expression e, e1;
constant c;
@@
e =
-(e1
+e1
<<
-c);
+c;
@@
identifier i;
constant c;
type t;
expression e;
@@
t i =
-(e
+e
<<
-c);
+c;
@@
expression e, e1;
identifier f;
constant c;
@@
e1 = f(...,
-(e
+e
<<
-c)
+c
,...);
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 4074375..626b841 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -737,7 +737,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
output->paths = sm750_crt;
crtc->channel = sm750_secondary;
/* not consider of padding stuffs for oScreen,need fix*/
- crtc->oScreen = (share->vidmem_size >> 1);
+ crtc->oScreen = share->vidmem_size >> 1;
crtc->vScreen = share->pvMem + crtc->oScreen;
}
break;
@@ -751,7 +751,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
output->paths = sm750_crt;
crtc->channel = sm750_primary;
/* not consider of padding stuffs for oScreen,need fix*/
- crtc->oScreen = (share->vidmem_size >> 1);
+ crtc->oScreen = share->vidmem_size >> 1;
crtc->vScreen = share->pvMem + crtc->oScreen;
}
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation
@ 2015-04-05 1:53 ` Amitoj Kaur Chawla
0 siblings, 0 replies; 6+ messages in thread
From: Amitoj Kaur Chawla @ 2015-04-05 1:53 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
Removes extra parentheses around bitwise right shift operation.
The issue was detected using the following coccinelle script.
@@
expression e, e1;
constant c;
@@
e -(e1
+e1
<<
-c);
+c;
@@
identifier i;
constant c;
type t;
expression e;
@@
t i -(e
+e
<<
-c);
+c;
@@
expression e, e1;
identifier f;
constant c;
@@
e1 = f(...,
-(e
+e
<<
-c)
+c
,...);
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 4074375..626b841 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -737,7 +737,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
output->paths = sm750_crt;
crtc->channel = sm750_secondary;
/* not consider of padding stuffs for oScreen,need fix*/
- crtc->oScreen = (share->vidmem_size >> 1);
+ crtc->oScreen = share->vidmem_size >> 1;
crtc->vScreen = share->pvMem + crtc->oScreen;
}
break;
@@ -751,7 +751,7 @@ static int sm750fb_set_drv(struct lynxfb_par * par)
output->paths = sm750_crt;
crtc->channel = sm750_primary;
/* not consider of padding stuffs for oScreen,need fix*/
- crtc->oScreen = (share->vidmem_size >> 1);
+ crtc->oScreen = share->vidmem_size >> 1;
crtc->vScreen = share->pvMem + crtc->oScreen;
}
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation
2015-04-05 1:53 ` Amitoj Kaur Chawla
@ 2015-04-06 9:30 ` Sudip Mukherjee
-1 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2015-04-06 9:18 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
On Sun, Apr 05, 2015 at 07:11:47AM +0530, Amitoj Kaur Chawla wrote:
> Removes extra parentheses around bitwise right shift operation.
this is not applying. please work against staging-testing.
regards
sudip
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation
@ 2015-04-06 9:30 ` Sudip Mukherjee
0 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2015-04-06 9:30 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
On Sun, Apr 05, 2015 at 07:11:47AM +0530, Amitoj Kaur Chawla wrote:
> Removes extra parentheses around bitwise right shift operation.
this is not applying. please work against staging-testing.
regards
sudip
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation
2015-04-05 1:53 ` Amitoj Kaur Chawla
@ 2015-04-07 8:00 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-04-07 8:00 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
Some people like to put parenthesis around stuff. It's harmless here.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation
@ 2015-04-07 8:00 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-04-07 8:00 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
Some people like to put parenthesis around stuff. It's harmless here.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-07 8:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-05 1:41 [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation Amitoj Kaur Chawla
2015-04-05 1:53 ` Amitoj Kaur Chawla
2015-04-06 9:18 ` Sudip Mukherjee
2015-04-06 9:30 ` Sudip Mukherjee
2015-04-07 8:00 ` Dan Carpenter
2015-04-07 8:00 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.