All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] btrfs-progs: Doc: Add warning and note on btrfs-convert.
@ 2015-04-03  7:23 Qu Wenruo
  2015-04-07 15:44 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Qu Wenruo @ 2015-04-03  7:23 UTC (permalink / raw)
  To: linux-btrfs

Although btrfs-convert can rollback converted btrfs, it still has some
limitation to ensure rollback.

Add a warning on the limitations.

Also add a note for users who decides to go on with btrfs and don't need
the rollback ability.

Reported-by: Vytautas D <vytdau@gmail.com>
Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
v2:
  Add reporter tags
v3:
  Remove 'btrfs fi defrag' from commands that may disable rollback
  ability.
  Add a little explain to make the warning more reasonable.
v4:
  Some gramma changes. Thanks Ducan and Roman.
---
 Documentation/btrfs-convert.txt | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/btrfs-convert.txt b/Documentation/btrfs-convert.txt
index 8b3f05b..09510fa 100644
--- a/Documentation/btrfs-convert.txt
+++ b/Documentation/btrfs-convert.txt
@@ -15,6 +15,15 @@ DESCRIPTION
 and the original filesystem image is accessible as from separate subvolume
 named 'ext2_saved' as file image.
 
+WARNING: If one hopes to rollback to ext2/3/4, they should not execute
+*btrfs balance* command on converted btrfs, since it will change the extent
+layout and make *btrfs-convert* unable to rollback.
+
+NOTE: If one is satisfied with converted btrfs, and not longer wants to
+rollback to ext2/3/4, it is highly recommended to remove 'ext2_saved' subvolume
+and execute *btrfs filesystem defragment* and *btrfs balance* command on the
+converted btrfs.
+
 OPTIONS
 -------
 -d|--no-datasum::
-- 
2.3.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] btrfs-progs: Doc: Add warning and note on btrfs-convert.
  2015-04-03  7:23 [PATCH v4] btrfs-progs: Doc: Add warning and note on btrfs-convert Qu Wenruo
@ 2015-04-07 15:44 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2015-04-07 15:44 UTC (permalink / raw)
  To: Qu Wenruo; +Cc: linux-btrfs

On Fri, Apr 03, 2015 at 03:23:13PM +0800, Qu Wenruo wrote:
> Although btrfs-convert can rollback converted btrfs, it still has some
> limitation to ensure rollback.
> 
> Add a warning on the limitations.
> 
> Also add a note for users who decides to go on with btrfs and don't need
> the rollback ability.
> 
> Reported-by: Vytautas D <vytdau@gmail.com>
> Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-07 15:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-03  7:23 [PATCH v4] btrfs-progs: Doc: Add warning and note on btrfs-convert Qu Wenruo
2015-04-07 15:44 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.