All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sakari Ailus <sakari.ailus@iki.fi>, Andrew Morton <akpm@osdl.org>,
	pali.rohar@gmail.com, kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
	aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
	patrikbachan@gmail.com, galak@codeaurora.org,
	bcousson@baylibre.com, m.chehab@samsung.com,
	devicetree@vger.kernel.org, mchehab@osg.samsung.com,
	hverkuil@xs4all.nl
Subject: Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653
Date: Thu, 9 Apr 2015 11:10:17 +0200	[thread overview]
Message-ID: <20150409091017.GA4526@earth> (raw)
In-Reply-To: <20150409074238.GA22603@amd>

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi,

On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote:
> [...]
> +#include <linux/of_gpio.h>
> +#include <linux/gpio.h>
> [...]

This should probably be

#include <linux/of.h>
#include <linux/gpio/consumer.h>

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Cc: Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org>,
	Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
	pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	kernel list
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	aaro.koskinen-X3B1VOXEql0@public.gmane.org,
	ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
	hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org
Subject: Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653
Date: Thu, 9 Apr 2015 11:10:17 +0200	[thread overview]
Message-ID: <20150409091017.GA4526@earth> (raw)
In-Reply-To: <20150409074238.GA22603@amd>

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi,

On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote:
> [...]
> +#include <linux/of_gpio.h>
> +#include <linux/gpio.h>
> [...]

This should probably be

#include <linux/of.h>
#include <linux/gpio/consumer.h>

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653
Date: Thu, 9 Apr 2015 11:10:17 +0200	[thread overview]
Message-ID: <20150409091017.GA4526@earth> (raw)
In-Reply-To: <20150409074238.GA22603@amd>

Hi,

On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote:
> [...]
> +#include <linux/of_gpio.h>
> +#include <linux/gpio.h>
> [...]

This should probably be

#include <linux/of.h>
#include <linux/gpio/consumer.h>

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150409/db10f0dd/attachment.sig>

  reply	other threads:[~2015-04-09  9:10 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 14:38 [PATCHv3] media: i2c/adp1653: devicetree support for adp1653 Pavel Machek
2015-04-02 14:38 ` Pavel Machek
2015-04-02 16:14 ` Sakari Ailus
2015-04-02 16:14   ` Sakari Ailus
2015-04-02 16:14   ` Sakari Ailus
2015-04-02 20:30   ` Pavel Machek
2015-04-02 20:30     ` Pavel Machek
2015-04-02 20:30     ` Pavel Machek
2015-04-02 23:48     ` Sakari Ailus
2015-04-02 23:48       ` Sakari Ailus
2015-04-02 23:48       ` Sakari Ailus
2015-04-03  8:23       ` Pavel Machek
2015-04-03  8:23         ` Pavel Machek
2015-04-03 11:23         ` Sakari Ailus
2015-04-03 11:23           ` Sakari Ailus
2015-04-03 11:23           ` Sakari Ailus
2015-04-03 20:29           ` Pavel Machek
2015-04-03 20:29             ` Pavel Machek
2015-04-03 21:35             ` Sakari Ailus
2015-04-03 21:35               ` Sakari Ailus
2015-04-02 20:34 ` [PATCHv4] " Pavel Machek
2015-04-02 20:34   ` Pavel Machek
2015-04-02 20:34   ` Pavel Machek
2015-04-02 22:18   ` Javier Martinez Canillas
2015-04-02 22:18     ` Javier Martinez Canillas
2015-04-03  8:21     ` Pavel Machek
2015-04-03  8:21       ` Pavel Machek
2015-04-03  8:21       ` Pavel Machek
2015-04-03  8:49       ` Javier Martinez Canillas
2015-04-03  8:49         ` Javier Martinez Canillas
2015-04-03 14:22         ` Sebastian Reichel
2015-04-03 14:22           ` Sebastian Reichel
2015-04-03  8:33   ` [PATCHv5] " Pavel Machek
2015-04-03  8:33     ` Pavel Machek
2015-04-03 11:32     ` Sakari Ailus
2015-04-03 11:32       ` Sakari Ailus
2015-04-03 20:26       ` [PATCHv6] media: i2c/adp1653: Documentation for " Pavel Machek
2015-04-03 20:26         ` Pavel Machek
2015-04-03 21:36         ` Sakari Ailus
2015-04-03 21:36           ` Sakari Ailus
2015-04-04  7:43           ` Pavel Machek
2015-04-04  7:43             ` Pavel Machek
2015-04-04 10:24             ` Sakari Ailus
2015-04-04 10:24               ` Sakari Ailus
2015-04-04 10:24               ` Sakari Ailus
2015-04-04 17:11               ` Pavel Machek
2015-04-04 17:11                 ` Pavel Machek
2015-04-04 17:11                 ` Pavel Machek
2015-04-04 20:03                 ` Sakari Ailus
2015-04-04 20:03                   ` Sakari Ailus
2015-04-04 20:03                   ` Sakari Ailus
2015-04-09  7:42                   ` [PATCHv7] media: i2c/adp1653: Devicetree " Pavel Machek
2015-04-09  7:42                     ` Pavel Machek
2015-04-09  9:10                     ` Sebastian Reichel [this message]
2015-04-09  9:10                       ` Sebastian Reichel
2015-04-09  9:10                       ` Sebastian Reichel
2015-04-09 11:29                       ` Pavel Machek
2015-04-09 11:29                         ` Pavel Machek
2015-04-09 12:19                         ` Sebastian Reichel
2015-04-09 12:19                           ` Sebastian Reichel
2015-04-09 12:19                           ` Sebastian Reichel
2015-04-09 12:31                           ` [PATCHv7] media: i2c/adp1653: fix includes Pavel Machek
2015-04-09 12:31                             ` Pavel Machek
2015-04-09 12:31                             ` Pavel Machek
2015-04-09 12:43                             ` Javier Martinez Canillas
2015-04-09 12:43                               ` Javier Martinez Canillas
2015-04-09 12:59                               ` Pali Rohár
2015-04-09 12:59                                 ` Pali Rohár
2015-04-09 12:59                                 ` Pali Rohár
2015-04-13  8:32                                 ` Javier Martinez Canillas
2015-04-13  8:32                                   ` Javier Martinez Canillas
2015-04-09 21:47                     ` [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653 Sakari Ailus
2015-04-09 21:47                       ` Sakari Ailus
2015-04-13 13:00                       ` Pavel Machek
2015-04-13 13:00                         ` Pavel Machek
2015-04-13 13:00                         ` Pavel Machek
2015-04-03 21:39         ` [PATCHv6] media: i2c/adp1653: Documentation for devicetree " Sakari Ailus
2015-04-03 21:39           ` Sakari Ailus
2015-04-03 21:39           ` Sakari Ailus
2015-04-03 21:04       ` [PATCHv5] media: i2c/adp1653: " Pavel Machek
2015-04-03 21:04         ` Pavel Machek
2015-04-03 21:04         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409091017.GA4526@earth \
    --to=sre@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=akpm@osdl.org \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=hverkuil@xs4all.nl \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=mchehab@osg.samsung.com \
    --cc=pali.rohar@gmail.com \
    --cc=patrikbachan@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sakari.ailus@iki.fi \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.