[next:master 9498/10844] drivers/input/mouse/alps.c:1096:15: sparse: symbol 'alps_get_pkt_id_ss4_v2' was not declared. Should it be static?

[next:master 9498/10844] drivers/input/mouse/alps.c:1096:15: sparse: symbol 'alps_get_pkt_id_ss4_v2' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   ab738b3efaea11cf9f130c7fe9ebb7568e998fe6
commit: 3db5b9f782b50a309fe0fb89fb890f6b4f66d9ae [9498/10844] Input: ALPS - add support for SS4 touchpad devices
reproduce:
  # apt-get install sparse
  git checkout 3db5b9f782b50a309fe0fb89fb890f6b4f66d9ae
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/input/mouse/alps.c:1096:15: sparse: symbol 'alps_get_pkt_id_ss4_v2' was not declared. Should it be static?
>> drivers/input/mouse/alps.c:2343:5: sparse: symbol 'alps_update_device_area_ss4_v2' was not declared. Should it be static?
>> drivers/input/mouse/alps.c:2368:5: sparse: symbol 'alps_update_btn_info_ss4_v2' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH next] Input: alps_get_pkt_id_ss4_v2() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 alps.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index ad741c0..3ef93ff 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -1093,7 +1093,7 @@ static void alps_process_packet_v7(struct psmouse *psmouse)
 		alps_process_touchpad_packet_v7(psmouse);
 }
 
-unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
+static unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
 {
 	unsigned char pkt_id = SS4_PACKET_ID_IDLE;
 
@@ -2340,7 +2340,7 @@ static int alps_get_otp_values_ss4_v2(struct psmouse *psmouse,
 	return 0;
 }
 
-int alps_update_device_area_ss4_v2(unsigned char otp[][4],
+static int alps_update_device_area_ss4_v2(unsigned char otp[][4],
 				   struct alps_data *priv)
 {
 	int num_x_electrode;
@@ -2365,7 +2365,7 @@ int alps_update_device_area_ss4_v2(unsigned char otp[][4],
 	return 0;
 }
 
-int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
+static int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
 {
 
 	unsigned char is_btnless;

Re: [PATCH next] Input: alps_get_pkt_id_ss4_v2() can be static

[Hans de Goede]

Hi,

On 04/11/2015 03:21 AM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Ack, these should all be static:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Dmitry, can you please merge this one ?

Regards,

Hans

> ---
>   alps.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index ad741c0..3ef93ff 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -1093,7 +1093,7 @@ static void alps_process_packet_v7(struct psmouse *psmouse)
>   		alps_process_touchpad_packet_v7(psmouse);
>   }
>
> -unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
> +static unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
>   {
>   	unsigned char pkt_id = SS4_PACKET_ID_IDLE;
>
> @@ -2340,7 +2340,7 @@ static int alps_get_otp_values_ss4_v2(struct psmouse *psmouse,
>   	return 0;
>   }
>
> -int alps_update_device_area_ss4_v2(unsigned char otp[][4],
> +static int alps_update_device_area_ss4_v2(unsigned char otp[][4],
>   				   struct alps_data *priv)
>   {
>   	int num_x_electrode;
> @@ -2365,7 +2365,7 @@ int alps_update_device_area_ss4_v2(unsigned char otp[][4],
>   	return 0;
>   }
>
> -int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
> +static int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
>   {
>
>   	unsigned char is_btnless;
>

Re: [PATCH next] Input: alps_get_pkt_id_ss4_v2() can be static

[Dmitry Torokhov]

On Sat, Apr 11, 2015 at 08:32:10AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 04/11/2015 03:21 AM, kbuild test robot wrote:
> >
> >Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Ack, these should all be static:
> 
> Acked-by: Hans de Goede <hdegoede@redhat.com>
> 
> Dmitry, can you please merge this one ?

Yep, applied, thank you.

> 
> Regards,
> 
> Hans
> 
> >---
> >  alps.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> >index ad741c0..3ef93ff 100644
> >--- a/drivers/input/mouse/alps.c
> >+++ b/drivers/input/mouse/alps.c
> >@@ -1093,7 +1093,7 @@ static void alps_process_packet_v7(struct psmouse *psmouse)
> >  		alps_process_touchpad_packet_v7(psmouse);
> >  }
> >
> >-unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
> >+static unsigned char alps_get_pkt_id_ss4_v2(unsigned char *byte)
> >  {
> >  	unsigned char pkt_id = SS4_PACKET_ID_IDLE;
> >
> >@@ -2340,7 +2340,7 @@ static int alps_get_otp_values_ss4_v2(struct psmouse *psmouse,
> >  	return 0;
> >  }
> >
> >-int alps_update_device_area_ss4_v2(unsigned char otp[][4],
> >+static int alps_update_device_area_ss4_v2(unsigned char otp[][4],
> >  				   struct alps_data *priv)
> >  {
> >  	int num_x_electrode;
> >@@ -2365,7 +2365,7 @@ int alps_update_device_area_ss4_v2(unsigned char otp[][4],
> >  	return 0;
> >  }
> >
> >-int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
> >+static int alps_update_btn_info_ss4_v2(unsigned char otp[][4], struct alps_data *priv)
> >  {
> >
> >  	unsigned char is_btnless;
> >

-- 
Dmitry