All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org,
	galak@codeaurora.org, netdev@vger.kernel.org,
	richardcochran@gmail.com, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] Renesas Ethernet AVB driver
Date: Mon, 13 Apr 2015 20:32:59 +0000	[thread overview]
Message-ID: <20150413.163259.2190743529898270341.davem@davemloft.net> (raw)
In-Reply-To: <1453213.DoV6WFn45r@wasted.cogentembedded.com>

RnJvbTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5b3ZAY29nZW50ZW1iZWRkZWQuY29t
Pg0KRGF0ZTogTW9uLCAxMyBBcHIgMjAxNSAwMTozNjo1NiArMDMwMA0KDQo+IEV0aGVybmV0IEFW
QiBpbmNsdWRlcyBhbiBHaWdhYml0IEV0aGVybmV0IGNvbnRyb2xsZXIgKEUtTUFDKSB0aGF0IGlz
IGJhc2ljYWxseQ0KPiBjb21wYXRpYmxlIHdpdGggU3VwZXJIIEdpZ2FiaXQgRXRoZXJuZXQgRS1N
QUMpLiBFdGhlcm5ldCBBVkIgIGhhcyBhIGRlZGljYXRlZA0KPiBkaXJlY3QgbWVtb3J5IGFjY2Vz
cyBjb250cm9sbGVyIChBVkItRE1BQykgdGhhdCBpcyBhIG5ldyBkZXNpZ24gY29tcGFyZWQgdG8g
dGhlDQo+IFN1cGVySCBFLURNQUMuIFRoZSBBVkItRE1BQyBpcyBjb21wbGlhbnQgd2l0aCAzIHN0
YW5kYXJkcyBmb3JtdWxhdGVkIGZvciBJRUVFDQo+IDgwMi4xQkE6IElFRUUgODAyLjFBUyB0aW1p
bmcgYW5kIHN5bmNocm9uaXphdGlvbiBwcm90b2NvbCwgSUVFRSA4MDIuMVFhdiByZWFsLQ0KPiB0
aW1lIHRyYW5zZmVyLCBhbmQgdGhlIElFRUUgODAyLjFRYXQgc3RyZWFtIHJlc2VydmF0aW9uIHBy
b3RvY29sLg0KPiANCj4gTm90IG9ubHkgdGhlIEV0aGVybmV0IGRyaXZlciBpcyBlbmNsb3NlZCwg
dGhlcmUgaXMgYWxzbyB0aGUgUFRQIGRyaXZlciBpbg0KPiB0aGUgc2FtZSBmaWxlLiAgVGhlc2Ug
ZHJpdmVycyBvbmx5IHN1cHBvcnQgZGV2aWNlIHRyZWUgcHJvYmluZywgc28gdGhlIGJpbmRpbmcN
Cj4gZG9jdW1lbnQgaXMgaW5jbHVkZWQgaW4gdGhpcyBwYXRjaC4NCj4gDQo+IEJhc2VkIG9uIHRo
ZSBvcmlnaW5hbCBwYXRjaGVzIGJ5IE1pdHN1aGlybyBLaW11cmEgKEV0aGVybmV0IGRyaXZlcikg
YW5kIE1hc2FydQ0KPiBOYWdhaSAoUFRQIGRyaXZlcikuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBN
aXRzdWhpcm8gS2ltdXJhIDxtaXRzdWhpcm8ua2ltdXJhLmtjQHJlbmVzYXMuY29tPg0KPiBTaWdu
ZWQtb2ZmLWJ5OiBNYXNhcnUgTmFnYWkgPG1hc2FydS5uYWdhaS52eEByZW5lc2FzLmNvbT4NCj4g
U2lnbmVkLW9mZi1ieTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5b3ZAY29nZW50ZW1i
ZWRkZWQuY29tPg0KDQpEb2Vzbid0IGJ1aWxkIHByb3Blcmx5IG9uIHg4Ni02NDoNCg0KICBDQyBb
TV0gIGRyaXZlcnMvbmV0L2V0aGVybmV0L3JlbmVzYXMvcmF2Yi5vDQpkcml2ZXJzL25ldC9ldGhl
cm5ldC9yZW5lc2FzL3JhdmIuYzogSW4gZnVuY3Rpb24goXJhdmJfc2V0X2J1ZmZlcl9hbGlnbqI6
DQpkcml2ZXJzL25ldC9ldGhlcm5ldC9yZW5lc2FzL3JhdmIuYzo5NTU6MTY6IHdhcm5pbmc6IGNh
c3QgZnJvbSBwb2ludGVyIHRvIGludGVnZXIgb2YgZGlmZmVyZW50IHNpemUgWy1XcG9pbnRlci10
by1pbnQtY2FzdF0NCiAgdTMyIHJlc2VydmUgPSAodTMyKXNrYi0+ZGF0YSAmIChSQVZCX0FMSUdO
IC0gMSk7DQogICAgICAgICAgICAgICAgXg0KZHJpdmVycy9uZXQvZXRoZXJuZXQvcmVuZXNhcy9y
YXZiLmM6IEF0IHRvcCBsZXZlbDoNCmRyaXZlcnMvbmV0L2V0aGVybmV0L3JlbmVzYXMvcmF2Yi5j
OjI3NzE6MjogZXJyb3I6IHVua25vd24gZmllbGQgoWdldHRpbWWiIHNwZWNpZmllZCBpbiBpbml0
aWFsaXplcg0KICAuZ2V0dGltZSA9IHJhdmJfcHRwX2dldHRpbWUsDQogIF4NCmRyaXZlcnMvbmV0
L2V0aGVybmV0L3JlbmVzYXMvcmF2Yi5jOjI3NzI6MjogZXJyb3I6IHVua25vd24gZmllbGQgoXNl
dHRpbWWiIHNwZWNpZmllZCBpbiBpbml0aWFsaXplcg0KICAuc2V0dGltZSA9IHJhdmJfcHRwX3Nl
dHRpbWUsDQogIF4NCg0KSXQgaXMgbm90IGFjY2VwdGFibGUgdG8gZml4IHRoaXMgYnkgcmVtb3Zp
bmcgQ09NUElMRV9URVNUIGZyb20gdGhlIEtjb25maWcNCmRlcGVuZGVuY2llcyBvciBzb21ldGhp
bmcgbGlrZSB0aGF0Lg0KDQpUaGFua3MuDQo

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org,
	galak@codeaurora.org, netdev@vger.kernel.org,
	richardcochran@gmail.com, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] Renesas Ethernet AVB driver
Date: Mon, 13 Apr 2015 16:32:59 -0400 (EDT)	[thread overview]
Message-ID: <20150413.163259.2190743529898270341.davem@davemloft.net> (raw)
In-Reply-To: <1453213.DoV6WFn45r@wasted.cogentembedded.com>

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 13 Apr 2015 01:36:56 +0300

> Ethernet AVB includes an Gigabit Ethernet controller (E-MAC) that is basically
> compatible with SuperH Gigabit Ethernet E-MAC). Ethernet AVB  has a dedicated
> direct memory access controller (AVB-DMAC) that is a new design compared to the
> SuperH E-DMAC. The AVB-DMAC is compliant with 3 standards formulated for IEEE
> 802.1BA: IEEE 802.1AS timing and synchronization protocol, IEEE 802.1Qav real-
> time transfer, and the IEEE 802.1Qat stream reservation protocol.
> 
> Not only the Ethernet driver is enclosed, there is also the PTP driver in
> the same file.  These drivers only support device tree probing, so the binding
> document is included in this patch.
> 
> Based on the original patches by Mitsuhiro Kimura (Ethernet driver) and Masaru
> Nagai (PTP driver).
> 
> Signed-off-by: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Doesn't build properly on x86-64:

  CC [M]  drivers/net/ethernet/renesas/ravb.o
drivers/net/ethernet/renesas/ravb.c: In function ‘ravb_set_buffer_align’:
drivers/net/ethernet/renesas/ravb.c:955:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  u32 reserve = (u32)skb->data & (RAVB_ALIGN - 1);
                ^
drivers/net/ethernet/renesas/ravb.c: At top level:
drivers/net/ethernet/renesas/ravb.c:2771:2: error: unknown field ‘gettime’ specified in initializer
  .gettime = ravb_ptp_gettime,
  ^
drivers/net/ethernet/renesas/ravb.c:2772:2: error: unknown field ‘settime’ specified in initializer
  .settime = ravb_ptp_settime,
  ^

It is not acceptable to fix this by removing COMPILE_TEST from the Kconfig
dependencies or something like that.

Thanks.

  reply	other threads:[~2015-04-13 20:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12 22:36 [PATCH v2] Renesas Ethernet AVB driver Sergei Shtylyov
2015-04-12 22:36 ` Sergei Shtylyov
2015-04-13 20:32 ` David Miller [this message]
2015-04-13 20:32   ` David Miller
2015-04-13 20:49   ` Sergei Shtylyov
2015-04-13 20:49     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413.163259.2190743529898270341.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-sh@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.