All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] configfs: init configfs module earlier at boot time
@ 2015-04-07 15:56 Daniel Baluta
  2015-04-13  9:44 ` Christoph Hellwig
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Baluta @ 2015-04-07 15:56 UTC (permalink / raw)
  To: viro, hch, jlbec; +Cc: linux-fsdevel, lars, daniel.baluta, linux-kernel

We need this earlier in the boot process to allow various subsystems
to use configfs (e.g Industrial IIO).

Also, debugfs is at core_initcall level and configfs should be on
the same level from infrastructure point of view.

Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
* Extended CC list with Al, Christoph and fsdevel :)

 fs/configfs/mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c
index da94e41..5373567 100644
--- a/fs/configfs/mount.c
+++ b/fs/configfs/mount.c
@@ -173,5 +173,5 @@ MODULE_LICENSE("GPL");
 MODULE_VERSION("0.0.2");
 MODULE_DESCRIPTION("Simple RAM filesystem for user driven kernel subsystem configuration.");
 
-module_init(configfs_init);
+core_initcall(configfs_init);
 module_exit(configfs_exit);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] configfs: init configfs module earlier at boot time
  2015-04-07 15:56 [RESEND PATCH] configfs: init configfs module earlier at boot time Daniel Baluta
@ 2015-04-13  9:44 ` Christoph Hellwig
  0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2015-04-13  9:44 UTC (permalink / raw)
  To: Daniel Baluta; +Cc: viro, hch, jlbec, linux-fsdevel, lars, linux-kernel

On Tue, Apr 07, 2015 at 06:56:11PM +0300, Daniel Baluta wrote:
> We need this earlier in the boot process to allow various subsystems
> to use configfs (e.g Industrial IIO).
> 
> Also, debugfs is at core_initcall level and configfs should be on
> the same level from infrastructure point of view.
> 
> Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [RESEND PATCH] configfs: init configfs module earlier at boot time
@ 2015-04-24  9:46 Daniel Baluta
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2015-04-24  9:46 UTC (permalink / raw)
  To: akpm; +Cc: viro, hch, jlbec, linux-fsdevel, lars, linux-kernel, daniel.baluta

We need this earlier in the boot process to allow various subsystems
to use configfs (e.g Industrial IIO).

Also, debugfs is at core_initcall level and configfs should be on
the same level from infrastructure point of view.

Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 * third resend, adding Andrew

 fs/configfs/mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c
index da94e41..5373567 100644
--- a/fs/configfs/mount.c
+++ b/fs/configfs/mount.c
@@ -173,5 +173,5 @@ MODULE_LICENSE("GPL");
 MODULE_VERSION("0.0.2");
 MODULE_DESCRIPTION("Simple RAM filesystem for user driven kernel subsystem configuration.");
 
-module_init(configfs_init);
+core_initcall(configfs_init);
 module_exit(configfs_exit);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] configfs: init configfs module earlier at boot time
  2015-03-18 19:56 Daniel Baluta
@ 2015-04-02  7:34 ` Daniel Baluta
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2015-04-02  7:34 UTC (permalink / raw)
  To: Daniel Baluta, Joel Becker
  Cc: Linux Kernel Mailing List, Lars-Peter Clausen, Greg Kroah-Hartman

On Wed, Mar 18, 2015 at 9:56 PM, Daniel Baluta <daniel.baluta@intel.com> wrote:
> We need this earlier in the boot process to allow various subsystems
> to use configfs (e.g Industrial IIO).
>
> Also, debugfs is at core_initcall level and configfs should be on
> the same level from infrastructure point of view.
>
> Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
> ---
> First time I miscopied Joel's email address.
>
>  fs/configfs/mount.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c
> index da94e41..5373567 100644
> --- a/fs/configfs/mount.c
> +++ b/fs/configfs/mount.c
> @@ -173,5 +173,5 @@ MODULE_LICENSE("GPL");
>  MODULE_VERSION("0.0.2");
>  MODULE_DESCRIPTION("Simple RAM filesystem for user driven kernel subsystem configuration.");
>
> -module_init(configfs_init);
> +core_initcall(configfs_init);
>  module_exit(configfs_exit);
> --


Hi Joel,

Did you get any chance to look into this? I am not sure
exactly who should take this, so I'm adding Greg.

The original patch can also be found here:

https://lkml.org/lkml/2015/3/18/751

Daniel.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [RESEND PATCH] configfs: init configfs module earlier at boot time
@ 2015-03-18 19:56 Daniel Baluta
  2015-04-02  7:34 ` Daniel Baluta
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Baluta @ 2015-03-18 19:56 UTC (permalink / raw)
  To: jlbec; +Cc: linux-kernel, lars, daniel.baluta

We need this earlier in the boot process to allow various subsystems
to use configfs (e.g Industrial IIO).

Also, debugfs is at core_initcall level and configfs should be on
the same level from infrastructure point of view.

Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
First time I miscopied Joel's email address.

 fs/configfs/mount.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c
index da94e41..5373567 100644
--- a/fs/configfs/mount.c
+++ b/fs/configfs/mount.c
@@ -173,5 +173,5 @@ MODULE_LICENSE("GPL");
 MODULE_VERSION("0.0.2");
 MODULE_DESCRIPTION("Simple RAM filesystem for user driven kernel subsystem configuration.");
 
-module_init(configfs_init);
+core_initcall(configfs_init);
 module_exit(configfs_exit);
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-24  9:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-07 15:56 [RESEND PATCH] configfs: init configfs module earlier at boot time Daniel Baluta
2015-04-13  9:44 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2015-04-24  9:46 Daniel Baluta
2015-03-18 19:56 Daniel Baluta
2015-04-02  7:34 ` Daniel Baluta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.