From: "Kirill A. Shutemov" <kirill@shutemov.name> To: Yigal Korman <yigal@plexistor.com>, Matthew Wilcox <willy@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: mlock() on DAX returns -ENOMEM Date: Mon, 13 Apr 2015 15:56:54 +0300 [thread overview] Message-ID: <20150413125654.GB12354@node.dhcp.inet.fi> (raw) In-Reply-To: <CACTTzNY+u+4rU89o9vXk2HkjdnoRW+H8VcvCdr_H04MUEBCqNg@mail.gmail.com> On Sun, Apr 12, 2015 at 03:56:33PM +0300, Yigal Korman wrote: > Hi, > I've tried to mlock() a range of an ext4-dax file and got "-ENOMEM" in return. Is it comes from mlock_fixup() or -EFAULT from GUP translated to -ENOMEM by __mlock_posix_error_return()? > Looking at the code, it seems that this is related to the fact that > DAX uses VM_MIXEDMAP and mlock assumes/requires regular page cache. > To me it seems that DAX should simply return success in mlock() as all > data is always in memory and no swapping is possible. > Is this a bug or intentional? Is there a fix planned? I think it's a bug. But first we need to define what mlock() means for DAX mappings. For writable MAP_PRIVATE: we should be able to trigger COW for the range and mlock resulting pages. It means we should fix kernel to handle GUP(FOLL_TOUCH | FOLL_POPULATE | FOLL_WRITE | FOLL_FORCE) successfully on such VMAs. For MAP_SHARED and non-writable MAP_PRIVATE we should be able to populate the mapping with PTEs. Not sure if we need to set VM_LOCKED for such VMAs. We probably should, as we want to re-instantiate PTEs on mremap() and such. It means we need to get working at least GUP(FOLL_POPULATE | FOLL_FORCE). In general we need to adjust GUP to avoid going to struct page unless FOLL_* speficly imply struct page, such as FOLL_GET or FOLL_TOUCH. Not sure if we need to differentiate DAX mappings from other VM_MIXEDMAP. Any comments? > Also, the same code path that is used in mlock is also used for > MAP_POPULATE (pre-fault pages in mmap) so this flag doesn't work as > well (doesn't fail but simply doesn't pre-fault anything). > > Thanks, > Yigal > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Kirill A. Shutemov
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name> To: Yigal Korman <yigal@plexistor.com>, Matthew Wilcox <willy@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: mlock() on DAX returns -ENOMEM Date: Mon, 13 Apr 2015 15:56:54 +0300 [thread overview] Message-ID: <20150413125654.GB12354@node.dhcp.inet.fi> (raw) In-Reply-To: <CACTTzNY+u+4rU89o9vXk2HkjdnoRW+H8VcvCdr_H04MUEBCqNg@mail.gmail.com> On Sun, Apr 12, 2015 at 03:56:33PM +0300, Yigal Korman wrote: > Hi, > I've tried to mlock() a range of an ext4-dax file and got "-ENOMEM" in return. Is it comes from mlock_fixup() or -EFAULT from GUP translated to -ENOMEM by __mlock_posix_error_return()? > Looking at the code, it seems that this is related to the fact that > DAX uses VM_MIXEDMAP and mlock assumes/requires regular page cache. > To me it seems that DAX should simply return success in mlock() as all > data is always in memory and no swapping is possible. > Is this a bug or intentional? Is there a fix planned? I think it's a bug. But first we need to define what mlock() means for DAX mappings. For writable MAP_PRIVATE: we should be able to trigger COW for the range and mlock resulting pages. It means we should fix kernel to handle GUP(FOLL_TOUCH | FOLL_POPULATE | FOLL_WRITE | FOLL_FORCE) successfully on such VMAs. For MAP_SHARED and non-writable MAP_PRIVATE we should be able to populate the mapping with PTEs. Not sure if we need to set VM_LOCKED for such VMAs. We probably should, as we want to re-instantiate PTEs on mremap() and such. It means we need to get working at least GUP(FOLL_POPULATE | FOLL_FORCE). In general we need to adjust GUP to avoid going to struct page unless FOLL_* speficly imply struct page, such as FOLL_GET or FOLL_TOUCH. Not sure if we need to differentiate DAX mappings from other VM_MIXEDMAP. Any comments? > Also, the same code path that is used in mlock is also used for > MAP_POPULATE (pre-fault pages in mmap) so this flag doesn't work as > well (doesn't fail but simply doesn't pre-fault anything). > > Thanks, > Yigal > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-13 12:57 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-12 12:56 mlock() on DAX returns -ENOMEM Yigal Korman 2015-04-13 12:56 ` Kirill A. Shutemov [this message] 2015-04-13 12:56 ` Kirill A. Shutemov 2015-04-14 10:27 ` Yigal Korman 2015-04-14 10:27 ` Yigal Korman 2015-04-14 11:42 ` Kirill A. Shutemov 2015-04-14 11:42 ` Kirill A. Shutemov 2015-04-14 19:44 ` Matthew Wilcox 2015-04-14 19:44 ` Matthew Wilcox
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150413125654.GB12354@node.dhcp.inet.fi \ --to=kirill@shutemov.name \ --cc=akpm@linux-foundation.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=willy@linux.intel.com \ --cc=yigal@plexistor.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.