Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Chris Mason]

Hi stable friends,

Can you please backport this one to 3.19.y.  It fixes a bug introduced 
by:

381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 
3.14+

The symptoms of the bug are deadlocks during log reply after a crash.  
The patch wasn't intentionally fixing the deadlock, which is why we 
missed it when tagging fixes.

Please put this commit everywhere you've cherry-picked 
381cf6587f8a8a8e981bc0c1aaaa8859b51dc756

commit 9c4f61f01d269815bb7c37be3ede59c5587747c6
Author: David Sterba <dsterba@suse.cz>
Date:   Fri Jan 2 19:12:57 2015 +0100

    btrfs: simplify insert_orphan_item

    We can search and add the orphan item in one go,
    btrfs_insert_orphan_item will find out if the item already exists.

    Signed-off-by: David Sterba <dsterba@suse.cz>

-chris

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Luis Henriques]

On Thu, Apr 02, 2015 at 10:17:47AM -0400, Chris Mason wrote:
> Hi stable friends,
> 
> Can you please backport this one to 3.19.y.  It fixes a bug introduced by:
> 
> 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 3.14+
> 
> The symptoms of the bug are deadlocks during log reply after a crash.  The
> patch wasn't intentionally fixing the deadlock, which is why we missed it
> when tagging fixes.
> 
> Please put this commit everywhere you've cherry-picked
> 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756
> 

Thank you, I'll queue this fix for the 3.16 kernel.

Cheers,
--
Luís

> commit 9c4f61f01d269815bb7c37be3ede59c5587747c6
> Author: David Sterba <dsterba@suse.cz>
> Date:   Fri Jan 2 19:12:57 2015 +0100
> 
>    btrfs: simplify insert_orphan_item
> 
>    We can search and add the orphan item in one go,
>    btrfs_insert_orphan_item will find out if the item already exists.
> 
>    Signed-off-by: David Sterba <dsterba@suse.cz>
> 
> -chris
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Roman Mamedov]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

On Thu, 2 Apr 2015 10:17:47 -0400
Chris Mason <clm@fb.com> wrote:

> Hi stable friends,
> 
> Can you please backport this one to 3.19.y.  It fixes a bug introduced 
> by:
> 
> 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 
> 3.14+
> 
> The symptoms of the bug are deadlocks during log reply after a crash.  
> The patch wasn't intentionally fixing the deadlock, which is why we 
> missed it when tagging fixes.

Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and
3.18.11 released today.

> 
> Please put this commit everywhere you've cherry-picked 
> 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756
> 
> commit 9c4f61f01d269815bb7c37be3ede59c5587747c6
> Author: David Sterba <dsterba@suse.cz>
> Date:   Fri Jan 2 19:12:57 2015 +0100
> 
>     btrfs: simplify insert_orphan_item
> 
>     We can search and add the orphan item in one go,
>     btrfs_insert_orphan_item will find out if the item already exists.
> 
>     Signed-off-by: David Sterba <dsterba@suse.cz>
> 
> -chris
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
With respect,
Roman

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Greg KH]

On Mon, Apr 13, 2015 at 07:28:38PM +0500, Roman Mamedov wrote:
> On Thu, 2 Apr 2015 10:17:47 -0400
> Chris Mason <clm@fb.com> wrote:
> 
> > Hi stable friends,
> > 
> > Can you please backport this one to 3.19.y.  It fixes a bug introduced 
> > by:
> > 
> > 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable 
> > 3.14+
> > 
> > The symptoms of the bug are deadlocks during log reply after a crash.  
> > The patch wasn't intentionally fixing the deadlock, which is why we 
> > missed it when tagging fixes.
> 
> Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and
> 3.18.11 released today.

I have a few hundred stable backports left to sort through, don't worry,
this is still in the queue, it's not lost.

greg k-h

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Rich Freeman]

On Mon, Apr 13, 2015 at 12:58 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Apr 13, 2015 at 07:28:38PM +0500, Roman Mamedov wrote:
>> On Thu, 2 Apr 2015 10:17:47 -0400
>> Chris Mason <clm@fb.com> wrote:
>>
>> > Hi stable friends,
>> >
>> > Can you please backport this one to 3.19.y.  It fixes a bug introduced
>> > by:
>> >
>> > 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable
>> > 3.14+
>> >
>> > The symptoms of the bug are deadlocks during log reply after a crash.
>> > The patch wasn't intentionally fixing the deadlock, which is why we
>> > missed it when tagging fixes.
>>
>> Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and
>> 3.18.11 released today.
>
> I have a few hundred stable backports left to sort through, don't worry,
> this is still in the queue, it's not lost.

It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.

--
Rich

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Josh Boyer]

On Thu, Apr 23, 2015 at 2:16 PM, Rich Freeman
<r-btrfs@thefreemanclan.net> wrote:
> On Mon, Apr 13, 2015 at 12:58 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Mon, Apr 13, 2015 at 07:28:38PM +0500, Roman Mamedov wrote:
>>> On Thu, 2 Apr 2015 10:17:47 -0400
>>> Chris Mason <clm@fb.com> wrote:
>>>
>>> > Hi stable friends,
>>> >
>>> > Can you please backport this one to 3.19.y.  It fixes a bug introduced
>>> > by:
>>> >
>>> > 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable
>>> > 3.14+
>>> >
>>> > The symptoms of the bug are deadlocks during log reply after a crash.
>>> > The patch wasn't intentionally fixing the deadlock, which is why we
>>> > missed it when tagging fixes.
>>>
>>> Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and
>>> 3.18.11 released today.
>>
>> I have a few hundred stable backports left to sort through, don't worry,
>> this is still in the queue, it's not lost.
>
> It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.

Sasha is maintaining the 3.18.y stable tree, not Greg.  Added to CC.

josh

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Sasha Levin]

On 04/23/2015 02:24 PM, Josh Boyer wrote:
> On Thu, Apr 23, 2015 at 2:16 PM, Rich Freeman
> <r-btrfs@thefreemanclan.net> wrote:
>> > On Mon, Apr 13, 2015 at 12:58 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>>> >> On Mon, Apr 13, 2015 at 07:28:38PM +0500, Roman Mamedov wrote:
>>>> >>> On Thu, 2 Apr 2015 10:17:47 -0400
>>>> >>> Chris Mason <clm@fb.com> wrote:
>>>> >>>
>>>>> >>> > Hi stable friends,
>>>>> >>> >
>>>>> >>> > Can you please backport this one to 3.19.y.  It fixes a bug introduced
>>>>> >>> > by:
>>>>> >>> >
>>>>> >>> > 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable
>>>>> >>> > 3.14+
>>>>> >>> >
>>>>> >>> > The symptoms of the bug are deadlocks during log reply after a crash.
>>>>> >>> > The patch wasn't intentionally fixing the deadlock, which is why we
>>>>> >>> > missed it when tagging fixes.
>>>> >>>
>>>> >>> Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and
>>>> >>> 3.18.11 released today.
>>> >>
>>> >> I have a few hundred stable backports left to sort through, don't worry,
>>> >> this is still in the queue, it's not lost.
>> >
>> > It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.
> Sasha is maintaining the 3.18.y stable tree, not Greg.  Added to CC.

Um, that commit was shipped back in 3.18.9.


Thanks,
Sasha

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Sasha Levin]

On 04/23/2015 02:34 PM, Sasha Levin wrote:
> On 04/23/2015 02:24 PM, Josh Boyer wrote:
>> On Thu, Apr 23, 2015 at 2:16 PM, Rich Freeman
>> <r-btrfs@thefreemanclan.net> wrote:
>>>> On Mon, Apr 13, 2015 at 12:58 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>>>>>> On Mon, Apr 13, 2015 at 07:28:38PM +0500, Roman Mamedov wrote:
>>>>>>>> On Thu, 2 Apr 2015 10:17:47 -0400
>>>>>>>> Chris Mason <clm@fb.com> wrote:
>>>>>>>>
>>>>>>>>>> Hi stable friends,
>>>>>>>>>>
>>>>>>>>>> Can you please backport this one to 3.19.y.  It fixes a bug introduced
>>>>>>>>>> by:
>>>>>>>>>>
>>>>>>>>>> 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable
>>>>>>>>>> 3.14+
>>>>>>>>>>
>>>>>>>>>> The symptoms of the bug are deadlocks during log reply after a crash.
>>>>>>>>>> The patch wasn't intentionally fixing the deadlock, which is why we
>>>>>>>>>> missed it when tagging fixes.
>>>>>>>>
>>>>>>>> Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and
>>>>>>>> 3.18.11 released today.
>>>>>>
>>>>>> I have a few hundred stable backports left to sort through, don't worry,
>>>>>> this is still in the queue, it's not lost.
>>>>
>>>> It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.
>> Sasha is maintaining the 3.18.y stable tree, not Greg.  Added to CC.
> 
> Um, that commit was shipped back in 3.18.9.

Oh, bleh, I've looked the wrong commit. I've queued 9c4f61f01d269815bb7c37be3ede59c5587747c6
up for 3.18.13.

Thanks!

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

[Greg KH]

On Thu, Apr 23, 2015 at 02:16:40PM -0400, Rich Freeman wrote:
> On Mon, Apr 13, 2015 at 12:58 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Apr 13, 2015 at 07:28:38PM +0500, Roman Mamedov wrote:
> >> On Thu, 2 Apr 2015 10:17:47 -0400
> >> Chris Mason <clm@fb.com> wrote:
> >>
> >> > Hi stable friends,
> >> >
> >> > Can you please backport this one to 3.19.y.  It fixes a bug introduced
> >> > by:
> >> >
> >> > 381cf6587f8a8a8e981bc0c1aaaa8859b51dc756, which was tagged for stable
> >> > 3.14+
> >> >
> >> > The symptoms of the bug are deadlocks during log reply after a crash.
> >> > The patch wasn't intentionally fixing the deadlock, which is why we
> >> > missed it when tagging fixes.
> >>
> >> Unfortunately still not fixed (no btrfs-related changes) in 3.14.38 and
> >> 3.18.11 released today.
> >
> > I have a few hundred stable backports left to sort through, don't worry,
> > this is still in the queue, it's not lost.
> 
> It looks like this still isn't in 3.18.12, though it looks like it is in 3.19.5.

I don't manage 3.18-stable anymore, so there's nothing I can do here :)