* [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros
@ 2015-04-13 9:53 Thomas Petazzoni
2015-04-13 19:53 ` Yann E. MORIN
2015-04-13 20:26 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-04-13 9:53 UTC (permalink / raw)
To: buildroot
The package infrastructure macros have a long time ago been renamed
from GENTARGETS, AUTOTARGETS to generic-package and
autotools-package. However, one comment in pkg-utils.mk keeps a
reference to these *TARGETS macros. This commit updates this comment
to match the new name of these macros.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/pkg-utils.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
index 7eddc47..5a385f8 100644
--- a/package/pkg-utils.mk
+++ b/package/pkg-utils.mk
@@ -60,7 +60,7 @@ endef
# Helper functions to determine the name of a package and its
# directory from its makefile directory, using the $(MAKEFILE_LIST)
-# variable provided by make. This is used by the *TARGETS macros to
+# variable provided by make. This is used by the *-package macros to
# automagically find where the package is located.
pkgdir = $(dir $(lastword $(MAKEFILE_LIST)))
pkgname = $(lastword $(subst /, ,$(pkgdir)))
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros
2015-04-13 9:53 [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros Thomas Petazzoni
@ 2015-04-13 19:53 ` Yann E. MORIN
2015-04-13 20:26 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2015-04-13 19:53 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2015-04-13 11:53 +0200, Thomas Petazzoni spake thusly:
> The package infrastructure macros have a long time ago been renamed
> from GENTARGETS, AUTOTARGETS to generic-package and
> autotools-package. However, one comment in pkg-utils.mk keeps a
> reference to these *TARGETS macros. This commit updates this comment
> to match the new name of these macros.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
I was puzzled as to why I could still see 'TARGETS' even after your
series was applied. This squashes that concenr of mine on your series. ;-)
Regards,
Yann E. MORIN.
> ---
> package/pkg-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 7eddc47..5a385f8 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -60,7 +60,7 @@ endef
>
> # Helper functions to determine the name of a package and its
> # directory from its makefile directory, using the $(MAKEFILE_LIST)
> -# variable provided by make. This is used by the *TARGETS macros to
> +# variable provided by make. This is used by the *-package macros to
> # automagically find where the package is located.
> pkgdir = $(dir $(lastword $(MAKEFILE_LIST)))
> pkgname = $(lastword $(subst /, ,$(pkgdir)))
> --
> 2.1.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros
2015-04-13 9:53 [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros Thomas Petazzoni
2015-04-13 19:53 ` Yann E. MORIN
@ 2015-04-13 20:26 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-04-13 20:26 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 13 Apr 2015 11:53:21 +0200, Thomas Petazzoni wrote:
> The package infrastructure macros have a long time ago been renamed
> from GENTARGETS, AUTOTARGETS to generic-package and
> autotools-package. However, one comment in pkg-utils.mk keeps a
> reference to these *TARGETS macros. This commit updates this comment
> to match the new name of these macros.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/pkg-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-13 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-13 9:53 [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros Thomas Petazzoni
2015-04-13 19:53 ` Yann E. MORIN
2015-04-13 20:26 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.