All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] input: ambakmi: Fix system PM by converting to modern callbacks
Date: Tue, 14 Apr 2015 23:30:29 +0100	[thread overview]
Message-ID: <20150414223029.GU12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150414162210.GA29874@dtor-ws>

On Tue, Apr 14, 2015 at 09:22:10AM -0700, Dmitry Torokhov wrote:
> On Tue, Apr 14, 2015 at 12:41:48PM +0200, Ulf Hansson wrote:
> > The legacy system PM support has long time ago been dropped from the
> > AMBA bus. Align to that by converting to the modern system PM
> > callbacks.
> > 
> > Fixes: 26825cfd90f9 (ARM: 7914/1: amba: Drop legacy PM support ...)
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> If this has not been noticed since end of 2013 maybe we should drop the
> driver?

That's rather silly.  It isn't a build breakage, and it's not a
functional breakage.  In fact, this driver gets build and boot tested
every evening on hardware I have here in my autobuild system.

The regression is only visible if it is used on a platform with power
management support, and that's probably close to none - unless hibernate
support is enabled.  I'm just pushing up some patches which fix long
term hibernation issues on ARM.

If we apply your "lets drop stuff" argument, maybe we should drop ARM
hibernation support because its been broken for many years... obviously
that's also a rediculous suggestion.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] input: ambakmi: Fix system PM by converting to modern callbacks
Date: Tue, 14 Apr 2015 23:30:29 +0100	[thread overview]
Message-ID: <20150414223029.GU12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150414162210.GA29874@dtor-ws>

On Tue, Apr 14, 2015 at 09:22:10AM -0700, Dmitry Torokhov wrote:
> On Tue, Apr 14, 2015 at 12:41:48PM +0200, Ulf Hansson wrote:
> > The legacy system PM support has long time ago been dropped from the
> > AMBA bus. Align to that by converting to the modern system PM
> > callbacks.
> > 
> > Fixes: 26825cfd90f9 (ARM: 7914/1: amba: Drop legacy PM support ...)
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> If this has not been noticed since end of 2013 maybe we should drop the
> driver?

That's rather silly.  It isn't a build breakage, and it's not a
functional breakage.  In fact, this driver gets build and boot tested
every evening on hardware I have here in my autobuild system.

The regression is only visible if it is used on a platform with power
management support, and that's probably close to none - unless hibernate
support is enabled.  I'm just pushing up some patches which fix long
term hibernation issues on ARM.

If we apply your "lets drop stuff" argument, maybe we should drop ARM
hibernation support because its been broken for many years... obviously
that's also a rediculous suggestion.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-04-14 22:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 10:41 [PATCH] input: ambakmi: Fix system PM by converting to modern callbacks Ulf Hansson
2015-04-14 10:41 ` Ulf Hansson
2015-04-14 16:22 ` Dmitry Torokhov
2015-04-14 16:22   ` Dmitry Torokhov
2015-04-14 22:30   ` Russell King - ARM Linux [this message]
2015-04-14 22:30     ` Russell King - ARM Linux
2015-04-14 23:58     ` Dmitry Torokhov
2015-04-14 23:58       ` Dmitry Torokhov
2015-04-15  9:32       ` Russell King - ARM Linux
2015-04-15  9:32         ` Russell King - ARM Linux
2015-04-15 11:54         ` Ulf Hansson
2015-04-15 11:54           ` Ulf Hansson
2015-04-15 17:23         ` Dmitry Torokhov
2015-04-15 17:23           ` Dmitry Torokhov
2015-05-22 14:37 ` Ulf Hansson
2015-05-22 14:37   ` Ulf Hansson
2015-05-22 14:39   ` Russell King - ARM Linux
2015-05-22 14:39     ` Russell King - ARM Linux
2015-05-26 13:50     ` Ulf Hansson
2015-05-26 13:50       ` Ulf Hansson
2015-05-22 16:49   ` Dmitry Torokhov
2015-05-22 16:49     ` Dmitry Torokhov
2015-07-16  8:48     ` Ulf Hansson
2015-07-16  8:48       ` Ulf Hansson
2015-07-16 17:37       ` Dmitry Torokhov
2015-07-16 17:37         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150414223029.GU12732@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.