All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: netdev@vger.kernel.org, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: ip_tunnel: Remove gratuitous skb scrubbing
Date: Wed, 15 Apr 2015 18:22:29 +0800	[thread overview]
Message-ID: <20150415102229.GA3917@gondor.apana.org.au> (raw)
In-Reply-To: <552E3B7A.2040701@6wind.com>

On Wed, Apr 15, 2015 at 12:20:42PM +0200, Nicolas Dichtel wrote:
> Le 15/04/2015 12:01, Herbert Xu a écrit :
> >The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 ("tunnels:
> >harmonize cleanup done on skb on rx path") broke anyone trying to
> >use netfilter marking across IPv4 tunnels.  As the commit message
> >did not give any justification for this (in fact it shouldn't
> >even be touching the tx path), I can only assume that it was a typo.
> If I remember well, this was discussed on netdev (CC Eric). The goal of this
> patch was, like the title said, to hamonize packets processing in tunnels.
> I'm not against to keep the mark, but I think patching skb_scrub_packet is
> better. With your patch, ip6tnl, gre6, etc. still drops the mark. And at the
> end, it's not consistant.
> 
> What about something like this:

Yes this is better.  I'm currently auditing all the other bits
that are cleared to see if there is anything else that we should
preserve for tunneling.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2015-04-15 10:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 10:01 ip_tunnel: Remove gratuitous skb scrubbing Herbert Xu
2015-04-15 10:13 ` Herbert Xu
2015-04-15 10:20 ` Nicolas Dichtel
2015-04-15 10:22   ` Herbert Xu [this message]
2015-04-15 10:28     ` Nicolas Dichtel
2015-04-15 10:32       ` Herbert Xu
2015-04-15 13:57     ` Herbert Xu
2015-04-15 15:41       ` Nicolas Dichtel
2015-04-16  1:03         ` [v3] skbuff: Do not scrub skb mark within the same name space Herbert Xu
2015-04-16  7:02           ` James Morris
2015-04-16  7:35             ` Nicolas Dichtel
2015-04-16  7:59               ` Herbert Xu
2015-04-16  8:12             ` Revert "net: Reset secmark when scrubbing packet" Herbert Xu
2015-04-16  8:32               ` Thomas Graf
2015-04-16 18:21               ` David Miller
2015-04-16  8:33           ` [v3] skbuff: Do not scrub skb mark within the same name space Thomas Graf
2015-04-16 18:21             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150415102229.GA3917@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.