All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	netdev@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	James Morris <jmorris@namei.org>,
	linux-security-module@vger.kernel.org
Subject: Re: [v3] skbuff: Do not scrub skb mark within the same name space
Date: Thu, 16 Apr 2015 09:33:35 +0100	[thread overview]
Message-ID: <20150416083335.GE32170@casper.infradead.org> (raw)
In-Reply-To: <20150416010326.GA10864@gondor.apana.org.au>

On 04/16/15 at 09:03am, Herbert Xu wrote:
> The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 ("tunnels:
> harmonize cleanup done on skb on rx path") broke anyone trying to
> use netfilter marking across IPv4 tunnels.  While most of the
> fields that are cleared by skb_scrub_packet don't matter, the
> netfilter mark must be preserved.
> 
> This patch rearranges skb_scrub_packet to preserve the mark field.
> 
> Fixes: ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Thomas Graf <tgraf@suug.ch>

We should also add a flag to veth which expclitly allows to preserve
the mark into the namespace.

  parent reply	other threads:[~2015-04-16  8:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 10:01 ip_tunnel: Remove gratuitous skb scrubbing Herbert Xu
2015-04-15 10:13 ` Herbert Xu
2015-04-15 10:20 ` Nicolas Dichtel
2015-04-15 10:22   ` Herbert Xu
2015-04-15 10:28     ` Nicolas Dichtel
2015-04-15 10:32       ` Herbert Xu
2015-04-15 13:57     ` Herbert Xu
2015-04-15 15:41       ` Nicolas Dichtel
2015-04-16  1:03         ` [v3] skbuff: Do not scrub skb mark within the same name space Herbert Xu
2015-04-16  7:02           ` James Morris
2015-04-16  7:35             ` Nicolas Dichtel
2015-04-16  7:59               ` Herbert Xu
2015-04-16  8:12             ` Revert "net: Reset secmark when scrubbing packet" Herbert Xu
2015-04-16  8:32               ` Thomas Graf
2015-04-16 18:21               ` David Miller
2015-04-16  8:33           ` Thomas Graf [this message]
2015-04-16 18:21             ` [v3] skbuff: Do not scrub skb mark within the same name space David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150416083335.GE32170@casper.infradead.org \
    --to=tgraf@suug.ch \
    --cc=ebiederm@xmission.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jmorris@namei.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.