From: Wolfram Sang <wsa@the-dreams.de> To: Guenter Roeck <linux@roeck-us.net> Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> Subject: Re: [PATCH] i2c: jz4780: Fix build for m68k and sparc64 Date: Wed, 15 Apr 2015 17:41:50 +0200 [thread overview] Message-ID: <20150415154122.GA914@katana> (raw) In-Reply-To: <1429068073-7595-1-git-send-email-linux@roeck-us.net> [-- Attachment #1: Type: text/plain, Size: 2013 bytes --] Guenter, Thanks for catching this! > Fix: > > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw': > drivers/i2c/busses/i2c-jz4780.c:181:2: error: > implicit declaration of function 'readw' > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew': > drivers/i2c/busses/i2c-jz4780.c:187:2: error: > implicit declaration of function 'writew' > > seen with sparc64:allmodconfig and m68k:allmodconfig. > > The driver depends on HAS_IOMEM, and must include linux/io.h. > > Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver > for Ingenic JZ4780") > Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/i2c/busses/Kconfig | 1 + > drivers/i2c/busses/i2c-jz4780.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 2255af23b9c7..c78b6cbd1106 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -586,6 +586,7 @@ config I2C_IOP3XX > config I2C_JZ4780 > tristate "JZ4780 I2C controller interface support" > depends on MACH_JZ4780 || COMPILE_TEST > + depends on HAS_IOMEM You sure? We have menu "I2C Hardware Bus support" depends on HAS_IOMEM in drivers/i2c/busses/Kconfig. For me, menuconfig shows that the driver is already depending on HAS_IOMEM. > help > If you say yes to this option, support will be included for the > Ingenic JZ4780 I2C controller. > diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c > index ce1d69324169..f2761ab2ef32 100644 > --- a/drivers/i2c/busses/i2c-jz4780.c > +++ b/drivers/i2c/busses/i2c-jz4780.c > @@ -21,6 +21,7 @@ > #include <linux/delay.h> > #include <linux/errno.h> > #include <linux/i2c.h> > +#include <linux/io.h> > #include <linux/init.h> > #include <linux/interrupt.h> > #include <linux/kernel.h> The sorting needs to be fixed. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Zubair Lutfullah Kakakhel <Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Subject: Re: [PATCH] i2c: jz4780: Fix build for m68k and sparc64 Date: Wed, 15 Apr 2015 17:41:50 +0200 [thread overview] Message-ID: <20150415154122.GA914@katana> (raw) In-Reply-To: <1429068073-7595-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2069 bytes --] Guenter, Thanks for catching this! > Fix: > > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_readw': > drivers/i2c/busses/i2c-jz4780.c:181:2: error: > implicit declaration of function 'readw' > drivers/i2c/busses/i2c-jz4780.c: In function 'jz4780_i2c_writew': > drivers/i2c/busses/i2c-jz4780.c:187:2: error: > implicit declaration of function 'writew' > > seen with sparc64:allmodconfig and m68k:allmodconfig. > > The driver depends on HAS_IOMEM, and must include linux/io.h. > > Fixes: ba92222ed63a ("i2c: jz4780: Add i2c bus controller driver > for Ingenic JZ4780") > Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> > Signed-off-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> > --- > drivers/i2c/busses/Kconfig | 1 + > drivers/i2c/busses/i2c-jz4780.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 2255af23b9c7..c78b6cbd1106 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -586,6 +586,7 @@ config I2C_IOP3XX > config I2C_JZ4780 > tristate "JZ4780 I2C controller interface support" > depends on MACH_JZ4780 || COMPILE_TEST > + depends on HAS_IOMEM You sure? We have menu "I2C Hardware Bus support" depends on HAS_IOMEM in drivers/i2c/busses/Kconfig. For me, menuconfig shows that the driver is already depending on HAS_IOMEM. > help > If you say yes to this option, support will be included for the > Ingenic JZ4780 I2C controller. > diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c > index ce1d69324169..f2761ab2ef32 100644 > --- a/drivers/i2c/busses/i2c-jz4780.c > +++ b/drivers/i2c/busses/i2c-jz4780.c > @@ -21,6 +21,7 @@ > #include <linux/delay.h> > #include <linux/errno.h> > #include <linux/i2c.h> > +#include <linux/io.h> > #include <linux/init.h> > #include <linux/interrupt.h> > #include <linux/kernel.h> The sorting needs to be fixed. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-15 15:41 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-15 3:21 [PATCH] i2c: jz4780: Fix build for m68k and sparc64 Guenter Roeck 2015-04-15 3:21 ` Guenter Roeck 2015-04-15 15:41 ` Wolfram Sang [this message] 2015-04-15 15:41 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150415154122.GA914@katana \ --to=wsa@the-dreams.de \ --cc=Zubair.Kakakhel@imgtec.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.